1863400 - Move about:welcome code out from browser/components/newtab into its own browser/components directory

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

The code powering the current version of about:welcome has lived under browser/components/newtab since its inception in bug 1616370. It shares some of newtab's infrastructure for things like testing, linting, and building / webpacking / bundling.

We're going to be investing some more in newtab in the coming months, and one thing I'd like to do is try to decouple about:newtab from things like about:welcome so that newtab changes do not adversely affect these other components.

My suggestion is to move the code powering about:welcome into a new directory browser/components/welcome.

Hey Gijs - I've gotten a thumbs up from pdahiya to attempt this. Any objections if I try to move about:welcome into `browser/components/welcome"?

Comment 1

[:Gijs (he/him)]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #0)

Hey Gijs - I've gotten a thumbs up from pdahiya to attempt this. Any objections if I try to move about:welcome into `browser/components/welcome"?

No objections, though could we make it aboutWelcome or similar? :-)

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1863400 - Part 1: Move about:welcome mochitest-browser tests to browser/components/aboutwelcome folder. r?pdahiya!,Gijs!

This clones many of the ESLint rules from browser/components/newtab over as well.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1863400 - Part 2: Move AboutWelcome parent and child JSWindowActors to browser/components/aboutwelcome folder. r?pdahiya!

Depends on D193116

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1863400 - Part 3: Move some about:welcome modules into browser/components/aboutwelcome folder. r?pdahiya!

Depends on D193117

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1863400 - Part 4: Move static about:welcome content into browser/components/aboutwelcome folder. r?pdahiya!

Depends on D193118

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1863400 - Part 5: Move bundled about:welcome components into browser/components/aboutwelcome folder. r?pdahiya!

Depends on D193119

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1863400 - Part 6: Perform bundling within browser/components/aboutwelcome folder. r?pdahiya!

Depends on D193120

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1863400 - Part 7: Move about:welcome Karma unit tests to browser/components/aboutwelcome folder. r?pdahiya!

Depends on D193121

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1863400 - Part 8: Update stylelint, eslint, prettierignore, hgignore, gitignore and Generated.txt rules for aboutwelcome to match newtab. r?pdahiya!

Depends on D193122

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1863400 - Part 9: Hack the newtab try-runner.js script to also run about:welcome tests and coverage. r?pdahiya!

This is fairly gross, but basically it uses some directory manipulation to run the
bundling steps and karma tests for both browser/components/newtab and
browser/components/aboutwelcome.

It then also takes the lcov.info files generated by both test runs and
concatenates them together before zipping them up.

Bug 1866170 covers creating a try-runner.js script for
browser/components/aboutwelcome.

Depends on D193228

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b06088e7bf14
Part 1: Move about:welcome mochitest-browser tests to browser/components/aboutwelcome folder. r=pdahiya,Gijs
https://hg.mozilla.org/integration/autoland/rev/2e4ea1016d37
Part 2: Move AboutWelcome parent and child JSWindowActors to browser/components/aboutwelcome folder. r=pdahiya
https://hg.mozilla.org/integration/autoland/rev/248515a053d2
Part 3: Move some about:welcome modules into browser/components/aboutwelcome folder. r=pdahiya
https://hg.mozilla.org/integration/autoland/rev/fa9e5979e8f5
Part 4: Move static about:welcome content into browser/components/aboutwelcome folder. r=pdahiya,desktop-theme-reviewers,dao
https://hg.mozilla.org/integration/autoland/rev/edb7a5027680
Part 5: Move bundled about:welcome components into browser/components/aboutwelcome folder. r=pdahiya,aminomancer
https://hg.mozilla.org/integration/autoland/rev/47ce0e918be8
Part 6: Perform bundling within browser/components/aboutwelcome folder. r=pdahiya
https://hg.mozilla.org/integration/autoland/rev/c72ffc74e4fa
Part 7: Move about:welcome Karma unit tests to browser/components/aboutwelcome folder. r=pdahiya
https://hg.mozilla.org/integration/autoland/rev/d5ae6f352563
Part 8: Update stylelint, eslint, prettierignore, hgignore, gitignore and Generated.txt rules for aboutwelcome to match newtab. r=pdahiya
https://hg.mozilla.org/integration/autoland/rev/b34bd4e8f5e5
Part 9: Hack the newtab try-runner.js script to also run about:welcome tests and coverage. r=pdahiya,ahal,dmose

Comment 12

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b06088e7bf14
https://hg.mozilla.org/mozilla-central/rev/2e4ea1016d37
https://hg.mozilla.org/mozilla-central/rev/248515a053d2
https://hg.mozilla.org/mozilla-central/rev/fa9e5979e8f5
https://hg.mozilla.org/mozilla-central/rev/edb7a5027680
https://hg.mozilla.org/mozilla-central/rev/47ce0e918be8
https://hg.mozilla.org/mozilla-central/rev/c72ffc74e4fa
https://hg.mozilla.org/mozilla-central/rev/d5ae6f352563
https://hg.mozilla.org/mozilla-central/rev/b34bd4e8f5e5