1864038 - Add keyboard shortcuts for screenshots when a region is selected

Status: VERIFIED FIXED

(Firefox :: Screenshots, enhancement, P2)

Description

[Niklas Baumgardner [:niklas]]

ctrl + c should copy the selected region and we're thinking ctrl + s should download the selected region

Comment 1

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1864038 - Add keyboard shortcuts for screenshots overlay. r=sfoster

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4bcd94d558a6
Add keyboard shortcuts for screenshots overlay. r=sfoster,fluent-reviewers,bolsson,desktop-theme-reviewers

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failure on browser_screenshots_drag_scroll_test.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/e671151bfabacce701efa23e3a1edd29c398d78b
Log link: https://treeherder.mozilla.org/logviewer?job_id=453055560&repo=autoland&lineNumber=6846

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13111643fbf4
Add keyboard shortcuts for screenshots overlay. r=sfoster,fluent-reviewers,bolsson,desktop-theme-reviewers

Comment 7

[Norisz Fay [:noriszfay]]

Backed out for causing bc failures on browser_screenshots_drag_scroll_test.js

Backout link

Push with failures

Failure log

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d41d18cecc78
Add keyboard shortcuts for screenshots overlay. r=sfoster,fluent-reviewers,bolsson,desktop-theme-reviewers

Comment 9

[Cristian Tuns]

Backed out for causing bc failures in browser_screenshots_drag_scroll_test.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/screenshots/tests/browser/browser_screenshots_drag_scroll_test.js | Uncaught exception in test bound test_scrollIfByEdge - Waiting for window to scroll to 990, 990 - timed out after 50 tries.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74ade7d0f955
Add keyboard shortcuts for screenshots overlay. r=sfoster,fluent-reviewers,bolsson,desktop-theme-reviewers

Comment 11

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/74ade7d0f955

Comment 13

[Simona Badau, Desktop QA]

Verified as fixed using the latest Nightly 127.0a1 and Firefox 126.0b5 (while screenshots.browser.component.enabled is set to true in about:config) on macOS 13, Ubuntu 22.04 and Windows 10 x64 - both key shortcuts Ctrl/Cmd + C and Ctrl/Cmd + S can be properly used to copy and download a screenshot region.