1864124 - Advanced address book search throws if condition is empty

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Magnus Melin [:mkmelin]]

In address book, Edit | Find | Search addresses. Leave display name empty, hit search.

Uncaught NS_ERROR_ILLEGAL_VALUE: Failed to create condition string from name=DisplayName, condition=c, value=, cond=2
createBooleanConditionString resource:///modules/QueryStringToExpression.jsm:167
convert resource:///modules/QueryStringToExpression.jsm:55
search resource:///modules/LDAPDirectory.jsm:187
ABView chrome://messenger/content/addressbook/abView.js:23
SetAbView chrome://messenger/content/addressbook/abResultsPane.js:73
onSearch chrome://messenger/content/addressbook/abSearchDialog.js:333
onSearchButton chrome://messenger/content/addressbook/abSearchDialog.js:342
oncommand chrome://messenger/content/addressbook/abSearchDialog.xhtml:1
QueryStringToExpression.jsm:167

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1864124 - Handle advanced address book search with empty name. r=#thunderbird-reviewers

Don't throw, show the address book listing without limitation instead.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e4b2a40488f4
Handle advanced address book search with empty name. r=john.bieling

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9362972 [details]
Bug 1864124 - Handle advanced address book search with empty name. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): unknown
User impact if declined: searching address without criteria doesn't end well
Testing completed (on c-c, etc.): c-c, beta
Risk to taking this patch (and alternatives if risky): safe. We can also wontfix as it's not a huge issue.

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9362972 [details]
Bug 1864124 - Handle advanced address book search with empty name. r=#thunderbird-reviewers

[Triage Comment]
approved for esr115

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 115.5.1:
https://hg.mozilla.org/releases/comm-esr115/rev/a29f6f75167c