18644 - Table width miscalculations with NOWRAP and COLSPAN attributes

Status: VERIFIED FIXED

(Core :: Layout: Tables, defect, P3)

Description

[msw]

When viewing http://www.mozilla.org/unix/dpi.html, resizing the window to 742
pixels on my system causes the table to the left to misfill.  The following
warning message is repeated several times while rendering the page:

WARNING: over allocated: 'totalAllocated <= maxWidth', file
../../../../../layout/html/table/src/BasicTableLayoutStrategy.cpp, line 316

Sizing the window to 741 pixels makes the table render properly.  You may need
to resize to a different width to see the problem.

I'm attaching a screenshot of the misrendered page.

Comment 1

[msw]

Attachment: Screenshot of table misrender

Comment 2

[msw]

The misrendering happens on http://www.mozilla.org/ as well, but the browser
window must be much wider (~1800 pixels).

Comment 3

[Dawn Endico]

This is wacky. The rows in the table containing the menu have gigantic colspans,
much bigger than the width of the table. This is apparently a kludge to
workaround some problem that doesn't seem to exist any more. I'll fix the web
site.

I suppose this counts as a quirks mode bug since this doesn't happen with 4.6.

_______________________
|      COLSPAN = 20    |
------------------------
|         |            |
| <empty> | COLSPAN=19 |
|         |            |
------------------------

Comment 4

[Dawn Endico]

Attachment: test case where colspan is greater than the number of columns

Comment 5

[Dawn Endico]

Attachment: shows the test case where an embedded table overflows the table that's supposed to contain it.

Comment 6

[Dawn Endico]

The test case I added shows that this happens when the colspan on <TD> tags is
set to a number greater than the number of available columns.

The TD containing "At A Glance" has no columns after it so it can have at most,
colspan=1. if its colspan is set to 2 or more and the colspan of the row above
is set to more than the span of "At a Glance" then this problem occurs.

If the window is resized then the table collapses and displays the way it was
intended.

Comment 7

[msw]

Attachment: Simple test case for this bug.

Comment 8

[msw]

Attachment: screenshot of a misrender of this bug

Comment 9

[msw]

From my testcase:

This page has two tables on it.  The outer table's border will be
smaller on the right than the inner table's boarder when the browser is
at certain sizes.  The browser must be wide enought to not wrap the
text in table 2 R2 C1, and the width of the browser must be less than
the width of the inner table.

This behavior is NOT exhibited if Table 2 R1 C2 does not have the
NOWRAP attribute.

The browser needs to wrap Table 2 R2 C1 to allow Table 2 R1 C2 to fit onto the
screen.  It's almost as though R1 C2's space requirement isn't taken into
account when calculating when to wrap R2 C1.

Comment 10

[msw]

Attachment: More complex testcase that shows even proper table html exhibits the problem

Comment 11

[msw]

Attachment: Screenshot of above testcase misrendered

Comment 12

[msw]

Notice, also the horizontal scrollbar is missing when the inner table's bounds
extend past the area viewable by the browser.

Comment 13

[ekrock's old account (dead)]

Bulk moving [testcase] code to new testcase keyword. Sorry for the spam!

Comment 14

[karnaze (gone)]

Moving to M15.

Comment 15

[Hixie (not reading bugmail)]

COLSPAN is not technically part of CSS2, and rendering not part of HTML4, but
this problem is related to support for both, so adding relevant markers.

Comment 16

[karnaze (gone)]

mass move to m16

Comment 17

[Samuel Sieb]

Attachment: Simple test case using <IMG> instead of NOWRAP

Comment 18

[Samuel Sieb]

Discovered a similar bug using <IMG> <a
href="http://bugzilla.mozilla.org/showattachment.cgi?attach_id=7697">
(id=7697)</a>
(I hope this works, mozilla is doing strange things in this text box...)

Comment 19

[karnaze (gone)]

Moving to M18.

Comment 20

[karnaze (gone)]

This bug has been marked "future" because we have determined that it is not 
critical for netscape 6.0. If you feel this is an error, or if it blocks your 
work in some way -- please attach your concern to the bug for reconsideration.

Comment 21

[Jonas Nagel]

I would though consider this rather important, since this bug seems to affect
more pages than you expected...I have an example on one which absolutely loses
its design and everything. ;(

Please check if http://www.netstream.ch and its subpages (main seems to work
fine) fall into this bug.

Comment 22

[Jonas Nagel]

Well I see this not happening anymore (i.e. can't reproduce with the testcases
anymore), it might have been fixed in conjunction with another bug...dare to
mark/verify this fixed? Reporter? Owner? Anyone?

Comment 23

[Samuel Sieb]

I tested on Linux and compared with an old build. It looks like it got fixed
somehow.  Very nice!

Comment 24

[Bernd]

bug 14929 colspan cell's should honour percentage width's
was fixed in september
marking as fixed

Comment 25

[Christine Hoffman]

Tested on Win, Mac and Linux with 11/21 trunk builds. Verifying fixed.

Comment 26

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/85e6a5c8460d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18644 - Temporarily disabling UI tests that fail on Firebase.
https://hg.mozilla.org/releases/mozilla-beta/rev/6d2f57d47b31
[fenix] Re-enable working UI tests from https://github.com/mozilla-mobile/fenix/issues/18644
https://hg.mozilla.org/releases/mozilla-beta/rev/ca3845c286f4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18644: fix metod to verify system notifications