1864517 - "See tabs from synced devices" should link to "Tabs from other devices" in Firefox View

Status: VERIFIED FIXED

(Firefox :: Firefox View, enhancement, P2)

Description

[Amy Lee [:amylee] UX]

Attachment: Screen Shot 2023-11-13 at 2.59.12 PM.png

When you connect a new device, at the end of the flow there is a button that reads "See tabs from synced devices".

Current:
"See tabs from synced devices" – links to "Recent browsing" page in Firefox View.

Requested change:
"See tabs from synced devices" – Link to "Tabs from other devices" page in Firefox View.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Sam, are you able to take this? Here's what I've worked out so far:

• This form is on FxA and clicking the button invokes this server code - note how the entryPoint is always "preferences".
• That ends up in a webchannel, which we handle in the browser FxA code here - note I expect entryPoint to be a string with the value "preferences" here.
• That ends up calling firefox view specific code here which (a) seems to expect the param is an event instance rather than a string and (b) doesn't appear to have the ability to link to a specific part of Firefox View, just to the top-level element as shown in Amy's screenshot.

So what I think might need to happen is something like:

• That Firefox View code grows the ability to link to a specific section (or maybe I just misread it?)
• The FxA web-channel code assume "preferences" really means "the synced-tabs section" and specifies that as the argument. which specifies that section.
• We open an issue on FxA to "fix" this entryPoint so the server becomes capable of opening other links to other Firefox View sections without our intervention.
• We end up removing the "'preferences' means synced-tabs section" and attempt to use the server-supplied section directly.

If that all sounds OK to you, can you please move this into your component and bring it to the attention of your PMs etc?

Thanks!

Comment 2

[Sam Foster [:sfoster] (he/him)]

I'll move this to the firefox view component and we can take a look when we triage next week. We do have a location hash for the different "pages" in the new firefox view, so I don't think it would be too difficult to link over to the correct spot.

Comment 3

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1864517 - "See tabs from synced devices" should link to the synced tabs category in Firefox View r=#fxview-reviewers

Previously the "See tabs from synced devices" button redirected to about:firefoxview.

This patch updates the openTab function to accept a category and hardcodes "syncedtabs" as the category in the openFirefoxView function.

Ideally we should open an issue in FxA to update the following entryPoint which appears to assume "preferences" is catergory.
https://github.com/mozilla/fxa/blob/2b2ee47c4bf20f75cf3c49e87a1e3865ab804c1f/packages/fxa-content-server/app/scripts/views/pair/auth_complete.js#L55-L63

Depends on D196208

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c1ceb6517d0
"See tabs from synced devices" should link to the synced tabs category in Firefox View r=fxview-reviewers,markh,kcochrane

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/2c1ceb6517d0

Comment 6

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Verified that by following the sync flow and selecting "See tabs from synced devices" will now forward the user to "Tabs from other devices" page in Firefox View. Tests were performed on Firefox 123.0b3 on macOS 13.6.4, Ubuntu 22.04 and Windows 11.