Remove old Firefox view code, tests and update the redirector
Categories
(Firefox :: Firefox View, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox123 | --- | fixed |
People
(Reporter: sfoster, Assigned: nsharpley)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fidefe-firefox-view])
Attachments
(1 file)
about:firefoxview currently points at the original Firefox View UX, as implemented in browser/components/firefoxview/firefoxview.html, and about:firefoxview-next results in firefoxview-next.html loading.
Although the primary way to access Firefox View is the toolbar button, we informally support directly loading it view the about:firefoxview URL, and this should be updated to point at the currently-shipping experience. We can do that by only updating the redirector itself, or by renaming files so that firefoxview-next.html becomes firefoxview.html. And maybe what was firefoxview.html becomes firefoxview-legacy.html?
This will involve updating tests, and if we want to keep the old experience working alongside the new, we'll probably want a about:firefoxview-legacy redirector so we can make the change incrementally.
The decision to do this (vs. waiting until we can just remove the old experience and move everything firefoxview-next over to firefoxview should be made in the context of a broader discussion about how we want to manage major changes going forward.
|
||
Updated•6 months ago
|
|
||
Comment 1•6 months ago
|
||
I'll confirm with product but I can't think of a reason to keep the old firefox view code around, and I think you're right that this should be in a patch with all work to remove old firefox view rather than supporting legacy firefox view.
Regarding potential future work, if we again find ourselves in a position of needing to work in a temporary about page, it shouldn't be difficult to re-add firefoxview-next, but I don't think we need to block on that decision.
|
|
||
Comment 2•6 months ago
|
||
Lets just remove the old code and tests - being sure to port over any that is needed first such as for synced tabs - and update the redirector in the same patch.
|
||
Updated•5 months ago
|
|
Reporter | |
Comment 3•5 months ago
|
||
We'll actually remove the tests as a first step in bug 1869605.
|
Assignee | |
Comment 4•5 months ago
|
||
- removes about:firefoxview-next route
- about:firefoxview now points to firefoxview-next.html (until we rename)
- remove pref for browser.tabs.firefox-view-next
- preserve pref for browser.tabs.firefox-view-newIcon as part of firefoxViewNext feature manifest (until experiment is over)
Depends on D196080
|
||
Comment 5•5 months ago
|
||
Comment on attachment 9368285 [details]
Bug 1864534 - remove firefox-view-next pref and update about AboutRedirector r=sfoster
Revision D196093 was moved to bug 1850501. Setting attachment 9368285 [details] to obsolete.
|
|
||
Updated•5 months ago
|
|
|
||
Comment 6•5 months ago
|
||
Comment on attachment 9368285 [details]
Bug 1864534 - remove firefox-view-next pref and update about AboutRedirector r=sfoster
Revision D196093 was moved to bug 1850501. Setting attachment 9368285 [details] to obsolete.
|
|
||
Updated•5 months ago
|
|
|
||
Updated•5 months ago
|
Pushed by nsharpley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/576e61e3970b remove firefox-view-next pref and update about AboutRedirector r=fxview-reviewers,Gijs
|
||
Comment 8•5 months ago
|
||
Backed out for causing several browser chrome failures.
Failure logs:
- browser_all_files_referenced.js | there should be no unreferenced files - Got 8, expected +0 - https://treeherder.mozilla.org/logviewer?job_id=441174529&repo=autoland
- browser/browser_sma_click_element.js | Uncaught exception in test bound test_CLICK_ELEMENT - undefined - timed out after 50 tries - https://treeherder.mozilla.org/logviewer?job_id=441174375&repo=autoland
- browser_blanking.js | Uncaught exception in test bound - at resource://testing-common/BrowserTestUtils.sys.mjs:260 - TypeError: can't access property "linkedBrowser", tab is null - https://treeherder.mozilla.org/logviewer?job_id=441174459&repo=autoland
- firefoxview-next/browser_firefoxview_next.js | undefined assertion name - Got "about:firefoxview", expected "about:firefoxview-next - https://treeherder.mozilla.org/logviewer?job_id=441177590&repo=autoland
- browser_feature_callout.js | A promise chain failed to handle a rejection: can't access property "template", this.message is null - stack: showFeatureCallout@resource:///modules/FeatureCallout.sys.mjs - https://treeherder.mozilla.org/logviewer?job_id=441173308&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/f01c568edb2688a905c351e7d49676130ca5e354
Pushed by nsharpley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6aab4af4cab8 remove firefox-view-next pref and update about AboutRedirector r=fxview-reviewers,Gijs
|
||
Comment 10•4 months ago
|
||
Backed out changeset 6aab4af4cab8 (Bug 1864534) for causing failures in browser_syncedtabs_firefoxview_next.js CLOSED TREE
Log: https://treeherder.mozilla.org/logviewer?job_id=442045344&repo=autoland&lineNumber=6937
Backout: https://hg.mozilla.org/integration/autoland/rev/3d6c40b854ea9e9685f28218ddd4e11d4365919e
|
||
Comment 11•4 months ago
|
||
Pushed by nsharpley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0a133d5fd155 remove firefox-view-next pref and update about AboutRedirector r=fxview-reviewers,Gijs
|
|
||
Comment 12•4 months ago
|
||
Backed out for causing screenshot related failures.
Failure log:
Backout link: https://hg.mozilla.org/integration/autoland/rev/88c60d678bab0f2b1cdd19c17fd3cecd98916766
|
|
||
Comment 13•4 months ago
|
||
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c2654b23e1c4 remove firefox-view-next pref and update about AboutRedirector r=fxview-reviewers,Gijs
|
|
||
Comment 14•4 months ago
|
||
Failures were actually from changes in Bug 1845150.
|
||
Comment 15•4 months ago
|
||
| bugherder | ||
Description
•