1864684 - Enable pref dom.cache.privatebrowsing.enabled by default

Status: RESOLVED FIXED

(Core :: Storage: Cache API, task)

Description

[Harveer Singh]

As per the summary, enable pref dom.cache.privatebrowsing.enabled by default.

Comment 1

[Harveer Singh]

Attachment: Bug 1864684: Enabled CacheAPI PBM pref by default.r=#dom-storage-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d56a4ca03754
Enabled CacheAPI PBM pref by default.r=dom-storage-reviewers,jstutte,janv,asuth,timhuang

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures at toolkit/components/antitracking/test/browser/browser_partitionedDOMCache.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/8dde1f563468bd246dff71c96a31d7f075ce7d56

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | toolkit/components/antitracking/test/browser/browser_partitionedDOMCache.js | DOM Cache should not be available in PBM - false == true - got false, expected true (operator ==)

Comment 4

[Harveer Singh]

Attachment: Bug 1864684: Adjusting some tests for PBM.r=#dom-storage-reviewers

Depends on D193568

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd9633029322
Enabled CacheAPI PBM pref by default.r=dom-storage-reviewers,jstutte,janv,asuth,timhuang
https://hg.mozilla.org/integration/autoland/rev/14a6d4cb8291
Adjusting test in browser_partitionedDOMCache.js for PBM.r=dom-storage-reviewers,anti-tracking-reviewers,janv,pbz

Comment 6

[Cristian Tuns]

Backed out for causing bc failures in browser_cache_pb_window.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | dom/cache/test/browser/browser_cache_pb_window.js | caches.match() should not return success - false == true - got false, expected true (operator ==)

Comment 7

[Harveer Singh]

Seems like another test needs to be adjusted. I am running extensive list of tests in my latest try run. Hopefully, it would be able to detect other similar tests.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b9eec1d5f13
Enabled CacheAPI PBM pref by default.r=dom-storage-reviewers,jstutte,janv,asuth,timhuang
https://hg.mozilla.org/integration/autoland/rev/73a1e10462cf
Adjusting some tests for PBM.r=dom-storage-reviewers,anti-tracking-reviewers,janv,pbz

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7b9eec1d5f13
https://hg.mozilla.org/mozilla-central/rev/73a1e10462cf

Comment 10

[Harveer Singh]

Release Note Request (optional, but appreciated)
[Why is this notable]: This change would enable scripts to store cacheAPI data in Private Browsing mode. Previously, user experience for someone browsing in private browsing mode could be significantly different than one in regular mode. With these changes, websites would be able to store cacheAPI data in private mode and take us step closer towards offering uniform experience in regular vs private browsing mode.

[Suggested wording]:
[Links (documentation, blog post, etc)]: https://docs.google.com/document/d/1lSqDS53RsPq7SWZJsy_hK1-DsXlbegj6c-0DrBerqVQ/edit?usp=sharing

Comment 11

[Donal Meehan [:dmeehan]]

Thanks, added a slightly reworded note to the Fx122 nightly release notes, please allow 30 minutes for the site to update.
Keeping the relnote-firefox flag as ? to keep it on the radar for inclusion in the final Fx122 release notes