Closed Bug 1864684 Opened 7 months ago Closed 6 months ago

Enable pref dom.cache.privatebrowsing.enabled by default

Categories

(Core :: Storage: Cache API, task)

task

Tracking

()

RESOLVED FIXED
122 Branch
Tracking Status
relnote-firefox --- 122+
firefox122 --- fixed

People

(Reporter: hsingh, Assigned: hsingh)

References

Details

Attachments

(2 files)

As per the summary, enable pref dom.cache.privatebrowsing.enabled by default.

Status: NEW → ASSIGNED
Pushed by hsingh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d56a4ca03754
Enabled CacheAPI PBM pref by default.r=dom-storage-reviewers,jstutte,janv,asuth,timhuang

Depends on D193568

Attachment #9366495 - Attachment description: Bug 1864684: Adjusting some tests.r=#dom-storage-reviewers → Bug 1864684: Adjusting test in browser_partitionedDOMCache.js for PBM.r=#dom-storage-reviewers
Pushed by hsingh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cd9633029322
Enabled CacheAPI PBM pref by default.r=dom-storage-reviewers,jstutte,janv,asuth,timhuang
https://hg.mozilla.org/integration/autoland/rev/14a6d4cb8291
Adjusting test in browser_partitionedDOMCache.js for PBM.r=dom-storage-reviewers,anti-tracking-reviewers,janv,pbz
Flags: needinfo?(hsingh)

Backed out for causing bc failures in browser_cache_pb_window.js

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | dom/cache/test/browser/browser_cache_pb_window.js | caches.match() should not return success - false == true - got false, expected true (operator ==)
Flags: needinfo?(hsingh)

Seems like another test needs to be adjusted. I am running extensive list of tests in my latest try run. Hopefully, it would be able to detect other similar tests.

Flags: needinfo?(hsingh)
Attachment #9366495 - Attachment description: Bug 1864684: Adjusting test in browser_partitionedDOMCache.js for PBM.r=#dom-storage-reviewers → Bug 1864684: Adjusting some tests for PBM.r=#dom-storage-reviewers
Pushed by hsingh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7b9eec1d5f13
Enabled CacheAPI PBM pref by default.r=dom-storage-reviewers,jstutte,janv,asuth,timhuang
https://hg.mozilla.org/integration/autoland/rev/73a1e10462cf
Adjusting some tests for PBM.r=dom-storage-reviewers,anti-tracking-reviewers,janv,pbz
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
Regressions: 1868448
No longer regressions: 1868448

Release Note Request (optional, but appreciated)
[Why is this notable]: This change would enable scripts to store cacheAPI data in Private Browsing mode. Previously, user experience for someone browsing in private browsing mode could be significantly different than one in regular mode. With these changes, websites would be able to store cacheAPI data in private mode and take us step closer towards offering uniform experience in regular vs private browsing mode.

[Suggested wording]:
[Links (documentation, blog post, etc)]: https://docs.google.com/document/d/1lSqDS53RsPq7SWZJsy_hK1-DsXlbegj6c-0DrBerqVQ/edit?usp=sharing

relnote-firefox: --- → ?

Thanks, added a slightly reworded note to the Fx122 nightly release notes, please allow 30 minutes for the site to update.
Keeping the relnote-firefox flag as ? to keep it on the radar for inclusion in the final Fx122 release notes

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: