1864751 - Add a check for keyboard focusable URL bar buttons in AccessibilityUtils

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[❌ Anna Yeddi [:ayeddi] ❌ On leave until 2027-01-04]

Add an additional check similar to the isKeyboardFocusableBrowserToolbarButton check that could pass the one-off search items and settings within the awesome bar, since these buttons are navigable with arrow keys deliberately.

Comment 1

[❌ Anna Yeddi [:ayeddi] ❌ On leave until 2027-01-04]

Attachment: Bug 1864751 - Add checks for keyboard focusable URL bar one-off buttons and results options in AccessibilityUtils. r=Jamie!

Add an additional check similar to the isKeyboardFocusableBrowserToolbarButton check that could pass the one-off search items and settings within the awesome bar, since these buttons are navigable with arrow keys deliberately.

Comment 2

[❌ Anna Yeddi [:ayeddi] ❌ On leave until 2027-01-04]

Search And Address Bar tests that should be passing after the change:

browser/components/urlbar/tests/browser/browser_inputHistory.js
browser/components/urlbar/tests/browser/browser_oneOffs_keyModifiers.js
browser/components/urlbar/tests/browser/browser_oneOffs_searchSuggestions.js
browser/components/urlbar/tests/browser/browser_oneOffs.js
browser/components/urlbar/tests/browser/browser_quickactions_screenshot.js
browser/components/urlbar/tests/browser/browser_quickactions.js
browser/components/urlbar/tests/browser/browser_searchMode_autofill.js
browser/components/urlbar/tests/browser/browser_searchMode_clickLink.js
browser/components/urlbar/tests/browser/browser_searchMode_engineRemoval.js
browser/components/urlbar/tests/browser/browser_searchMode_excludeResults.js
browser/components/urlbar/tests/browser/browser_searchMode_heuristic.js
browser/components/urlbar/tests/browser/browser_searchMode_pickResult.js
browser/components/urlbar/tests/browser/browser_searchMode_sessionStore.js
browser/components/urlbar/tests/browser/browser_searchMode_setURI.js
browser/components/urlbar/tests/browser/browser_searchSettings.js
browser/components/urlbar/tests/browser/browser_shortcuts_add_search_engine.js
browser/components/urlbar/tests/browser/browser_switchToTab_chiclet.js
browser/components/urlbar/tests/browser/browser_tabKeyBehavior.js
browser/components/urlbar/tests/browser/browser_tokenAlias.js
browser/components/urlbar/tests/browser/browser_urlbar_telemetry.js
browser/components/urlbar/tests/browser/browser_UrlbarInput_searchTerms_searchMode.js
browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_abandonment_search_mode.js
browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_search_mode.js
browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_impression_search_mode.js

and from the Session Restore component (bug 1854529):
browser/components/sessionstore/test/browser_urlbarSearchMode.js

Part of the failures would be resolved for the following tests (more failures and warnings are to be investigated for these test files, tracked separately under the bug 1854661):

browser/components/search/test/browser/browser_searchbar_addEngine.js
browser/components/search/test/browser/telemetry/browser_search_telemetry_searchbar.js
browser/components/urlbar/tests/browser/browser_placeholder.js
browser/components/urlbar/tests/browser/browser_remove_match.js
browser/components/urlbar/tests/browser/browser_searchMode_indicator_clickthrough.js
browser/components/urlbar/tests/browser/browser_searchMode_indicator.js
browser/components/urlbar/tests/browser/browser_searchMode_oneOffButton.js
browser/components/urlbar/tests/browser/browser_searchMode_preview.js
browser/components/urlbar/tests/browser/browser_searchMode_suggestions.js
browser/components/urlbar/tests/browser/browser_searchMode_switchTabs.js
browser/components/urlbar/tests/browser/browser_top_sites.js
browser/components/urlbar/tests/browser/browser_urlbar_telemetry_searchmode.js

Comment 3

[❌ Anna Yeddi [:ayeddi] ❌ On leave until 2027-01-04]

Attachment: Bug 1864751 - Pt.2. Remove fail-if notations for a11y_checks of one-off-items in Search and Address Bar and Session Restore. r=standard8,adw!,dao,Jamie!,#sessionstore-reviewers

With the AccessibilityUtils tests updated in D193591 to pass a11y_checks for for keyboard focusable URL bar's .searchbar-engine-one-off-item buttons and .urlbarView-row-inner results options that are purposefully made focusable with arrow keys only (instead of a Tab that would create more tiring, cumbersome experience navigating Awesomebar for keyboard-only users), we could now remove the fail-if notations from a series of tests that were previously failing. Also, there are 12 tests that would also be affected, but they have other elements that are throwing warning or failing a11y_checks besides the one-off controls, thus we'd be keeping them to expect to fail until these items are resolved separately.

These tests were fail-ifed by bug 1854660 and bug 1854528, before the investigation in the meta bug 1854661 and bug 1854529.

Depends on D193591

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6927a10fe832
Add checks for keyboard focusable URL bar one-off buttons and results options in AccessibilityUtils. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/6d2982d16908
Pt.2. Remove fail-if notations for a11y_checks of one-off-items in Search and Address Bar and Session Restore. r=adw,Jamie,sessionstore-reviewers,sclements

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6927a10fe832
https://hg.mozilla.org/mozilla-central/rev/6d2982d16908