1864955 - "mach try coverage" fails with AttributeError

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, defect, P3)

Description

[Geoff Brown [:gbrown]]

mach try coverage fails:

AttributeError: 'NoneType' object has no attribute 'topsrcdir'

  File "/home/gbrown/src/python/mach/mach/main.py", line 287, in run
    return self._run(argv)
  File "/home/gbrown/src/python/mach/mach/main.py", line 348, in _run
    args = parser.parse_args(argv)
  File "/home/gbrown/.pyenv/versions/3.9.7/lib/python3.9/argparse.py", line 1820, in parse_args
    args, argv = self.parse_known_args(args, namespace)
  File "/home/gbrown/.pyenv/versions/3.9.7/lib/python3.9/argparse.py", line 1853, in parse_known_args
    namespace, args = self._parse_known_args(args, namespace)
  File "/home/gbrown/.pyenv/versions/3.9.7/lib/python3.9/argparse.py", line 2065, in _parse_known_args
    stop_index = consume_positionals(start_index)
  File "/home/gbrown/.pyenv/versions/3.9.7/lib/python3.9/argparse.py", line 2021, in consume_positionals
    take_action(action, args)
  File "/home/gbrown/.pyenv/versions/3.9.7/lib/python3.9/argparse.py", line 1930, in take_action
    action(self, namespace, argument_values, option_string)
  File "/home/gbrown/src/python/mach/mach/dispatcher.py", line 194, in __call__
    if handler.parser:
  File "/home/gbrown/src/python/mach/mach/decorators.py", line 105, in parser
    self._parser = self._parser()
  File "/home/gbrown/src/tools/tryselect/mach_commands.py", line 31, in __call__
    mod = importlib.import_module("tryselect.selectors.{}".format(self.selector))
  File "/home/gbrown/.pyenv/versions/3.9.7/lib/python3.9/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 850, in exec_module
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "/home/gbrown/src/tools/tryselect/selectors/coverage.py", line 122, in <module>
    all_tests, all_support_files = read_test_manifests()
  File "/home/gbrown/src/tools/tryselect/selectors/coverage.py", line 89, in read_test_manifests
    file_finder = FileFinder(build.topsrcdir)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox Build System::Mach Core' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Alex Hochheiden [:ahochheiden]]

I'm not sure what caused the problem, but the fix seems simple.

Comment 3

[Alex Hochheiden [:ahochheiden]]

Attachment: Bug 1864955 - Add missing `setup_globals()` call to `read_test_manifests()` r?ahal

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5f673d57090
Add missing `setup_globals()` call to `read_test_manifests()` r=ahal

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c5f673d57090