1865124 - Add support for "browsingContext.traverseHistory" command on Android without fission

Status: NEW

(Remote Protocol :: WebDriver BiDi, task, P3)

Description

[Alexandra Borovova [:Sasha]]

The implementation of browsingContext.traverseHistory, introduced in the scope of the bug1841018, uses browsingContext.sessionHistory property, which is not available on Android with fission disabled. In the scope of this bug, we should either investigate why browsingContext.sessionHistory is not available or use another way to get information about current history index and the amount of entries.

Comment 1

[Alexandra Borovova [:Sasha]]

Hi Olivia,
as mentioned in this bug, we're currently implementing browsingContext.traverseHistory and we noticed that browsingContext.sessionHistory property on Android with fission disabled equals null, it works fine with fission enabled. Do you maybe know anything about it? Is it maybe a bug or just something which is not implemented?

Comment 2

[Olivia Hall [:olivia]]

Hi Alexandra,

Thanks for taking a look into this area!

My understanding is that there are a lot of considerations with session history on GeckoView and we are actively making changes. Let me redirect this question to either owlish or kaya, who are both working on Fission and have background on session history.

Comment 3

[Kayacan Kaya [:kaya]]

Hi :Sasha,

Thank you very much for bringing this up and :olivia for letting me know of this :)

browsingContext.sessionHistory will be a part of enabling SHIP on Android regardless of fission being enabled/disabled. It is used in GeckoViewSessionStore's SHistoryListener for collecting the history from parent. We will ship it without Fission. Worth to note, enabling Fission automatically makes use of SHIP iirc.

Currently I am working on enabling SHIP on Android. After this work, GeckoViewSessionStore will be in use instead of SessionStateAggregator.

If there's anything else I can help related to session history on Android, please let me know. I am not clearing ni request for :owlish in case there's anything else worth mentioning related to Fission.

Comment 4

[Alexandra Borovova [:Sasha]]

Hi :kaya,

That's great news! I've tried to run the wpt tests, which are now disabled for Android with fission disabled, on top of the revision, and it seems to be working as we expect! So I'll block then this bug on bug1677190.

Thanks a lot for the context and your work :)