1677190 - (SHIP) Enable Session Restore and Session History In Parent in GeckoView

Status: RESOLVED FIXED

(GeckoView :: General, task, P2)

Description

[[ex-Mozilla] Agi Sferro | :agi]

The DOM team mentioned we should try to enable SHIP by default.

Comment 1

[Chris Peterson [:cpeterson]]

Tracking this bug for Android Fission milestone M2 (pass tests with Fission enabled)

Comment 3

[Anny Gakhokidze [:annyG]]

Linking this to the bug that peterv is working on (feel free to change the relationship between two bugs).

Comment 4

[Chris Peterson [:cpeterson]]

Assigning to Agi because he said he's going to work on this bug next.

Comment 5

[Chris Peterson [:cpeterson]]

Consider for 104. We won't be ready for 103.

Agi will fix up this bug's dependent bugs.

Comment 6

[Hsin-Yi Tsai (she/her)[:hsinyi]]

According to :afarre, this blocks bug 1736121 "SHIP everywhere". It's not possible to enable "SHIP everywhere" before this bug is done, because it would mean turning off session (re)store for android.

Comment 7

[Chris Peterson [:cpeterson]]

Moving Android Fission bugs to the new GeckoView::Sandboxing component.

Comment 8

[Cathy Lu [:calu]]

Attachment: Bug 1677190 - Session restore tab content

This adds the app api to allow restoreState() calls to restore tab content that has been saved in a GeckoSession.SessionState. This generally includes form data (data that has been entered into a text or checkbox form) and scroll (what position the page is scrolled to and includes the level of the zoom the page is at).

For now, this was manually tested by using geckoview_example. A restoreState() call was added to onSessionStateChange(), which gets called anytime the history or tab content gets updated. That will provide the current state the tab is in. I verified that by calling restoreState(), it reloads the tab exactly to the tab content it was set at, regardless of what new url was entered. I also manually verified by running about:debugging and placing breakpoints to verify the returned data from buildRestoreData() and restoreState matches the tab content.

The next steps will be getting ProgressDelegate junit tests to restore this data as well.

Comment 9

[Cathy Lu [:calu]]

Additional details on current testing issue documented here: https://docs.google.com/document/d/1SXgzCsqsXlZTBl9RJHpQXuXQo0ZVw22URIeFFoIey3o/edit?usp=sharing

Comment 10

[Chris Peterson [:cpeterson]]

Enhancements should have severity N/A.

Comment 11

[Kaya [:kaya]]

Attachment: WIP: Bug 1677190 - Enable SHIP for session state storing and restoring.

SHIP is enabled for Android to store and restore the state of the session. From now on the logic in SessionStateAggregator is replaced by the logic in SessionStoreParent for storing the state of the session. The restoring logic lies inside GeckoViewContentParent.

Comment 12

[Kaya [:kaya]]

Attachment: WIP: Bug 1677190 - Introduce SHIP on Android for session state storing and restoring. It is pref'ed off for now.

SHIP is enabled for Android to store and restore the state of the session. From now on the logic in SessionStateAggregator is replaced by the logic in SessionStoreParent for storing the state of the session. The restoring logic lies inside GeckoViewContentParent.

Comment 13

[Chris Peterson [:cpeterson]]

The Android team has not been keeping our P1 bug list up to date, so we're resetting all our P1 bugs to P2 to avoid signalling that we're actively working on bugs that we're not. The BMO documentation https://wiki.mozilla.org/BMO/UserGuide/BugFields#priority says P1 means "fix in the current release cycle" and P2 means "fix in the next release cycle or the following (nightly + 1 or nightly + 2)".

If you are actively working on this bug and expect to ship it in Fx 122 or 123, then please restore the priority back to P1.

Comment 14

[Kaya [:kaya]]

Attachment: Bug 1677190 - Introduce SessionStoreFunctions for GeckoView package and move the existing SessionStoreFunctions from toolkit to the browser package.

Comment 15

[Kaya [:kaya]]

Attachment: Bug 1677190 - Use runtime dispatcher on GeckoViewSessionStore and event listener on GeckoRuntime to handle tab state updates.

This change introduces a map in GeckoRuntime (for both SHIP and non-SHIP code) which holds weak references to GeckoSession objects created. This is done to be able to forward the received session state update in SHIP code from GeckoRuntime to GeckoSession.

Comment 16

[Kaya [:kaya]]

Attachment: Bug 1677190 - Move buildRestoreData to toolkit to use it on both Android and Desktop.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a87aa27f25e1
Introduce SessionStoreFunctions for GeckoView package and move the existing SessionStoreFunctions from toolkit to the browser package. r=geckoview-reviewers,farre,nika,owlish

Comment 18

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a87aa27f25e1

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9ae07cdf461
Move buildRestoreData to toolkit to use it on both Android and Desktop. r=geckoview-reviewers,sessionstore-reviewers,owlish,farre

Comment 20

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e9ae07cdf461

Comment 21

[Kaya [:kaya]]

Attachment: Bug 1677190 - Use shared code for updating the session state on Android when SHIP is enabled.

Comment 22

[Kaya [:kaya]]

Attachment: Bug 1677190 - Request tab state flush on SHIP on Android when GeckoSession is deactivated.

Depends on D210757

Comment 23

[Kaya [:kaya]]

Attachment: WIP: Bug 1677190 - Test moving runtime dispatcher's state update logic to embedder

Depends on D208502

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2fd6f1439789
Use shared code for updating the session state on Android when SHIP is enabled. r=geckoview-reviewers,sessionstore-reviewers,farre,owlish

Comment 25

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/2fd6f1439789

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e5e1a3a0dae
Request tab state flush on SHIP on Android when GeckoSession is deactivated. r=geckoview-reviewers,owlish

Comment 27

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/7e5e1a3a0dae

Comment 28

[Chris Peterson [:cpeterson]]

Resolving as fixed because SHIP is now enabled for 50% of Nightly 134 and Beta 133. 🚀

https://experimenter.services.mozilla.com/nimbus/android-ship-nightly-rollout/summary

https://experimenter.services.mozilla.com/nimbus/android-ship-beta-rollout/summary

Comment 29

[[:owlish] 🦉 PST]

As the remaining patches don't need to be merged, and the work is largely completed, closing