Fix clippy lint issues for geckodriver, webdriver, and mozbase rust modules
Categories
(Testing :: geckodriver, task, P3)
Tracking
(firefox122 fixed)
| Tracking | Status | |
|---|---|---|
| firefox122 | --- | fixed |
People
(Reporter: whimboo, Assigned: rzvncj, Mentored)
References
Details
(Whiteboard: [webdriver:m9][webdriver:external])
Attachments
(1 file)
|
Bug 1865315 - Fix clippy lint issues for geckodriver, webdriver, and mozbase rust modules. r?whimboo
48 bytes,
text/x-phabricator-request
|
Details | Review |
While checking the patch on bug 1731016 I noticed that cargo clippy mentions quite a few warnings that we want to get fixed for the following rust packages:
|
Assignee | |
Updated•6 months ago
|
|
|
Assignee | |
Comment 1•6 months ago
|
||
|
|
Assignee | |
Comment 2•6 months ago
|
||
|
|
Assignee | |
Comment 3•6 months ago
|
||
I've started a new try push, for reasons that are unclear to me the previous one failed to start properly.
|
Reporter | |
Updated•6 months ago
|
|
|
Reporter | |
Updated•6 months ago
|
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a325ddccae9b Fix clippy lint issues for geckodriver, webdriver, and mozbase rust modules. r=webdriver-reviewers,jgraham
|
||
Comment 5•6 months ago
|
||
| bugherder | ||
|
|
Reporter | |
Comment 6•6 months ago
|
||
Razvan, thanks a lot! If you have interest in something more challenging please let me know.
|
|
Assignee | |
Comment 7•6 months ago
|
||
(In reply to Henrik Skupin [:whimboo][⌚️UTC+1] from comment #6)
Razvan, thanks a lot! If you have interest in something more challenging please let me know.
Happy to help! Sure, we'll talk on Matrix - right now is a bit of a busy time for me, but I hope to be able to tackle more probably around January. Thanks!
|
|
Reporter | |
Comment 8•3 months ago
|
||
(In reply to Razvan Cojocaru from comment #7)
Happy to help! Sure, we'll talk on Matrix - right now is a bit of a busy time for me, but I hope to be able to tackle more probably around January.
Hello Razvan, if you find yourself with some extra time, please inform me and we can find something for you. Thanks!
|
|
Assignee | |
Comment 9•3 months ago
|
||
(In reply to Henrik Skupin [:whimboo][⌚️UTC+1] from comment #8)
(In reply to Razvan Cojocaru from comment #7)
Happy to help! Sure, we'll talk on Matrix - right now is a bit of a busy time for me, but I hope to be able to tackle more probably around January.
Hello Razvan, if you find yourself with some extra time, please inform me and we can find something for you. Thanks!
Hi, sorry for not getting back to you sooner. I've just done this and am now working on bug 1876941 with not a whole lot of extra time, but I'm certainly open to any suggestion you might have for future contributions, so please feel free to let me know here or on Matrix.
Thanks!
Description
•