1865563 - [css-properties-values-api] The computed context field should be removed from Cascade.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Zach Hoffman [:zrhoffman]]

As a prerequisite for calling Cascade::apply_prioritary_properties while the CustomPropertiesBuilder is borrowing the computed::Context, the computed context will need to be passed to the Cascade as an argument, rather than being a field of the Cascade struct.

Comment 1

[Zach Hoffman [:zrhoffman]]

Attachment: Bug 1865563 - Rustfmt servo/. r=zsun,fredw,#style

$ git ls-files servo/*.rs | xargs rustup run nightly rustfmt

Comment 2

[Zach Hoffman [:zrhoffman]]

Attachment: Bug 1865563 - [css-properties-values-api] Remove computed context field from Cascade. r=zsun,fredw,#style

This is necessary to call Cascade::apply_prioritary_properties while the
CustomPropertiesBuilder is borrowing the computed::Context.

Depends on D194020

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5e489011233
Rustfmt servo/. r=firefox-style-system-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/6ea1c084aef5
[css-properties-values-api] Remove computed context field from Cascade. r=firefox-style-system-reviewers,emilio

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c5e489011233
https://hg.mozilla.org/mozilla-central/rev/6ea1c084aef5