Closed Bug 1856522 Opened 9 months ago Closed 5 months ago

[css-properties-values-api] Apply font-* properties before calculating registered custom properties

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
124 Branch
Tracking Status
firefox124 --- fixed

People

(Reporter: zrhoffman, Assigned: zrhoffman)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file, 2 obsolete files)

Once dependency cycles between font-* properties and custom properties are resolved, font-* properties need to be applied before computing and substituting registered custom properties.

Summary: Apply font-* properties before calculating registered custom properties → [css-properties-values-api] Apply font-* properties before calculating registered custom properties
Blocks: 1856524
Assignee: nobody → zach
Status: NEW → ASSIGNED
Depends on: 1865563

This will let us call Cascade::apply_prioritary_properties while the
computed::Context is borrowed by the CustomPropertiesBuilder.

Depends on D194021

This ensures that registered custom properties containing font-relative
units are computed accurately.

Depends on D194022

Attachment #9364381 - Attachment description: Bug 1856522 - Make CustomPropertiesBuilder.context mutable. r=zsun,fredw,#style → Bug 1856522 - [css-properties-values-api] Make CustomPropertiesBuilder.context mutable. r=zsun,fredw,#style
Attachment #9364382 - Attachment description: Bug 1856522 - Apply prioritary properties before computing registered custom properties. r=zsun,fredw,#style → Bug 1856522 - [css-properties-values-api] Apply prioritary properties before computing registered custom properties. r=zsun,fredw,#style
Blocks: 1865655
Attachment #9364382 - Attachment is obsolete: true
Duplicate of this bug: 1865655

(Unassigning since D194023 is abandoned)

Assignee: zach → nobody
Status: ASSIGNED → NEW
Blocks: 1864818
Blocks: 1866917
Attachment #9364381 - Attachment is obsolete: true

Dependencies between custom properties and font-* properties are
resolved in bug 1855110, so these TODOs for bug 1856522 can be removed.

Assignee: nobody → zach
Status: NEW → ASSIGNED
Pushed by zach@zrhoffman.net:
https://hg.mozilla.org/integration/autoland/rev/8f7f77e2285c
Remove unneeded TODOs for bug 1856522 r=firefox-style-system-reviewers,emilio
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: