1856522 - [css-properties-values-api] Apply font-* properties before calculating registered custom properties

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Tess Hoffman [:zrhoffman]]

Once dependency cycles between font-* properties and custom properties are resolved, font-* properties need to be applied before computing and substituting registered custom properties.

Comment 1

[Tess Hoffman [:zrhoffman]]

Attachment: Bug 1856522 - [css-properties-values-api] Make CustomPropertiesBuilder.context mutable. r=zsun,fredw,#style

This will let us call Cascade::apply_prioritary_properties while the
computed::Context is borrowed by the CustomPropertiesBuilder.

Depends on D194021

Comment 2

[Tess Hoffman [:zrhoffman]]

Attachment: Bug 1856522 - [css-properties-values-api] Apply prioritary properties before computing registered custom properties. r=zsun,fredw,#style

This ensures that registered custom properties containing font-relative
units are computed accurately.

Depends on D194022

Comment 4

[Tess Hoffman [:zrhoffman]]

(Unassigning since D194023 is abandoned)

Comment 5

[Tess Hoffman [:zrhoffman]]

Bug 1856522 could be closed as a duplicate of bug 1855110, but because some TODOs still reference bug 1856522, let's close bug 1856522 once those TODOs are removed:

• https://searchfox.org/mozilla-central/rev/c130c69b7b863d5e28ab9524b65c27c7a9507c48/servo/components/style/custom_properties.rs#988-990
• https://searchfox.org/mozilla-central/rev/c130c69b7b863d5e28ab9524b65c27c7a9507c48/servo/components/style/properties_and_values/value.rs#208-209

Comment 6

[Tess Hoffman [:zrhoffman]]

Attachment: Bug 1856522 - Remove unneeded TODOs for bug 1856522 r=dshin,#style

Dependencies between custom properties and font-* properties are
resolved in bug 1855110, so these TODOs for bug 1856522 can be removed.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f7f77e2285c
Remove unneeded TODOs for bug 1856522 r=firefox-style-system-reviewers,emilio

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/8f7f77e2285c