1865822 - The Review Checker will show a horizontal scrollbar for an unanalyzed product

Status: VERIFIED FIXED

(Firefox :: Shopping, defect)

Description

[Rares Doghi, Desktop QA]

Attachment: 2023-11-21_15h04_44.png

Found in

• Nightly 122.0a1 (2023-11-21)

Affected versions

• Nightly 122.0a1 (2023-11-21)
• Beta 121

Affected platforms

• ALL

Preconditions:
browser.shopping.experience2023.enabled - true
browser.shopping.experience2023.optedIn = 0

Steps to reproduce

1. Reach https://www.walmart.com/ip/Gain-Ultra-Dish-Washing-Liquid-Dish-Soap-Honey-Berry-Hula-Scent-90-fl-oz/1683982875
2. Resize the Review checker sidebar to a smaller size.

Expected result

• The horizontal Scrollbar should not be displayed.

Actual result

• A horizontal scrollbar is displayed when the unanalyzed card is displayed.

Regression range
Not Applicable

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:rdoghi, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[kpatenio]

From quick testing, I'm pretty sure Bug 1865808 is the culprit. The unanalyzed product card image spilling out will cause horizontal overflow on the sidebar, hence why there is the horizontal scrollbar. I don't know what's a good size for the image though with the smallest sidebar width, so we'll need UX input for that.

Comment 3

[kpatenio]

Attachment: Bug 1865822 - adjust unanalyzed product card image for smaller sidebar width. r=#shopping-reviewers!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d55e68bd862
adjust unanalyzed product card image for smaller sidebar width. r=shopping-reviewers,Gijs

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/6d55e68bd862

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:kpatenio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox121 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly build 122.0a1 (2023-11-28) , It looks GREAT !

Comment 8

[Rares Doghi, Desktop QA]

Updating the main status flag.