1865840 - Users should be able to report dictionaries from Add-ons Manager when the new report abuse AMO form is enabled

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Alex Cornestean]

Attachment: 2023-11-21_16h01_33.png

Affected versions:
Nightly - 122.0a1/20231121045833
Beta - 121.0b1/20231120154937

Description:
Currently, there is no method to report dictionaries from Add-ons Manager as the “Report” option from the three-dot menu on the add-on card is not present as in the case of other add-ons.
Dictionaries can be reported, on the other hand, from AMO. As such, user should be able to report this type of add-on from Add-ons Manager as well.

Preconditions:

1. Go to about:config and enable the new abuse report form by setting the extensions.abuseReport.amoFormEnabled pref to true
2. Install a dictionary from AMO

Steps to reproduce:

1. Access about:addons and navigate to the “Dictionaries” tab
2. Click the three-dot menu on the dictionary card
3. Observe there is no “Report” option listed among the menu entries

Expected:
Users should be able to report dictionaries from Add-ons Manager.
This comprises:

• updating the list of SUPPORTED_ADDON_TYPES at https://searchfox.org/mozilla-central/rev/5134f3f1c7794fcff1bde59dc7b4ae65cc460919/toolkit/mozapps/extensions/AbuseReporter.sys.mjs#22 to include dictionaries
• adding a “Report” option to the three-dot menu on the add-on card in Add-ons Manager
• adding the option to report the add-on when removing it

Actual:
Dictionaries cannot be reported from Add-ons Manager.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1865840 - AbuseReport button should be shown for dictionaries when the AMO port is enabled. r?willdurand!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1075d90c25ab
AbuseReport button should be shown for dictionaries when the AMO port is enabled. r=willdurand

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/1075d90c25ab

Comment 4

[Alex Cornestean]

Verified as Fixed. Tested on the latest Nightly (122.0a1/20231123214337) under Windows 10 x64 and Ubuntu 22.04 LTS.

Tested using https://addons-dev.allizom.org/en-US/firefox/addon/checking-dictionary-test1/ with extensions.abuseReport.amoFormURL set to -dev (https://addons-dev.allizom.org/%LOCALE%/%APP%/feedback/addon/%addonID%/).

The dictionary was reported from all the available locations in add-ons manager i.e. via the three-dot menu on the add-on card and via the three-dot menu from the details view of the add-on, using the “Report” option which is now available in the three-dot menu. There is no reporting option on add-on removal.

The abuse report form URL is https://addons-dev.allizom.org/en-US/firefox/feedback/addon/[e-mail]/ which matches the URL format set by the pref mentioned above.

The request payload also contains the correct information upon submitting the report:

{
"addon": "[e-mail]",
"addon_version": "3.2.20120321.1webext",
"location": "addon",
"message": "test",
"reason": "feedback_spam",
"reporter_email": "dhdh",
"reporter_name": "dryh"
}

Considering the above, the issue is Fixed.

Comment 5

[Alex Cornestean]

Attachment: 2023-11-24_10h04_53.png

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:rpl, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox121 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 9364980 [details]
Bug 1865840 - AbuseReport button should be shown for dictionaries when the AMO port is enabled. r?willdurand!

Beta/Release Uplift Approval Request

• User impact if declined: Users would not be able to report abuses for installed dictionaries directly from the about:addons page, which is part of changes we are applying to Firefox's addons abuse reporting in Firefox 121 as part of the DSA (EU Digital Services Act) requirements.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: same STRs used to verify the issue in Nightly.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The changes applied in this patch are small, only impacting to the addons abuse report implementation, and they covered by automated steps + explicitly QA verified on Nightly.
• String changes made/needed:
• Is Android affected?: No

Comment 8

[Donal Meehan [:dmeehan]]

Comment on attachment 9364980 [details]
Bug 1865840 - AbuseReport button should be shown for dictionaries when the AMO port is enabled. r?willdurand!

Approved for 121.0b4

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/5ada5afce14c

Comment 10

[Alex Cornestean]

Verified as Fixed. Tested on the latest Beta (121.0b4/20231127091758) under Windows 10 x64 and macOS 11.3.1.

Tested using https://addons-dev.allizom.org/en-US/firefox/addon/checking-dictionary-test1/ with extensions.abuseReport.amoFormURL set to -dev (https://addons-dev.allizom.org/%LOCALE%/%APP%/feedback/addon/%addonID%/).

The dictionary was reported from all the available locations in add-ons manager i.e. via the three-dot menu on the add-on card and via the three-dot menu from the details view of the add-on, using the “Report” option which is now available in the three-dot menu. There is no reporting option on add-on removal.

The abuse report form URL is https://addons-dev.allizom.org/en-US/firefox/feedback/addon/[e-mail]/ which matches the URL format set by the pref mentioned above.

The request payload also contains the correct information upon submitting the report:

{
"addon": "[e-mail]",
"addon_version": "3.2.20120321.1webext",
"location": "addon",
"message": "test",
"reason": "feedback_spam",
"reporter_email": "asfd",
"reporter_name": "asdf"
}

Considering the above, the issue is Fixed on the latest Beta.