1863307 - Enable AMO hosted abuse report form on all channels for Firefox Desktop builds

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, task, P1)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

As a separate followup to Bug 1859791, we will be setting the new about:config pref "extensions.abuseReport.amoFormEnabled" to true by default on all channels for Firefox Desktop builds.

The AMO hosted form is still being completed, but the goal is to be setting "extensions.abuseReport.amoFormEnabled" to true by default before the end of the Firefox 121 Nightly or Beta cycle.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1863307 - Enable AMO hosted abuse report form on all channels for Firefox Desktop builds. r?willdurand!

Depends on D192005

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8126bc040321
Enable AMO hosted abuse report form on all channels for Firefox Desktop builds. r=willdurand

Comment 3

[Cristian Tuns]

Backed out for causing bc failures in browser_ext_browserAction_contextMenu.js

• Backout link
• Push with failures
• Failure Log
• Failure line: PROCESS-CRASH | Attempting to connect to non-local address! opener is [resource://gre/modules/RemoteWebNavigation.sys.mjs:156:35], uri is [https://addons.mozilla.org/en-US/firefox/feedback/addon/[e-mail]/] [@ mozilla::net::nsHttpChannel::OnStartRequest] | browser/components/extensions/test/browser/browser_ext_browserAction_contextMenu.js

And also this: https://treeherder.mozilla.org/logviewer?job_id=437591865&repo=autoland

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

Working on it, that test also need to be updated to account for the amo form url to be opened when the pref is true (and the pref that includes the url to the form to be set to be pointed to a local address, so that we would not hit a non-local address failure while running the test).

Apologies for missing to notice this additional test before the push to autoland.

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a861d9d1b4a
Backed out changeset 8126bc040321 for causing crashes in /browser_ext_browserAction_contextMenu.js CLOSED TREE

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1863307 - Adapt mochitest-browser tests covering the report context menu item to run with amoFormEnabled true/false. r?willdurand!

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

Push to try with both the attached patches applied (the one already attached and the new parent one added in comment 6 to adapt those two additional mochitest-browser tests):

• https://treeherder.mozilla.org/jobs?repo=try&revision=8f9b0d15e6222716970a95217e3f29b4983d7431

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d16060ff7ea
Adapt mochitest-browser tests covering the report context menu item to run with amoFormEnabled true/false. r=willdurand
https://hg.mozilla.org/integration/autoland/rev/2ffce169bf66
Enable AMO hosted abuse report form on all channels for Firefox Desktop builds. r=willdurand

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/6d16060ff7ea
https://hg.mozilla.org/mozilla-central/rev/2ffce169bf66

Comment 10

[Alex Cornestean]

Verified as Fixed. Tested on the latest Nightly (122.0a1/20231128094907) under Windows 10 x64, Ubuntu 22.04 LTS and macOS 11.3.1.

The new abuse report AMO form is now enabled by default as a result of the extensions.abuseReport.amoFormEnabled pref being set to true from the start.

Tested using extensions.abuseReport.amoFormURL set to -DEV (https://addons-dev.allizom.org/%LOCALE%/%APP%/feedback/addon/%addonID%/).

Reporting add-ons from all available locations in Firefox (three-dot menu on add-on card, three-dot menu from the add-on detail view, extensions panel context menu, extensions panel gear menu, context menu when pinned to toolbar and pageAction) and reporting installed add-ons from their AMO detail page will now open the new report abuse AMO form.

The abuse report form URL correctly matches the format set through extensions.abuseReport.amoFormURL i.e. https://addons.mozilla.org/<locale>/<application>/feedback/addon/<guid>/

The request payload also contains the correct information upon submitting the report. For example:

{
"addon": "[e-mail]",
"addon_version": "3.2.20120321.1webext",
"location": "addon",
"message": "test",
"reason": "feedback_spam",
"reporter_email": "asfd",
"reporter_name": "asdf"
}

Considering the above, the issue is Fixed.

Comment 11

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 9362109 [details]
Bug 1863307 - Enable AMO hosted abuse report form on all channels for Firefox Desktop builds. r?willdurand!

Beta/Release Uplift Approval Request

• User impact if declined: The abuse report form available to the users in Firefox 121 would still be the same one integrated in older Firefox versions, which is not going to be compliant to DSA (EU Digital Services Act) requirements, while the one hosted on addos.mozilla.org and enabled by default by this patch is going to be DSA compliant.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Same as the QA test plan used to verify this feature on Nightly.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This feature has been explicitly QA verified on nightly and beta, and it is covered by automated tests. These two patches are only including the final pref flipping and tweaks to the automated tests (to cover the expected behavior of the abuse reporting feature with amoFormEnabled pref set to both true and false).
• String changes made/needed:
• Is Android affected?: No

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9362109 [details]
Bug 1863307 - Enable AMO hosted abuse report form on all channels for Firefox Desktop builds. r?willdurand!

Approved for 121.0b5.

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/a87231f2d154
https://hg.mozilla.org/releases/mozilla-beta/rev/1a33f278d5b3

Comment 14

[Alex Cornestean]

Verified as Fixed. Tested on Beta Developer Edition 121.0b6 (121.0b6/20231201091738) and on the latest Beta Developer Edition (121.0b7/20231204092159) under Windows 10 x64, Ubuntu 22.04 LTS and macOS 11.3.1.

Beta Developer Edition has been used due the need to change several prefs to be able to install add-ons from -DEV.

The new abuse report AMO form is now enabled by default as a result of the extensions.abuseReport.amoFormEnabled pref being set to true from the start.

Tested using extensions.abuseReport.amoFormURL set to -DEV (https://addons-dev.allizom.org/%LOCALE%/%APP%/feedback/addon/%addonID%/).

Reporting add-ons from all available locations in Firefox (three-dot menu on add-on card, three-dot menu from the add-on detail view, extensions panel context menu, extensions panel gear menu, context menu when pinned to toolbar and pageAction) and reporting installed add-ons from their AMO detail page will now open the new report abuse AMO form.

The abuse report form URL correctly matches the format set through extensions.abuseReport.amoFormURL i.e. https://addons.mozilla.org/<locale>/<application>/feedback/addon/<guid>/

The request payload also contains the correct information upon submitting the report. For example:

{
"addon": "[e-mail]",
"addon_version": "3.2.20120321.1webext",
"location": "addon",
"message": "test",
"reason": "feedback_spam",
"reporter_email": "asfd",
"reporter_name": "asdf"
}

Considering the above, the issue is Fixed on Beta as well.