Closed Bug 1865896 Opened 10 months ago Closed 2 months ago

Add a ToString function to DefineEnum

Categories

(Core :: MFBT, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
130 Branch
Tracking Status
firefox130 --- fixed

People

(Reporter: chunmin, Assigned: chunmin)

References

Details

Attachments

(61 files, 4 obsolete files)

48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review

There are many places in media that need a function to convert an enum item to string, e.g.,

I believe there are lots of these functions in gecko. It's better to automatically generate them instead of adding them every time we need.

Depends on D193952

Depends on D194260

Assignee: nobody → cchang

Depends on D193948

Attachment #9364792 - Attachment description: WIP: Bug 1865896 - Replace ToString in FF{VPX, mpeg}RuntimeLinker → WIP: Bug 1865896 - Apply ToString in FF{VPX, mpeg}RuntimeLinker

This patch defines MediaData::Type enum via MOZ_DEFINE_ENUM so the enum
comes with a to-string helper, which follows Gecko's convension to
convert a type(enum) to a a string.

Depends on D194260

This patch define SeekTarget::Type enum by MOZ_DEFINE_ENUM so it comes
with a to-string helper for free. Note that this patch also make ::Type
become an enum class.

Depends on D194549

Depends on D194550

Comment on attachment 9364872 [details]
WIP: Bug 1865896 - Implement FFmpegVideoEncoder::GetCodecId

Revision D194318 was moved to bug 1860899. Setting attachment 9364872 [details] to obsolete.

Attachment #9364872 - Attachment is obsolete: true
Severity: -- → S4
Priority: -- → P3

Depends on D194550

Depends on D194551

Depends on D204449

Depends on D194261

Depends on D204451

Attachment #9364792 - Attachment description: WIP: Bug 1865896 - Apply ToString in FF{VPX, mpeg}RuntimeLinker → WIP: Bug 1865896 - Apply ToString in FFmpegLibWrapper::LinkResult

Depends on D204563

Note that this patch eliminates the assigned value for Requirement's
enum item since they are unused.

Depends on D204817

Note that this patch eliminates the assigned value for SessionType's
enum item since they are unused.

Depends on D204960

The dom::GetEnumString has the enum string in the first place so it
can replace the ToMediaKeyStatusStr entirely.

Depends on D204962

Comment on attachment 9391836 [details]
WIP: Bug 1865896 - Replace ToMediaKeyStatusStr by GetEnumString

Revision D204963 was moved to bug 1886057. Setting attachment 9391836 [details] to obsolete.

Attachment #9391836 - Attachment is obsolete: true
See Also: → 1886057

Note that this patch also eliminates the assigned values for
cdm::SessionType's enum items. It's okay since they are unused.

Depends on D194551

Depends on D204962

Note that this patch also eliminates the assigned values for
TextTrackReadyState's enum items. It's okay since they are unused.

Depends on D205242

Depends on D194260

Depends on D205243

Depends on D209280

Depends on D209282

Depends on D209452

Depends on D209453

Depends on D209570

Depends on D209571

Note that this patch changes the MediaPlaybackState enum string from X
to eX (e.g., started -> eStarted), but no functional change involves.

Depends on D210117

Note that this patch changes the MediaAudibleState enum string from X to
eX (e.g., inaudible -> eInaudible), but no functional change involves.

Depends on D210118

Note that this patch changes the converted enum string from X to eX in
the logs.

Depends on D213360

Note this patch changes the converted enum string from X to eX in the
logs, and free the crash caused by passing AudibleState::eMaybeAudible
to ToAudibilityStr

Depends on D213363

Note this patch changes the converted enum string from X to eX in the
logs.

Depends on D213364

Attachment #9401244 - Attachment description: WIP: Bug 1865896 - Sort include headers in ContentMediaController.cpp per coding style → WIP: Bug 1865896 - Sort include headers in MediaStatusManager.cpp per coding style

Depends on D216477

Depends on D216478

Depends on D216480

Depends on D216480

Depends on D216588

Depends on D216590

Depends on D216592

Note that this patch changes the enum mapping string from X to eX.

Depends on D216594

Depends on D216595

Attachment #9364791 - Attachment description: WIP: Bug 1865896 - Add ToString function to DefineEnum → Bug 1865896 - Add ToString function to DefineEnum
Attachment #9399844 - Attachment description: WIP: Bug 1865896 - Alphabetize include headers in MediaData.h → Bug 1865896 - Alphabetize include headers in MediaData.h
Attachment #9399904 - Attachment description: WIP: Bug 1865896 - Sort include headers in MediaDecoderStateMachine.cpp per coding style → Bug 1865896 - Sort include headers in MediaDecoderStateMachine.cpp per coding style
Attachment #9365238 - Attachment description: WIP: Bug 1865896 - Apply DefineEnum to MediaData::Type → Bug 1865896 - Apply DefineEnum to MediaData::Type
Attachment #9365239 - Attachment description: WIP: Bug 1865896 - Apply DefineEnum to SeekTarget::Type → Bug 1865896 - Apply DefineEnum to SeekTarget::Type
Attachment #9390919 - Attachment description: WIP: Bug 1865896 - Alphabetize headers in ChromiumCDMParent.cpp → Bug 1865896 - Alphabetize headers in ChromiumCDMParent.cpp
Attachment #9365240 - Attachment description: WIP: Bug 1865896 - Apply DefineEnum to cdm::Status → Bug 1865896 - Apply DefineEnum to cdm::Status
Attachment #9392346 - Attachment description: WIP: Bug 1865896 - Apply DefineEnum to cdm::SessionType → Bug 1865896 - Apply DefineEnum to cdm::SessionType
Attachment #9390920 - Attachment description: WIP: Bug 1865896 - Alphabetize headers in FFmpegRuntimeLinker.cpp → Bug 1865896 - Alphabetize headers in FFmpegRuntimeLinker.cpp
Attachment #9390921 - Attachment description: WIP: Bug 1865896 - Reorder headers in FFVPXRuntimeLinker.cpp by coding style → Bug 1865896 - Reorder headers in FFVPXRuntimeLinker.cpp by coding style
Attachment #9364792 - Attachment description: WIP: Bug 1865896 - Apply ToString in FFmpegLibWrapper::LinkResult → Bug 1865896 - Apply ToString in FFmpegLibWrapper::LinkResult
Attachment #9390922 - Attachment description: WIP: Bug 1865896 - Alphabetize headers in MFCDMParent.cpp → Bug 1865896 - Alphabetize headers in MFCDMParent.cpp
Attachment #9390923 - Attachment description: WIP: Bug 1865896 - Apply DefineEnum to CryptoScheme → Bug 1865896 - Apply DefineEnum to CryptoScheme
Attachment #9391152 - Attachment description: WIP: Bug 1865896 - Reorder headers in MediaDecoder.cpp by coding style → Bug 1865896 - Reorder headers in MediaDecoder.cpp by coding style
Attachment #9391153 - Attachment description: WIP: Bug 1865896 - Apply DefineEnum to MediaDecoder::PlayState → Bug 1865896 - Apply DefineEnum to MediaDecoder::PlayState
Attachment #9391546 - Attachment description: WIP: Bug 1865896 - Apply DefineEnum to MediaDecoder::OutputCaptureState → Bug 1865896 - Apply DefineEnum to MediaDecoder::OutputCaptureState
Attachment #9391547 - Attachment description: WIP: Bug 1865896 - Reorder headers in MediaDecoderOwner.h by coding style → Bug 1865896 - Reorder headers in MediaDecoderOwner.h by coding style
Attachment #9391548 - Attachment description: WIP: Bug 1865896 - Apply DefineEnum to MediaDecoderOwner::NextFrameStatus → Bug 1865896 - Apply DefineEnum to MediaDecoderOwner::NextFrameStatus
Attachment #9391833 - Attachment description: WIP: Bug 1865896 - Apply DefineEnum to KeySystemConfig::Requirement → Bug 1865896 - Apply DefineEnum to KeySystemConfig::Requirement
Attachment #9391834 - Attachment description: WIP: Bug 1865896 - Apply DefineEnum to KeySystemConfig::SessionType → Bug 1865896 - Apply DefineEnum to KeySystemConfig::SessionType
Attachment #9391835 - Attachment description: WIP: Bug 1865896 - Replace AppendASCII(nsPrintfCString) by AppendPrintf → Bug 1865896 - Replace AppendASCII(nsPrintfCString) by AppendPrintf
Attachment #9392347 - Attachment description: WIP: Bug 1865896 - Recorder headers in TextTrack.* by coding style → Bug 1865896 - Recorder headers in TextTrack.* by coding style
Attachment #9392348 - Attachment description: WIP: Bug 1865896 - Apply DefineEnum to TextTrackReadyState → Bug 1865896 - Apply DefineEnum to TextTrackReadyState
Attachment #9399845 - Attachment description: WIP: Bug 1865896 - Alphabetize include headers in AppleVTDecoder.* → Bug 1865896 - Alphabetize include headers in AppleVTDecoder.*
Attachment #9399846 - Attachment description: WIP: Bug 1865896 - Apply DefineEnum to AppleVTDecoder::StreamType → Bug 1865896 - Apply DefineEnum to AppleVTDecoder::StreamType
Attachment #9399847 - Attachment description: WIP: Bug 1865896 - Alphabetize include headers in WMFDecoderModule.cpp → Bug 1865896 - Alphabetize include headers in WMFDecoderModule.cpp
Attachment #9399848 - Attachment description: WIP: Bug 1865896 - Apply DefineEnum to WMFStreamType → Bug 1865896 - Apply DefineEnum to WMFStreamType
Attachment #9399905 - Attachment description: WIP: Bug 1865896 - Alphabetize include headers in SourceBufferAttributes.h → Bug 1865896 - Alphabetize include headers in SourceBufferAttributes.h
Attachment #9399906 - Attachment description: WIP: Bug 1865896 - Sort include headers in TrackBuffersManager.cpp per coding style → Bug 1865896 - Sort include headers in TrackBuffersManager.cpp per coding style
Attachment #9399907 - Attachment description: WIP: Bug 1865896 - Apply DefineEnum to SourceBufferAttributes::AppendState → Bug 1865896 - Apply DefineEnum to SourceBufferAttributes::AppendState
Attachment #9400085 - Attachment description: WIP: Bug 1865896 - Alphabetize include headers in AudioEventTimeline.h → Bug 1865896 - Alphabetize include headers in AudioEventTimeline.h
Attachment #9400086 - Attachment description: WIP: Bug 1865896 - Sort include headers in AudioParam.cpp per coding style → Bug 1865896 - Sort include headers in AudioParam.cpp per coding style
Attachment #9400087 - Attachment description: WIP: Bug 1865896 - Apply DefineEnum to AudioTimelineEvent::Type → Bug 1865896 - Apply DefineEnum to AudioTimelineEvent::Type
Attachment #9400297 - Attachment description: WIP: Bug 1865896 - Apply DefineEnum to DecoderAgent::State → Bug 1865896 - Apply DefineEnum to DecoderAgent::State
Attachment #9400298 - Attachment description: WIP: Bug 1865896 - Alphabetize include headers in EncoderAgent.h → Bug 1865896 - Alphabetize include headers in EncoderAgent.h
Attachment #9400299 - Attachment description: WIP: Bug 1865896 - Apply DefineEnum to EncoderAgent::State → Bug 1865896 - Apply DefineEnum to EncoderAgent::State
Attachment #9401240 - Attachment description: WIP: Bug 1865896 - Alphabetize include headers in MediaPlaybackStatus.h → Bug 1865896 - Alphabetize include headers in MediaPlaybackStatus.h
Attachment #9401241 - Attachment description: WIP: Bug 1865896 - Alphabetize include headers in MediaControlUtils.h → Bug 1865896 - Alphabetize include headers in MediaControlUtils.h
Attachment #9401242 - Attachment description: WIP: Bug 1865896 - Sort include headers in HTMLMediaElement.cpp per coding style → Bug 1865896 - Sort include headers in HTMLMediaElement.cpp per coding style
Attachment #9401243 - Attachment description: WIP: Bug 1865896 - Sort include headers in ContentMediaController.cpp per coding style → Bug 1865896 - Sort include headers in ContentMediaController.cpp per coding style
Attachment #9401244 - Attachment description: WIP: Bug 1865896 - Sort include headers in MediaStatusManager.cpp per coding style → Bug 1865896 - Sort include headers in MediaStatusManager.cpp per coding style
Attachment #9401245 - Attachment description: WIP: Bug 1865896 - Apply DefineEnum to MediaPlaybackState → Bug 1865896 - Apply DefineEnum to MediaPlaybackState
Attachment #9401246 - Attachment description: WIP: Bug 1865896 - Apply DefineEnum to MediaAudibleState → Bug 1865896 - Apply DefineEnum to MediaAudibleState
Attachment #9406875 - Attachment description: WIP: Bug 1865896 - Alphabetize include headers in TelemetryProbesReporter.* → Bug 1865896 - Alphabetize include headers in TelemetryProbesReporter.*
Attachment #9406876 - Attachment description: WIP: Bug 1865896 - Apply DefineEnum to Visibility → Bug 1865896 - Apply DefineEnum to Visibility
Attachment #9406877 - Attachment description: WIP: Bug 1865896 - Sort include headers in AudioChannelService.* per coding style → Bug 1865896 - Sort include headers in AudioChannelService.* per coding style
Attachment #9406878 - Attachment description: WIP: Bug 1865896 - Sort include headers in AudioChannelAgent.cpp per coding style → Bug 1865896 - Sort include headers in AudioChannelAgent.cpp per coding style
Attachment #9406879 - Attachment description: WIP: Bug 1865896 - Apply DefineEnum to AudioChannelService::AudibleState → Bug 1865896 - Apply DefineEnum to AudioChannelService::AudibleState
Attachment #9407053 - Attachment description: WIP: Bug 1865896 - Apply DefineEnum to AudioChannelService::AudibleChangedReasons → Bug 1865896 - Apply DefineEnum to AudioChannelService::AudibleChangedReasons
Attachment #9412605 - Attachment description: WIP: Bug 1865896 - Alphabetize include headers in PerformanceRecorder.h → Bug 1865896 - Alphabetize include headers in PerformanceRecorder.h
Attachment #9412606 - Attachment description: WIP: Bug 1865896 - Apply DefineEnum to TrackingId::Source → Bug 1865896 - Apply DefineEnum to TrackingId::Source
Attachment #9412608 - Attachment description: WIP: Bug 1865896 - Apply DefineEnum to MediaStage → Bug 1865896 - Apply DefineEnum to MediaStage
Attachment #9412822 - Attachment description: WIP: Bug 1865896 - Apply DefineEnum to DecodeStage::ImageFormat → Bug 1865896 - Apply DefineEnum to DecodeStage::ImageFormat
Attachment #9412823 - Attachment description: WIP: Bug 1865896 - Apply DefineEnum to CaptureStage::ImageType → Bug 1865896 - Apply DefineEnum to CaptureStage::ImageType
Attachment #9412609 - Attachment description: WIP: Bug 1865896 - Remove unused ToString functions in SdpPref → Bug 1865896 - Remove unused ToString functions in SdpPref
Attachment #9412824 - Attachment description: WIP: Bug 1865896 - Sort include headers in VideoEngine.* per coding style → Bug 1865896 - Sort include headers in VideoEngine.* per coding style
Attachment #9412825 - Attachment description: WIP: Bug 1865896 - Apply DefineEnum to CaptureDeviceType → Bug 1865896 - Apply DefineEnum to CaptureDeviceType
Attachment #9412826 - Attachment description: WIP: Bug 1865896 - Sort include headers in mediapacket.* per coding style → Bug 1865896 - Sort include headers in mediapacket.* per coding style
Attachment #9412827 - Attachment description: WIP: Bug 1865896 - Apply DefineEnum to MediaPacket::Type → Bug 1865896 - Apply DefineEnum to MediaPacket::Type
Attachment #9412828 - Attachment description: WIP: Bug 1865896 - Alphabetize include headers in GVAutoplayPermissionRequest.cpp → Bug 1865896 - Alphabetize include headers in GVAutoplayPermissionRequest.cpp
Attachment #9412829 - Attachment description: WIP: Bug 1865896 - Apply DefineEnum to GVAutoplayRequestType → Bug 1865896 - Apply DefineEnum to GVAutoplayRequestType
Attachment #9412830 - Attachment description: WIP: Bug 1865896 - Apply DefineEnum to GVAutoplayRequestStatus → Bug 1865896 - Apply DefineEnum to GVAutoplayRequestStatus
Attachment #9390921 - Attachment is obsolete: true

Depends on D216591

Attachment #9364792 - Attachment description: Bug 1865896 - Apply ToString in FFmpegLibWrapper::LinkResult → Bug 1865896 - Apply DefineEnum to FFmpegLibWrapper::LinkResult
Attachment #9392346 - Attachment is obsolete: true

Lando has a timeout error when loading this stack with 60+ patches. I am going to split the stack and land them separately.

Keywords: leave-open
Pushed by cchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b052be9da8d3
Add ToString function to DefineEnum r=padenot
https://hg.mozilla.org/integration/autoland/rev/f20de63c3f73
Alphabetize include headers in MediaData.h r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/9246d72fac77
Sort include headers in MediaDecoderStateMachine.cpp per coding style r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/933cc7a09e9b
Apply DefineEnum to MediaData::Type r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/06cfc498604d
Apply DefineEnum to SeekTarget::Type r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/5dd35cd31415
Alphabetize headers in ChromiumCDMParent.cpp r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/b39ef4049930
Apply DefineEnum to cdm::Status r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/4d839021ae59
Alphabetize headers in FFmpegRuntimeLinker.cpp r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/2a15a56f334c
Apply DefineEnum to FFmpegLibWrapper::LinkResult r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/d6c0baf01efe
Alphabetize headers in MFCDMParent.cpp r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/054f466d710b
Apply DefineEnum to CryptoScheme r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/81f6be951b3b
Reorder headers in MediaDecoder.cpp by coding style r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/1c509c49a157
Apply DefineEnum to MediaDecoder::PlayState r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/33008692eabf
Apply DefineEnum to MediaDecoder::OutputCaptureState r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/4bac58f3bae1
Reorder headers in MediaDecoderOwner.h by coding style r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/3bad3fe11b32
Apply DefineEnum to MediaDecoderOwner::NextFrameStatus r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/56af71493ae2
Apply DefineEnum to KeySystemConfig::Requirement r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/98ad3db6a2e2
Apply DefineEnum to KeySystemConfig::SessionType r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/c8e46826e030
Replace AppendASCII(nsPrintfCString) by AppendPrintf r=media-playback-reviewers,padenot
Pushed by cchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6fbdb064a782
Recorder headers in TextTrack.* by coding style r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/4301a3864179
Apply DefineEnum to TextTrackReadyState r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/ff0cbcf2168b
Alphabetize include headers in AppleVTDecoder.* r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/2f3ec4eaecd8
Apply DefineEnum to AppleVTDecoder::StreamType r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/a6ff1bea97c3
Alphabetize include headers in WMFDecoderModule.cpp r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/b45bb953500a
Apply DefineEnum to WMFStreamType r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/1a47e108fb9a
Alphabetize include headers in SourceBufferAttributes.h r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/7c5c872917c7
Sort include headers in TrackBuffersManager.cpp per coding style r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/320420a212d9
Apply DefineEnum to SourceBufferAttributes::AppendState r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/b643f25531ed
Alphabetize include headers in AudioEventTimeline.h r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/b71c89fc4c6b
Sort include headers in AudioParam.cpp per coding style r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/3beecf2e10ad
Apply DefineEnum to AudioTimelineEvent::Type r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/9faa74aa9ed9
Apply DefineEnum to DecoderAgent::State r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/b52309352b73
Alphabetize include headers in EncoderAgent.h r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/905f79331006
Apply DefineEnum to EncoderAgent::State r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/c1af69b8c65f
Alphabetize include headers in MediaPlaybackStatus.h r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/5e0920babf30
Alphabetize include headers in MediaControlUtils.h r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/5d4836ac9d64
Sort include headers in HTMLMediaElement.cpp per coding style r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/19d340c5ac08
Sort include headers in ContentMediaController.cpp per coding style r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/7ef644b68110
Sort include headers in MediaStatusManager.cpp per coding style r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/56bf01672a8c
Apply DefineEnum to MediaPlaybackState r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/434101dbcc3a
Apply DefineEnum to MediaAudibleState r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/ef00a408552d
Alphabetize include headers in TelemetryProbesReporter.* r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/5bdce5274855
Apply DefineEnum to Visibility r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/76a1dcd13a2c
Sort include headers in AudioChannelService.* per coding style r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/fb7ac256135d
Sort include headers in AudioChannelAgent.cpp per coding style r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/3d91efc04d74
Apply DefineEnum to AudioChannelService::AudibleState r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/c5c9df23c137
Apply DefineEnum to AudioChannelService::AudibleChangedReasons r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/bd54a48e2007
Alphabetize include headers in PerformanceRecorder.h r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/2f8d92f22d74
Apply DefineEnum to TrackingId::Source r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/624e20d6125f
Apply DefineEnum to MediaStage r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/9f1e64978cf8
Apply DefineEnum to DecodeStage::ImageFormat r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/fc23dcc98a1b
Apply DefineEnum to CaptureStage::ImageType r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/e271614ee785
Remove unused ToString functions in SdpPref r=padenot
https://hg.mozilla.org/integration/autoland/rev/27d5b12dc9c9
Sort include headers in VideoEngine.* per coding style r=webrtc-reviewers,bwc
https://hg.mozilla.org/integration/autoland/rev/8500a9b182dd
Apply DefineEnum to CaptureDeviceType r=webrtc-reviewers,padenot,bwc
https://hg.mozilla.org/integration/autoland/rev/606e9fdfafc8
Remove CaptureDeviceInfo r=bwc
https://hg.mozilla.org/integration/autoland/rev/1dc0bdae4ab9
Sort include headers in mediapacket.* per coding style r=webrtc-reviewers,bwc
https://hg.mozilla.org/integration/autoland/rev/1d2154af7c24
Apply DefineEnum to MediaPacket::Type r=webrtc-reviewers,bwc
https://hg.mozilla.org/integration/autoland/rev/bc1e9674b5c2
Alphabetize include headers in GVAutoplayPermissionRequest.cpp r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/4a710ea6afe4
Apply DefineEnum to GVAutoplayRequestType r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/2e748cb90e63
Apply DefineEnum to GVAutoplayRequestStatus r=media-playback-reviewers,padenot
Keywords: leave-open

https://hg.mozilla.org/mozilla-central/rev/6fbdb064a782
https://hg.mozilla.org/mozilla-central/rev/4301a3864179
https://hg.mozilla.org/mozilla-central/rev/ff0cbcf2168b
https://hg.mozilla.org/mozilla-central/rev/2f3ec4eaecd8
https://hg.mozilla.org/mozilla-central/rev/a6ff1bea97c3
https://hg.mozilla.org/mozilla-central/rev/b45bb953500a
https://hg.mozilla.org/mozilla-central/rev/1a47e108fb9a
https://hg.mozilla.org/mozilla-central/rev/7c5c872917c7
https://hg.mozilla.org/mozilla-central/rev/320420a212d9
https://hg.mozilla.org/mozilla-central/rev/b643f25531ed
https://hg.mozilla.org/mozilla-central/rev/b71c89fc4c6b
https://hg.mozilla.org/mozilla-central/rev/3beecf2e10ad
https://hg.mozilla.org/mozilla-central/rev/9faa74aa9ed9
https://hg.mozilla.org/mozilla-central/rev/b52309352b73
https://hg.mozilla.org/mozilla-central/rev/905f79331006
https://hg.mozilla.org/mozilla-central/rev/c1af69b8c65f
https://hg.mozilla.org/mozilla-central/rev/5e0920babf30
https://hg.mozilla.org/mozilla-central/rev/5d4836ac9d64
https://hg.mozilla.org/mozilla-central/rev/19d340c5ac08
https://hg.mozilla.org/mozilla-central/rev/7ef644b68110
https://hg.mozilla.org/mozilla-central/rev/56bf01672a8c
https://hg.mozilla.org/mozilla-central/rev/434101dbcc3a
https://hg.mozilla.org/mozilla-central/rev/ef00a408552d
https://hg.mozilla.org/mozilla-central/rev/5bdce5274855
https://hg.mozilla.org/mozilla-central/rev/76a1dcd13a2c
https://hg.mozilla.org/mozilla-central/rev/fb7ac256135d
https://hg.mozilla.org/mozilla-central/rev/3d91efc04d74
https://hg.mozilla.org/mozilla-central/rev/c5c9df23c137
https://hg.mozilla.org/mozilla-central/rev/bd54a48e2007
https://hg.mozilla.org/mozilla-central/rev/2f8d92f22d74
https://hg.mozilla.org/mozilla-central/rev/624e20d6125f
https://hg.mozilla.org/mozilla-central/rev/9f1e64978cf8
https://hg.mozilla.org/mozilla-central/rev/fc23dcc98a1b
https://hg.mozilla.org/mozilla-central/rev/e271614ee785
https://hg.mozilla.org/mozilla-central/rev/27d5b12dc9c9
https://hg.mozilla.org/mozilla-central/rev/8500a9b182dd
https://hg.mozilla.org/mozilla-central/rev/606e9fdfafc8
https://hg.mozilla.org/mozilla-central/rev/1dc0bdae4ab9
https://hg.mozilla.org/mozilla-central/rev/1d2154af7c24
https://hg.mozilla.org/mozilla-central/rev/bc1e9674b5c2
https://hg.mozilla.org/mozilla-central/rev/4a710ea6afe4
https://hg.mozilla.org/mozilla-central/rev/2e748cb90e63

Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: