1886057 - Replace custom functions returning dom enum item defined in webidls by GetEnumString

Status: RESOLVED FIXED

(Core :: Audio/Video, task, P5)

Description

[C.M.Chang[:chunmin]]

GetEnumString can return the dom-binding-generated strings defined in EnumStrings<Enum>::Values. Thus, all the custom functions converting a dom enum item to a string, such as ToMediaKeyStatusStr or ToMediaControlKeyStr can be replaced by GetEnumString accordingly.

Comment 1

[C.M.Chang[:chunmin]]

Attachment: Bug 1886057 - Replace ToMediaKeyStatusStr by GetEnumString

The ToMediaKeyStatusStr can be replaced by GetEnumString since
GetEnumString is able to access the enum mapping strings of the
MediaKeyStatus generated by the dom binding in
EnunString<MediaKeyStatus>::Values

Comment 2

[C.M.Chang[:chunmin]]

Attachment: Bug 1886057 - Replace ToMediaControlKeyStr by GetEnumString

The ToMediaControlKeyStr can be replaced by GetEnumString since
GetEnumString is able to access the enum mapping strings of the
MediaControlKey generated by the dom binding in
EnunString<MediaControlKey>::Values

Depends on D204963

Comment 3

[C.M.Chang[:chunmin]]

Attachment: Bug 1886057 - Replace ToMediaSessionActionStr by GetEnumString

The ToMediaSessionActionStr can be replaced by GetEnumString since
GetEnumString is able to access the enum mapping strings of the
MediaSessionAction generated by the dom binding in
EnunString<MediaSessionAction>::Values

Depends on D205006

Comment 4

[C.M.Chang[:chunmin]]

Attachment: Bug 1886057 - Replace FormatToString by GetEnumString

The FormatToString can be replaced by GetEnumString since
GetEnumString is able to access the enum mapping strings of the
AudioSampleFormat generated by the dom binding in
EnunString<AudioSampleFormat>::Values

Depends on D205007

Comment 5

[C.M.Chang[:chunmin]]

Attachment: Bug 1886057 - Replace ToStateStr by GetEnumString

The ToStateStr can be replaced by GetEnumString since
GetEnumString is able to access the enum mapping strings of the
TextTrackMode generated by the dom binding in
EnumString<TextTrackMode>::Values

Depends on D205159

Comment 6

[C.M.Chang[:chunmin]]

Attachment: Bug 1886057 - Replace ToTextTrackKindStr by GetEnumString

The ToTextTrackKindStr can be replaced by GetEnumString since
GetEnumString is able to access the enum mapping strings of the
TextTrackKind generated by the dom binding in
EnumString<TextTrackKind>::Values

Depends on D205235

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce3a6cf698ec
Replace ToMediaKeyStatusStr by GetEnumString r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/3daba4b63121
Replace ToMediaControlKeyStr by GetEnumString r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/93dcd5c56c14
Replace ToMediaSessionActionStr by GetEnumString r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/deeb4d41a8ed
Replace FormatToString by GetEnumString r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/eee295a109f8
Replace ToStateStr by GetEnumString r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/4e4e5d843fc3
Replace ToTextTrackKindStr by GetEnumString r=media-playback-reviewers,padenot

Comment 8

[Cristian Tuns]

Backed out for causing build bustages in MFCDMSession.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/dom/media/platforms/wmf/MFCDMSession.cpp(247,14): error: no member named 'GetEnumString' in namespace 'mozilla::dom'

Comment 9

[C.M.Chang[:chunmin]]

The updated D204963 patch will fix this issue. Testing this on CI here.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bb855963107
Replace ToMediaKeyStatusStr by GetEnumString r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/f9100d75861e
Replace ToMediaControlKeyStr by GetEnumString r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/202c1dec07e5
Replace ToMediaSessionActionStr by GetEnumString r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/f44425f5a82c
Replace FormatToString by GetEnumString r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/fd31142b9787
Replace ToStateStr by GetEnumString r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/2d20711630de
Replace ToTextTrackKindStr by GetEnumString r=media-playback-reviewers,padenot

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0bb855963107
https://hg.mozilla.org/mozilla-central/rev/f9100d75861e
https://hg.mozilla.org/mozilla-central/rev/202c1dec07e5
https://hg.mozilla.org/mozilla-central/rev/f44425f5a82c
https://hg.mozilla.org/mozilla-central/rev/fd31142b9787
https://hg.mozilla.org/mozilla-central/rev/2d20711630de