1865897 - V120: Address bar highlight changed with the same firefox theme

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[nanioegaku]

Attachment: NewCanvas1.jpg

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:120.0) Gecko/20100101 Firefox/120.0

Steps to reproduce:

Updated Firefox to V120

Actual results:

The ADDRESS URL BAR AT THE TOP and it's SEARCH BAR changed from Sonic Blue to a bright sky blue when highlighting the text with the mouse/keyboard while using the same Theme i've used for years (This one https://addons.mozilla.org/es/firefox/addon/blue-mozilla-firefox/?utm_source=addons.mozilla.org&utm_medium=referral&utm_content=search )

Expected results:

The highlighted address URL bar and search words should've remained as to what the previous theme was like

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Theme' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Dão Gottwald [:dao]]

For us to understand if something changed here unintentionally, it would be helpful to know when this change happened. Would you be able to help us find a regression range here using the mozregression tool? (See https://mozilla.github.io/mozregression/)

Comment 3

[nanioegaku]

https://prnt.sc/bOhP7j1iX1FF

It's my 1st time using it so i have no idea if it's correct or not, but i'll explain what i did

1. Install and open it

2. Click the scissors, next, next

3. Chose date 2023-11-20 (Just in case) to 2023-11-22 (Today)

4. Every time the app opened FF it opened it with the default theme (The white one) and NOT the one i'm actually using. So i kept saying Bad everytime and there was no other time where it shown my UI etc

Day 20 build: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a325ddccae9b4381abab92bb365767cb0d052e8d&tochange=a5344cb2bc69d3b9f162dbff5244b4c44efa3970

Day 21 build: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e39cc33d235644207d14479a4f952740cca9387d&tochange=7bc9f9c659dd5c04c341cef4f898cb08574d9cdd

I'm not sure if what i'm doing is wrong or not because honestly, again, it's my 1st time...

Comment 4

[Negritas Sergiu, Desktop QA]

Hello! I have tried to reproduce the issue with firefox 122.0a1(2023-11-22) on Ubuntu 22.04 and Windows 10, unfortunately I wasn't able to reproduce the issue on my end. Could you please answer the following questions in order to further investigate this isssue.

1. Does this issue happen with a new profile? Here is a link on how to create one: https://support.mozilla.org/en-US/kb/profile-manager-create-remove-switch-firefox-profiles
2. Does this issue happen in the latest nightly? Here is a link from where you can download it: https://www.mozilla.org/en-US/firefox/channel/desktop/
3. Do you have any addons installed? If yes could you please list them?

Comment 5

[nanioegaku]

1. It happens with a new profile WITHOUT EXTENSIONS/ADDONS/ETC. AKA i create a new profile, choose it as default, restart FF 120, it shows the 1st startup with the white UI. I choose the same Blue Mozilla Firefox theme linked above. The highlighted URL Address and Search bars are still brightly cyan blue (even when you search stuff and the suggested links saved from bookmarks etc appears below the address bar as ya type)

2. It also happens in the latest Nightly build

3. uBlock Origin, MyJDownloader Browser Extension , F.B Purityy, FastForward (Again, even on a new clean profile without such stuff STILL HAPPENS)

Comment 6

[nanioegaku]

I've got a new e-mail but i don't see anything new here. What's going on?...

Comment 7

[Marco Bonardo [:mak]]

That regression range seems wrong, as it's pointing to changes in Firefox 122, but the bug here happened in Firefox 120.
I think you want to start the regression search start a lot more in the past, just set GOOD to release 119, instead of a date.
Then we only need the pushlog_url

Comment 8

[nanioegaku]

These are ALL the pushlog_url that i got in order, just in case:

NOTE that i choosen "Version/Release" and chosen 118 (i think) to 120, YET the regression tool always installed me the 120 NIGHTLY or something

1st: GREYED https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=18ac70a5128d520641cced852fc0059536c52713&tochange=1f052dc81e97a0a6b5e4eb6a2705a615ce6ac7d6

2nd: GREEN https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=24f12f75ef9b9232009f6a41ab3ac81b7947a585&tochange=1f052dc81e97a0a6b5e4eb6a2705a615ce6ac7d6

3rd: RED https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=24f12f75ef9b9232009f6a41ab3ac81b7947a585&tochange=9206f73c0e6e7e4e5de6cd5c2785c86b8f41f9ac

4th: GREEN https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6404412771ea15ef1c719a515dd1369360fb8d4d&tochange=9206f73c0e6e7e4e5de6cd5c2785c86b8f41f9ac

5th: GREEN https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7df8f9c41c9b60e87a707e41745479aaefaf782e&tochange=9206f73c0e6e7e4e5de6cd5c2785c86b8f41f9ac

6th: GREEN https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a5369079cd89dd91a42689da9aad1fc607ef9146&tochange=9206f73c0e6e7e4e5de6cd5c2785c86b8f41f9ac

7th: GREY https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a5369079cd89dd91a42689da9aad1fc607ef9146&tochange=9206f73c0e6e7e4e5de6cd5c2785c86b8f41f9ac

8th: GREEN https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=810153993fc0b06ce0eabae2602fc7f74ed9be18&tochange=9206f73c0e6e7e4e5de6cd5c2785c86b8f41f9ac

9th: GREEN https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0db2502d9e9503580a800e13235be8c02043bbc0&tochange=9206f73c0e6e7e4e5de6cd5c2785c86b8f41f9ac

10th: GREY https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0db2502d9e9503580a800e13235be8c02043bbc0&tochange=9206f73c0e6e7e4e5de6cd5c2785c86b8f41f9ac

11th: GREEN https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=055864c76b58044394c7ebe5bdab6d538d29e62f&tochange=9206f73c0e6e7e4e5de6cd5c2785c86b8f41f9ac

12th: RED https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=055864c76b58044394c7ebe5bdab6d538d29e62f&tochange=820dd45bad420e93261ea6a05aba44d1ea886c21

13th: RED https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=055864c76b58044394c7ebe5bdab6d538d29e62f&tochange=e9671bf4fb2b29522cdfbc6ea655580fb1383886

14th: RED https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=055864c76b58044394c7ebe5bdab6d538d29e62f&tochange=4cd17f7d1d306b8deb8ffaaa261e9fee0f879859

15th (LAST): RED https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=055864c76b58044394c7ebe5bdab6d538d29e62f&tochange=518d9d15677fd5f154216762af1d5867c17a90a8

Comment 9

[Marco Bonardo [:mak]]

Ah that's a lot more reasonable, thank you!

This has also been reported on Reddit here and here in case we need to ask more questions to users.

Comment 10

[nanioegaku]

Now that you've shown you those 2 links, let me explain the situation on my side comparing it to the FIRST ONE with my actual version of FF120, because there's something new i've noticed that i don't like...

His "mouse hovering over links in the Address Bar" highlight colour is the blue that i loved back then when highlighting the URL address bar AND the SEARCH BAR TOO.

HOWEVER mine is shown GREY (and also with the blinding cyan blue texts)

MINE: https://prnt.sc/IEejuav3dWOx

Hopefully this helps out

Also, you may wanna see my reddit post here and add it to the mix https://www.reddit.com/r/firefox/comments/17zyypi/v120_made_highlighted_text_on_the_url_to_be_sky/

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1858711

Comment 12

[nanioegaku]

...What does that mean?...

Comment 13

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1865897 - Make sure default toolbar field colors are used for color-scheme determination. r=dao

Having the defaults in global-shared.css means that we don't account for
them when trying to determine the toolbar color-scheme. If the theme
defines a dark toolbar color, that means we end up with an
effectively light urlbar which inherits the dark color-scheme from the
toolbar.

Comment 14

[nanioegaku]

Well, hopefully all these reports helps into bringing things back to what they were before 120 while keeping the fixes etc of 120 and forward

If ya want us to test a new build to see if it works then let us know

Comment 15

[Emilio Cobos Álvarez (:emilio)]

Sure, comment 13 explains what's going on and should fix this. https://treeherder.mozilla.org/jobs?repo=try&revision=9a4319d32cb161d15ae6c3b2e7d54e1e72a95216 should have builds in a bit if you want to try them out.

Comment 16

[nanioegaku]

Will gladly help .. Just let us know..

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9609b796760
Make sure default toolbar field colors are used for color-scheme determination. r=dao,desktop-theme-reviewers

Comment 18

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b9609b796760

Comment 19

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox121 to wontfix.

For more information, please visit BugBot documentation.

Comment 20

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9365393 [details]
Bug 1865897 - Make sure default toolbar field colors are used for color-scheme determination. r=dao

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively simple fix.
• String changes made/needed: none
• Is Android affected?: No

Comment 21

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9365393 [details]
Bug 1865897 - Make sure default toolbar field colors are used for color-scheme determination. r=dao

Approved for 121.0b5.

Comment 22

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/d33d3f4a57d5

Comment 23

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox 122.0a1 (2023-11-29) on Windows 10 x64 and Windows 11 x64.

Comment 24

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox 121.0b5 on Windows 10 x64 and Windows 11 x64.