Closed
Bug 1866438
Opened 10 months ago
Closed 7 months ago
Create a nimbus rollout for the highlighting feature
Categories
(Firefox :: PDF Viewer, task)
Firefox
PDF Viewer
Tracking
()
RESOLVED
FIXED
125 Branch
People
(Reporter: marco, Assigned: calixte)
References
Details
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
diannaS
:
approval-mozilla-beta+
|
Details | Review |
We need to do something similar to bug 1859365 for the highlighting feature.
Reporter | ||
Comment 1•10 months ago
|
||
Barret, do we need to implement an exposure event to identify the population who's actually opening PDFs or can we get this info some other way?
Flags: needinfo?(brennie)
Comment 2•10 months ago
|
||
I believe you would have to implement an exposure event -- I don't know if we have any telemetry regarding opening PDFs.
Flags: needinfo?(brennie)
Reporter | ||
Updated•7 months ago
|
Assignee: nobody → cdenizet
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•7 months ago
|
||
Pushed by cdenizet@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4752ecef06b0
Register pdfjs.enableHighlightEditor with Nimbus r=marco,barret
Comment 5•7 months ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
status-firefox125:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 125 Branch
Updated•7 months ago
|
status-firefox124:
--- → affected
tracking-firefox124:
--- → +
Assignee | ||
Comment 6•7 months ago
|
||
Comment on attachment 9382630 [details]
Bug 1866438 - Register pdfjs.enableHighlightEditor with Nimbus r=marco,barret
Beta/Release Uplift Approval Request
- User impact if declined: No experiment for the highlight feature in pdf.js.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: Bug 1866437, Bug 1883050
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Very small change and pdf.js is self contained.
- String changes made/needed:
- Is Android affected?: No
Attachment #9382630 -
Flags: approval-mozilla-beta?
Comment 7•7 months ago
|
||
Comment on attachment 9382630 [details]
Bug 1866438 - Register pdfjs.enableHighlightEditor with Nimbus r=marco,barret
Approved for 124.0b7
Attachment #9382630 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•7 months ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•