1867513 - Enable highlighting in a PDF in Release

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, task)

Description

[Marco Castelluccio [:marco]]

Once we are ready to ship, we should turn the pref on in Release.

Release Note Request (optional, but appreciated)
[Why is this notable]: A new user visible feature in the PDF viewer.
[Affects Firefox for Android]: No.
[Suggested wording]: It is now possible to highlight information in the Firefox PDF viewer.
[Links (documentation, blog post, etc)]: N/A

Comment 1

[Dianna Smith [:diannaS] - on Leave, back on August 9th]

Hi :marco! is this still being targeted for Fx124?

Comment 2

[Marco Castelluccio [:marco]]

Yes, we are planning to land a couple more fixes before the soft freeze, and potentially uplift telemetry (if we don't manage to get it in time for the soft freeze), but we should be ready for 124.

Comment 3

[Marco Castelluccio [:marco]]

We should enable this by default in 125, and keep it disabled in 124 as we will control the pref there through Nimbus.

Comment 4

[Dianna Smith [:diannaS] - on Leave, back on August 9th]

will 124+ relnote flag when final release notes draft is available where we will mention gradual rollout
Relnote Image has already been uploaded

Comment 5

[Marco Castelluccio [:marco]]

(In reply to Dianna Smith [:diannaS] from comment #4)

will 124+ relnote flag when final release notes draft is available where we will mention gradual rollout
Relnote Image has already been uploaded

This image refers to "add an image", which we released a while ago.
We should build another image for highlighting.

Comment 6

[Dianna Smith [:diannaS] - on Leave, back on August 9th]

oh ... womp womp.. ill fix that. let me know and I can upload it
(edit) https://www.mozilla.org/media/img/firefox/releasenotes/note-images/RN-image-highlight.png

Comment 7

[Marco Castelluccio [:marco]]

We have decided to release the feature in 125 instead because of bug 1881743 and bug 1881746.
We will release it through an experiment, so we can turn the pref on by default in 126.

Comment 8

[Marco Castelluccio [:marco]]

[Tracking Requested - why for this release]: We are releasing through Nimbus on 125, and by default in 126.

Comment 9

[Donal Meehan [:dmeehan]]

:marco since we are tracking this for Fx126, will a patch be attached to this bug to enable it by default?

Comment 10

[Marco Castelluccio [:marco]]

Yes, Calixte will build and land the patch.

Comment 11

[Donal Meehan [:dmeehan]]

Next week is the final week of beta for Fx126, last chance to uplift a patch for this

Comment 12

[Calixte Denizet (:calixte)]

Attachment: Bug 1867513 - Enable highlighting in a PDF in beta 126 r=marco

Comment 13

[Calixte Denizet (:calixte)]

Attachment: Bug 1867513 - Enable highlighting in a PDF in beta 126

Original Revision: https://phabricator.services.mozilla.com/D208547

Comment 14

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: They won't be able to highlight in a pdf
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: Low
• Explanation of risk level: It's a new feature which is behind a pref
• String changes made/needed: No
• Is Android affected?: no

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cffa531d3b2e
Enable highlighting in a PDF in beta 126 r=marco

Comment 16

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/cffa531d3b2e

Comment 17

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/c9a842140b73