1866565 - Do not open an about:addons tab when opening an abuse report form in a tab from a toolbar button context menu

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

While looking into the test failure hit by Bug 1863307 I noticed another minor issue that was not yet caught by the QA verifications:

• when the AMO-hosted abuse report form is enabled, we will be opening a new tab to allow the user to report an abuse on an installed extensions
• but in addition to the report action available to the user on the addon cards from an about:addons page, the user can also reach start the abuse report flow through the "Report Extension" and "Remove Extension" context menus actions available on the browser and page action toolbar buttons (also when the browser action is not pinned to the toolbar and instead listed in the extensions toolbar button panel)

Currently, under that scenario, we are opening two tabs: one for the about:addons page and another one for the AMO abuse report form url.

The about:addons tab is technically unnecessary and so we could consider to do not open it at all if the abuse report form hosted on AMO is enabled.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1866565 - Do not open an about:addons tab when opening an abuse report form in a tab from a toolbar button context menu. r?willdurand!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6de1ce5545d9
Do not open an about:addons tab when opening an abuse report form in a tab from a toolbar button context menu. r=willdurand

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/6de1ce5545d9

Comment 4

[Alex Cornestean]

Verified as Fixed. Tested on the latest Nightly (122.0a1/20231128094907) under Windows 10 x64 and Ubuntu 22.04 LTS.

Reporting an extension through the "Report Extension" and "Remove Extension" context menu actions available on the browser and page action toolbar buttons, as well as from the context menu and gear menu of the extensions panel, will no longer open about:addons in a tab alongside the abuse report form.

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 9365406 [details]
Bug 1866565 - Do not open an about:addons tab when opening an abuse report form in a tab from a toolbar button context menu. r?willdurand!

Beta/Release Uplift Approval Request

• User impact if declined: An unnecesary about:addons tab to be opened along with the tab for the abuse report (no other impact for the users besides that).
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Same STRs used to verify it on Nightly.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change is slow, restricted to the small method that was opening the abuse report form through the about:addons page, it is covered by automated tests and explicitly verified by QA.
  (as a side note this patch has to be applied on top of the patches that will be uplifted for Bug 1863307).
• String changes made/needed:
• Is Android affected?: No

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9365406 [details]
Bug 1866565 - Do not open an about:addons tab when opening an abuse report form in a tab from a toolbar button context menu. r?willdurand!

Approved for 121.0b5.

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/5ece1826f540

Comment 8

[Alex Cornestean]

Verified as Fixed. Tested on the latest Beta (121.0b6/20231201091738) under Windows 10 x64 and Ubuntu 22.04 LTS.

Reporting an extension through the "Report Extension" and "Remove Extension" context menu actions available on the browser and page action toolbar buttons, as well as from the context menu and gear menu of the extensions panel, will no longer open about:addons in a tab alongside the abuse report form.