Closed Bug 1866666 Opened 3 months ago Closed 3 months ago

[popover] Enable popover in nightly

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
122 Branch
Tracking Status
relnote-firefox --- nightly+
firefox122 --- fixed

People

(Reporter: zsun, Assigned: zsun)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

No description provided.

Bearing in mind that Anchor positioning is not supported yet and
some css position tests have been marked with popover flag as false
(see D193905).

Assignee: nobody → zsun
Status: NEW → ASSIGNED

@emilio, the patch has been updated as per your comment. Is it Okay to take another look? Many thanks!

Flags: needinfo?(emilio)

Yeah, looks good with the flags kept in WPT metadata for now, but some questions:

Thanks.

Flags: needinfo?(emilio)
Attachment #9365499 - Attachment description: Bug 1866666 - Enable popover. r=emilio → Bug 1866666 - Enable popover in nightly. r=emilio
Pushed by zsun@igalia.com:
https://hg.mozilla.org/integration/autoland/rev/dce8165893af
Enable popover in nightly. r=emilio
Blocks: popover
Keywords: dev-doc-needed
Attachment #9365499 - Attachment description: Bug 1866666 - Enable popover in nightly. r=emilio → Bug 1866666 - Enable popover in nightly. r=emilio,smaug

(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)

Yeah, looks good with the flags kept in WPT metadata for now, but some questions:

Thanks.

Thanks Emilio! I will try to get nightly only patch landed first. After that, I will send the intent email with a link of https://wpt.fyi/results/html/semantics/popovers. Does it sound Okay?

Flags: needinfo?(zsun)
Pushed by zsun@igalia.com:
https://hg.mozilla.org/integration/autoland/rev/dda160578104
Enable popover in nightly. r=emilio,smaug
Summary: [popover] Enable popover → [popover] Enable popover in nightly
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
Regressions: 1867266

:zsun could you consider nominating this for a release note? (Process info)
We could include it in the nightly release notes.

Flags: needinfo?(zsun)

Release Note Request (optional, but appreciated)
[Why is this notable]:
[Affects Firefox for Android]:
[Suggested wording]:
[Links (documentation, blog post, etc)]: https://html.spec.whatwg.org/#the-popover-attribute

relnote-firefox: --- → ?
Flags: needinfo?(zsun)

(In reply to Donal Meehan [:dmeehan] from comment #9)

:zsun could you consider nominating this for a release note? (Process info)
We could include it in the nightly release notes.

Donal, I changed the relnote-firefox. Is it good enough?

(In reply to zsun from comment #11)

(In reply to Donal Meehan [:dmeehan] from comment #9)

:zsun could you consider nominating this for a release note? (Process info)
We could include it in the nightly release notes.

Donal, I changed the relnote-firefox. Is it good enough?

Thanks for the nomination, could you add some suggested wording?
I can reword it if needed, but it's useful to have something technical to start with.
If you look through the Web Platform sections in release notes you'll see some previous examples.

Yes.
[Suggested wording]: Enable Popover attribute feature for nightly.

Thanks, added some wording based on MDN info to the Fx122 nightly release notes, please allow 30 mins for the site to update.

Related Pull Requests

See Also: → 1866993
You need to log in before you can comment on or make changes to this bug.