[popover] Enable popover in nightly
Categories
(Core :: DOM: Core & HTML, enhancement)
Tracking
()
Tracking | Status | |
---|---|---|
firefox122 | --- | fixed |
People
(Reporter: zsun, Assigned: zsun)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
Bearing in mind that Anchor positioning is not supported yet and
some css position tests have been marked with popover flag as false
(see D193905).
Updated•10 months ago
|
@emilio, the patch has been updated as per your comment. Is it Okay to take another look? Many thanks!
Comment 3•10 months ago
|
||
Yeah, looks good with the flags kept in WPT metadata for now, but some questions:
- Can you send an intent email to dev-platform as per https://wiki.mozilla.org/ExposureGuidelines?
- Can you summarize what the state of the feature is in terms of WPT tests passing vs. not? I guess https://wpt.fyi/results/html/semantics/popovers doesn't contain results with the pref on because it's not enabled on nightly yet. Might be worth landing a patch enabling only on nightly (
@IS_NIGHTLY_BUILD@
in the pref value).
Thanks.
Updated•10 months ago
|
Pushed by zsun@igalia.com: https://hg.mozilla.org/integration/autoland/rev/dce8165893af Enable popover in nightly. r=emilio
Updated•10 months ago
|
Comment 5•10 months ago
|
||
Backed out for causing mochitest plain failures at dom/tests/mochitest/general/test_interfaces.html
Backout link: https://hg.mozilla.org/integration/autoland/rev/7d5d7d788f20bdea21c17916063d258633f7f378
Updated•10 months ago
|
(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)
Yeah, looks good with the flags kept in WPT metadata for now, but some questions:
- Can you send an intent email to dev-platform as per https://wiki.mozilla.org/ExposureGuidelines?
- Can you summarize what the state of the feature is in terms of WPT tests passing vs. not? I guess https://wpt.fyi/results/html/semantics/popovers doesn't contain results with the pref on because it's not enabled on nightly yet. Might be worth landing a patch enabling only on nightly (
@IS_NIGHTLY_BUILD@
in the pref value).Thanks.
Thanks Emilio! I will try to get nightly only patch landed first. After that, I will send the intent email with a link of https://wpt.fyi/results/html/semantics/popovers. Does it sound Okay?
Pushed by zsun@igalia.com: https://hg.mozilla.org/integration/autoland/rev/dda160578104 Enable popover in nightly. r=emilio,smaug
Comment 8•9 months ago
|
||
bugherder |
Comment 9•9 months ago
|
||
:zsun could you consider nominating this for a release note? (Process info)
We could include it in the nightly release notes.
Assignee | ||
Comment 10•9 months ago
|
||
Release Note Request (optional, but appreciated)
[Why is this notable]:
[Affects Firefox for Android]:
[Suggested wording]:
[Links (documentation, blog post, etc)]: https://html.spec.whatwg.org/#the-popover-attribute
Assignee | ||
Comment 11•9 months ago
|
||
(In reply to Donal Meehan [:dmeehan] from comment #9)
:zsun could you consider nominating this for a release note? (Process info)
We could include it in the nightly release notes.
Donal, I changed the relnote-firefox. Is it good enough?
Comment 12•9 months ago
|
||
(In reply to zsun from comment #11)
(In reply to Donal Meehan [:dmeehan] from comment #9)
:zsun could you consider nominating this for a release note? (Process info)
We could include it in the nightly release notes.Donal, I changed the relnote-firefox. Is it good enough?
Thanks for the nomination, could you add some suggested wording?
I can reword it if needed, but it's useful to have something technical to start with.
If you look through the Web Platform sections in release notes you'll see some previous examples.
Assignee | ||
Comment 13•9 months ago
|
||
Yes.
[Suggested wording]: Enable Popover attribute feature for nightly.
Comment 14•9 months ago
|
||
Thanks, added some wording based on MDN info to the Fx122 nightly release notes, please allow 30 mins for the site to update.
Updated•9 months ago
|
Comment 16•6 months ago
|
||
Removed from the Nightly relnotes in favor of the note added in bug 1866993 riding the Fx125 train.
Description
•