1866666 - [popover] Enable popover in nightly

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Comment 1

[zsun]

Attachment: Bug 1866666 - Enable popover in nightly. r=emilio,smaug

Bearing in mind that Anchor positioning is not supported yet and
some css position tests have been marked with popover flag as false
(see D193905).

Comment 2

[zsun]

@emilio, the patch has been updated as per your comment. Is it Okay to take another look? Many thanks!

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Yeah, looks good with the flags kept in WPT metadata for now, but some questions:

• Can you send an intent email to dev-platform as per https://wiki.mozilla.org/ExposureGuidelines?
• Can you summarize what the state of the feature is in terms of WPT tests passing vs. not? I guess https://wpt.fyi/results/html/semantics/popovers doesn't contain results with the pref on because it's not enabled on nightly yet. Might be worth landing a patch enabling only on nightly (@IS_NIGHTLY_BUILD@ in the pref value).

Thanks.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dce8165893af
Enable popover in nightly. r=emilio

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest plain failures at dom/tests/mochitest/general/test_interfaces.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/7d5d7d788f20bdea21c17916063d258633f7f378

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | dom/tests/mochitest/general/test_interfaces.html | If this is failing: DANGER, are you sure you want to expose the new interface onbeforetoggle to all webpages as a property on 'window'?

Comment 6

[zsun]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)

Yeah, looks good with the flags kept in WPT metadata for now, but some questions:

• Can you send an intent email to dev-platform as per https://wiki.mozilla.org/ExposureGuidelines?
• Can you summarize what the state of the feature is in terms of WPT tests passing vs. not? I guess https://wpt.fyi/results/html/semantics/popovers doesn't contain results with the pref on because it's not enabled on nightly yet. Might be worth landing a patch enabling only on nightly (@IS_NIGHTLY_BUILD@ in the pref value).

Thanks.

Thanks Emilio! I will try to get nightly only patch landed first. After that, I will send the intent email with a link of https://wpt.fyi/results/html/semantics/popovers. Does it sound Okay?

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dda160578104
Enable popover in nightly. r=emilio,smaug

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/dda160578104

Comment 9

[Donal Meehan [:dmeehan]]

:zsun could you consider nominating this for a release note? (Process info)
We could include it in the nightly release notes.

Comment 10

[zsun]

Release Note Request (optional, but appreciated)
[Why is this notable]:
[Affects Firefox for Android]:
[Suggested wording]:
[Links (documentation, blog post, etc)]: https://html.spec.whatwg.org/#the-popover-attribute

Comment 11

[zsun]

(In reply to Donal Meehan [:dmeehan] from comment #9)

:zsun could you consider nominating this for a release note? (Process info)
We could include it in the nightly release notes.

Donal, I changed the relnote-firefox. Is it good enough?

Comment 12

[Donal Meehan [:dmeehan]]

(In reply to zsun from comment #11)

(In reply to Donal Meehan [:dmeehan] from comment #9)

:zsun could you consider nominating this for a release note? (Process info)
We could include it in the nightly release notes.

Donal, I changed the relnote-firefox. Is it good enough?

Thanks for the nomination, could you add some suggested wording?
I can reword it if needed, but it's useful to have something technical to start with.
If you look through the Web Platform sections in release notes you'll see some previous examples.

Comment 13

[zsun]

Yes.
[Suggested wording]: Enable Popover attribute feature for nightly.

Comment 14

[Donal Meehan [:dmeehan]]

Thanks, added some wording based on MDN info to the Fx122 nightly release notes, please allow 30 mins for the site to update.

Comment 15

[Dave Letorey]

Related Pull Requests

• Content PR
• Firefox release PR
• BCD PR

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Removed from the Nightly relnotes in favor of the note added in bug 1866993 riding the Fx125 train.