Closed Bug 1866993 Opened 7 months ago Closed 4 months ago

[popover] Enable popover by default

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
125 Branch
Tracking Status
relnote-firefox --- 125+
firefox125 --- fixed

People

(Reporter: zsun, Assigned: zsun)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

No description provided.
Assignee: nobody → zsun
Attachment #9366089 - Attachment description: WIP: Bug 1866993 - Enable popover by default. → Bug 1866993 - Enable popover by default. r=emilio
Status: NEW → ASSIGNED

Fwiw the link in the intent to this bug is wrong, the hyperlink goes to https://bugzilla.mozilla.org/show_bug.cgi?id=1860446 instead (guessing it got copied over without replacing actual link). Shouldn't really matter though :)

(In reply to Oliver Medhurst [:canadahonk] from comment #3)

Fwiw the link in the intent to this bug is wrong, the hyperlink goes to https://bugzilla.mozilla.org/show_bug.cgi?id=1860446 instead (guessing it got copied over without replacing actual link). Shouldn't really matter though :)

Thank you! Just sent an email to correct.

Blocks: popover

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:zsun, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Flags: needinfo?(zsun)
Flags: needinfo?(emilio)

Marked the patch as "Plan changes" since we need to add accessibility support in before we can land this patch.

Flags: needinfo?(zsun)
Flags: needinfo?(emilio)

Ziran, looks like the accessibility bits were fixed, do you think we're in good shape now? I'm not aware of any blockers for this anymore.

Flags: needinfo?(zsun)

(In reply to Emilio Cobos Álvarez (:emilio) from comment #7)

Ziran, looks like the accessibility bits were fixed, do you think we're in good shape now? I'm not aware of any blockers for this anymore.

Emilio, I'm not aware of any blockers either.

Flags: needinfo?(zsun)
See Also: → 1866666

@emilio, shall I land this patch?

Flags: needinfo?(emilio)

Yup, sounds good to me. Please make sure to update the intent thread.

Flags: needinfo?(emilio)
Pushed by zsun@igalia.com:
https://hg.mozilla.org/integration/autoland/rev/7f342afd4686
Enable popover by default. r=emilio
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 125 Branch

Should we add this to the Fx125 relnotes? Please nominate if so.

Flags: needinfo?(zsun)

(In reply to Ryan VanderMeulen [:RyanVM] from comment #13)

Should we add this to the Fx125 relnotes? Please nominate if so.

I think it's a good idea. @Emilio, is it Okay?

Flags: needinfo?(zsun)

In that case, please add a nomination by setting the relnote-firefox:? flag and filling out the form that comes with it.

Flags: needinfo?(zsun)

Release Note Request (optional, but appreciated)
[Why is this notable]:
[Affects Firefox for Android]:
[Suggested wording]:
The popover global attribute is used to designate an element as a popover element. The element won't render until it becomes shown, it will then render on top of other page content.
[Links (documentation, blog post, etc)]:
https://bugzilla.mozilla.org/show_bug.cgi?id=1808823
https://html.spec.whatwg.org/#the-popover-attribute

relnote-firefox: --- → ?
Flags: needinfo?(zsun)

Added to the fx125 relnotes

FF125 MDN work for this is tracked in https://github.com/mdn/content/issues/32663. This is already well documented, so it is just a release note and compatibility data update.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: