1866993 - [popover] Enable popover by default

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Comment 1

[zsun]

Attachment: Bug 1866993 - Enable popover by default. r=emilio

Comment 2

[zsun]

FYI, Intent to ship email at https://groups.google.com/a/mozilla.org/g/dev-platform/c/hrCP5RBO7mA

Comment 3

[Oliver Medhurst [:canadahonk]]

Fwiw the link in the intent to this bug is wrong, the hyperlink goes to https://bugzilla.mozilla.org/show_bug.cgi?id=1860446 instead (guessing it got copied over without replacing actual link). Shouldn't really matter though :)

Comment 4

[zsun]

(In reply to Oliver Medhurst [:canadahonk] from comment #3)

Fwiw the link in the intent to this bug is wrong, the hyperlink goes to https://bugzilla.mozilla.org/show_bug.cgi?id=1860446 instead (guessing it got copied over without replacing actual link). Shouldn't really matter though :)

Thank you! Just sent an email to correct.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:zsun, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 6

[zsun]

Marked the patch as "Plan changes" since we need to add accessibility support in before we can land this patch.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Ziran, looks like the accessibility bits were fixed, do you think we're in good shape now? I'm not aware of any blockers for this anymore.

Comment 8

[zsun]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #7)

Ziran, looks like the accessibility bits were fixed, do you think we're in good shape now? I'm not aware of any blockers for this anymore.

Emilio, I'm not aware of any blockers either.

Comment 9

[zsun]

@emilio, shall I land this patch?

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Yup, sounds good to me. Please make sure to update the intent thread.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f342afd4686
Enable popover by default. r=emilio

Comment 12

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/7f342afd4686

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Should we add this to the Fx125 relnotes? Please nominate if so.

Comment 14

[zsun]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #13)

Should we add this to the Fx125 relnotes? Please nominate if so.

I think it's a good idea. @Emilio, is it Okay?

Comment 15

[Emilio Cobos Álvarez (:emilio)]

Sure!

Comment 16

[Ryan VanderMeulen [:RyanVM]]

In that case, please add a nomination by setting the relnote-firefox:? flag and filling out the form that comes with it.

Comment 17

[zsun]

Release Note Request (optional, but appreciated)
[Why is this notable]:
[Affects Firefox for Android]:
[Suggested wording]:
The popover global attribute is used to designate an element as a popover element. The element won't render until it becomes shown, it will then render on top of other page content.
[Links (documentation, blog post, etc)]:
https://bugzilla.mozilla.org/show_bug.cgi?id=1808823
https://html.spec.whatwg.org/#the-popover-attribute

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Added to the fx125 relnotes

Comment 19

[Hamish Willee]

FF125 MDN work for this is tracked in https://github.com/mdn/content/issues/32663. This is already well documented, so it is just a release note and compatibility data update.