18668 - [DOGFOOD][crash]Internal W3/Helpdesk page crashes on load

Status: VERIFIED DUPLICATE of bug 6144

(Core :: XPCOM, defect, P3)

Description

[Grace Bush]

Steps to reproduce:
1. launch seamonkey, type w3 in url
2. go to IS Desk, online help request

Actual results: crash (stack coming later)
Expected result: access to my online help requests

Build 1999111108 WinNT
other notes: tried this previously and got to enter username, password before
crashing.

Comment 1

[Grace Bush]

incident 677995
Stack trace


nsCRT::strlen [d:\builds\seamonkey\mozilla\xpcom\ds\nsCRT.cpp, line 228]
nsString::Append [d:\builds\seamonkey\mozilla\xpcom\ds\nsString2.cpp, line 1071]
nsString::Assign [d:\builds\seamonkey\mozilla\xpcom\ds\nsString2.cpp, line 938]
nsDialogParamBlock::SetString
[d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsDialogParamBlock.cpp, line 113]
nsCommonDialogs::PromptUsernameAndPassword
[d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsCommonDialogs.cpp, line 230]
nsWebShellWindow::PromptUsernameAndPassword
[d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsWebShellWindow.cpp, line 3080]
SINGSIGN_PromptUsernameAndPassword
[d:\builds\seamonkey\mozilla\extensions\wallet\src\singsign.cpp, line 2277]
nsWalletlibService::PromptUsernameAndPasswordURL
[d:\builds\seamonkey\mozilla\extensions\wallet\src\nsWalletService.cpp, line
125]
nsWebShellWindow::PromptUsernameAndPassword
[d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsWebShellWindow.cpp, line 3134]
nsHTTPChannel::Authenticate
[d:\builds\seamonkey\mozilla\netwerk\protocol\http\src\nsHTTPChannel.cpp, line
962]
nsHTTPResponseListener::ProcessAuthentication
[d:\builds\seamonkey\mozilla\netwerk\protocol\http\src\nsHTTPResponseListener.cp
p, line 764]
nsHTTPResponseListener::ProcessStatusCode
[d:\builds\seamonkey\mozilla\netwerk\protocol\http\src\nsHTTPResponseListener.cp
p, line 692]
nsHTTPResponseListener::FinishedResponseHeaders
[d:\builds\seamonkey\mozilla\netwerk\protocol\http\src\nsHTTPResponseListener.cp
p, line 567]
nsHTTPResponseListener::OnDataAvailable
[d:\builds\seamonkey\mozilla\netwerk\protocol\http\src\nsHTTPResponseListener.cp
p, line 163]
nsOnDataAvailableEvent::HandleEvent
[d:\builds\seamonkey\mozilla\netwerk\base\src\nsAsyncStreamListener.cpp, line
417]
nsStreamListenerEvent::HandlePLEvent
[d:\builds\seamonkey\mozilla\netwerk\base\src\nsAsyncStreamListener.cpp, line
174]
PL_HandleEvent [plevent.c, line 538]
PL_ProcessPendingEvents [plevent.c, line 499]
_md_EventReceiverProc [plevent.c, line 976]
USER32.dll + 0x13ed (0x77e713ed)
nsAppShellService::Run
[d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsAppShellService.cpp, line 489]
main1 [d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp, line 586]
main [d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp, line 677]
mainCRTStartup()
KERNEL32.dll + 0x1b304 (0x77f1b304)

Comment 2

[leger]

Setting component for dp to take a look.

Comment 3

[Suresh Duddi (gone)]

Looks like wallet is passing a null pointer in with impunity. steve ?

Comment 4

[Stephen P. Morse]

I'm not seeing the crash but I'm seeing other things that are disturbing.
First, the instructions are not clear -- it says "go to IS Desk, online help
request".  There's actually nothing with that exact name but there is a link for
"Online Systems" and if I go there I find a choice for "Helpdesk Request".  I'll
assume that that is what was meant.

If I go there (and have never used the browser before), I first get the
single-signon one-time-only message asking if I want single signon enabled.  But
concurrent with that message I get a window saying:

   "Warning: NS_ENSURE_TRUE(Webshell) failed: "webshell"
   file: y:\mozilla\webshell\src\nsDocLoader.cpp line 1350
   Do you wish to continue running.

I press Yes in the warning dialog.  Then I press Cancel in the single-signon
dialog (so that nobody can accuse single signon of any impending problems).  I
then get the authentication dialog box.  Unfortunately the password field is
pre-filled with something (ten asterisks).  Single singon didn't do that!

From this point on, there is nothing I can do to get into the site.  Even if I
enter my correct username and password (overwriting the then asterisks), it
silently refuses to let me in but just keeps recycling me back to this
authentication dialog.  It doesn't matter if I press OK or if I press Cancel in
this dialog -- it still keeps recycling, keeping me lockin in this loop.

Comment 5

[Stephen P. Morse]

If I keep recycling in the loop described above, I sometime (intermittently but
it happened twice so far) get the following crash:

nsChannelListener::OnDataAvailable(nsChannelListener * const 0x02aa33e0,
nsIChannel * 0x0314c240, nsISupports * 0x00000000, nsIInputStream * 0x03176ec8,
unsigned int 0, unsigned int 207) line 1397
nsChannelListener::OnDataAvailable(nsChannelListener * const 0x03149030,
nsIChannel * 0x0314c240, nsISupports * 0x00000000, nsIInputStream * 0x03176ec8,
unsigned int 0, unsigned int 207) line 1397
nsHTTPResponseListener::OnDataAvailable(nsHTTPResponseListener * const
0x03176c10, nsIChannel * 0x0314be90, nsISupports * 0x0314c240, nsIInputStream *
0x03176ec8, unsigned int 0, unsigned int 207) line 175 + 47 bytes
nsOnDataAvailableEvent::HandleEvent(nsOnDataAvailableEvent * const 0x031739e0)
line 417
nsStreamListenerEvent::HandlePLEvent(PLEvent * 0x031757d0) line 173 + 12 bytes
PL_HandleEvent(PLEvent * 0x031757d0) line 537 + 10 bytes
PL_ProcessPendingEvents(PLEventQueue * 0x01071290) line 498 + 9 bytes
_md_EventReceiverProc(HWND__ * 0x0395052c, unsigned int 49315, unsigned int 0,
long 17240720) line 972 + 9 bytes
USER32! 77e71268()
01071290()

Comment 6

[Stephen P. Morse]

Garbage asterisks in authentication dialog can be fixed by making the following
change to nsHTTPChannel.cpp (in netwerk/protocol/http/src).

   in Authenticate:

      change PRUnichar *user, *passwd;
      to PRUnichar *user=NULL, *passwd=NULL;

Problem of looping and eventual crashing (it is reproducible if you keep looping
long enough) is totally in netwerk code.

Comment 7

[Stephen P. Morse]

Just received a code-review from Judson for the garbage-password problem and
will be checking it in as soon as the tree reopens.  Remaining looping problem
and crashing problem are both in necko, so I'm reassigning bug to Gagan.

Note: the crash I am talking about is the one corresponding to the second stack
frame given in this bug report.  I am unable to reproduce the first crash (the
one that goes through nsWalletService.cpp.

Finally there is still an outstanding problem -- namely the NS_ENSURE_TRUE
warning that comes up if this is the first time single-signon is ever used (you
can get back to this virgin state by clearing out the signon.Notified pref from
your prefs.js file).  I'm not sure whose problem that is.

Comment 8

[rickg]

Putting on pdt radar

Comment 9

[Gagan]

The looping looks a dup of 6144. Since I will be away for a while handing this
over to Judson.

Comment 10

[Stephen P. Morse]

Fix for garbage-password problem has been checked in.

Comment 11

[Judson Valeski]

so where are we on this? is there a reproducible (documented) test case?

Comment 12

[Stephen P. Morse]

Yes.  Go to w3, select the link to IS Desk, and from there click on the list for
Helpdesk Request.  You then get to the authentication dialog (after going thru
the one-time single-signon message if this is the first time ever that a login
form was encountered).  Fill it in and submit it.

First problem is that you cannot enter the site.  Everytime you submit the form,
you keep cycling back to the form.

Second problem is that after cycling like this for about a dozen times, you get
the crash with the stacktrace that I included (second of the two stack traces
appearing in this report).  I said it was intermittent, but that was only
because I didn't cycle long enough.  I believe that it will always occur if you
just keep on cycling.

You'll know when this bug is fixed if you can ever successfully get to the
helpdesk page.

Comment 13

[Judson Valeski]

I don't witness the crash. Actually, I can access the page just fine (after
dismissing (cancelling) the cycling auth dialog (and after entering my username
and pwd the first time). The cycling is caused by the non-persistent auth cache
(which is 6144).

*** This bug has been marked as a duplicate of 6144 ***

Comment 14

[Judson Valeski]

btw. I'm using a pull/clobber from this morning (along w/ morse's fix for the
junk in the pwd field).

Comment 15

[leger]

gbush, you want to verify as a dup?

Comment 16

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/b7e383b3cdaf
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/18668: Add stable ID cache for TabAdapter.getItemId