1866863 - Use Necko as the primary means to submit pings/reports from the crash reporter

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, enhancement)

Description

[Alex Franchuk [:afranchuk]]

In https://docs.google.com/document/d/1hpiiywAWDXoPlXHQNPmduyjFTbK_sEFRc8JXV60_n3A we discussed the interaction of the crash reporter and the pingsender, and how networking should work in the future. We decided that the crash reporter should use Necko as the primary means of sending pings/reports, with a fallback using system network stacks (through curl/libcurl, which are available on all target platforms).

The crash reporter is currently using the fallback network stacks as the sole means of sending reports, and is using pingsender (which uses system network stacks itself) for pings.

Using Necko is convenient as it will take into account user settings, such as proxy configurations, and also relies minimally on the system environment. Having a fallback is important if whatever causes Firefox to crash also causes background tasks using Necko to crash.

Comment 1

[Alex Franchuk [:afranchuk]]

Attachment: Bug 1866863 - Use Necko as the primary means to submit pings/reports from the crash reporter r=gsvelto

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c7e032df1cbc
https://hg.mozilla.org/integration/autoland/rev/da3b75c5a8d0
Use Necko as the primary means to submit pings/reports from the crash reporter r=gsvelto,necko-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/69063d561853
https://hg.mozilla.org/integration/autoland/rev/d85cde8f0231
Revert "Bug 1866863 - Use Necko as the primary means to submit pings/reports from the crash reporter r=gsvelto,necko-reviewers" for causing build bustages @ust.mk.

Comment 4

[agoloman]

Backed out for causing build bustages @ust.mk.

• Backout link
• Push with failures
• Failure Log

Comment 5

[Alex Franchuk [:afranchuk]]

Minor windows issue, easy to fix.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a80d976bb3fb
https://hg.mozilla.org/integration/autoland/rev/7cb67f55dc94
Use Necko as the primary means to submit pings/reports from the crash reporter r=gsvelto,necko-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/341fdae62fcf
https://hg.mozilla.org/integration/autoland/rev/4a85d97d9d85
Revert "Bug 1866863 - Use Necko as the primary means to submit pings/reports from the crash reporter r=gsvelto,necko-reviewers" for causing build bustages with crashreporter

Comment 8

[Cristian Tuns]

Backed out for causing build bustages

• Backout link
• Push with failures
• Failure Log
• Failure line: error: test failed, to rerun pass -p crashreporter --bin crashreporter

Comment 9

[Alex Franchuk [:afranchuk]]

Windows path separator issues...

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/07468f4b50f9
https://hg.mozilla.org/integration/autoland/rev/53bd364ccf77
Use Necko as the primary means to submit pings/reports from the crash reporter r=gsvelto,necko-reviewers

Comment 11

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/53bd364ccf77