1866902 - Bookmarks and History sidebars have Tree elements that are not labeled

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[❌ Anna Yeddi [:ayeddi] ❌ On leave until 2027-01-04]

The sidebar includes tree views for the Bookmarks and the History which are programmatically not labeled.

We could resolve it by referencing the on-screen label with id=sidebar-title which is updated with the change in the sidebar, as we want it to be.

Reference: ARIA Design pattern for Tree view

Comment 1

[❌ Anna Yeddi [:ayeddi] ❌ On leave until 2027-01-04]

Fixing this bug would allow to pass the following five Tier 2 a11y_checks:

Result	Path	Error	El ID	El tagName	El className
FAIL	browser/components/places/tests/browser/browser_bookmarkProperties_xulStore.js	Interactive elements must be labeled	bookmarks-view	tree	sidebar-placesTree
FAIL	browser/components/places/tests/browser/browser_sidebar_history_telemetry.js	Interactive elements must be labeled	historyTree	tree	sidebar-placesTree
FAIL	browser/components/places/tests/browser/browser_sidebar_open_bookmarks.js	Interactive elements must be labeled	bookmarks-view	tree	sidebar-placesTree
FAIL	browser/components/places/tests/browser/browser_sidebarpanels_click.js	Interactive elements must be labeled	bookmarks-view	tree	sidebar-placesTree
FAIL	browser/components/places/tests/browser/browser_sidebarpanels_click.js	Interactive elements must be labeled	historyTree	tree	sidebar-placesTree

Comment 2

[BugBot [:suhaib / :marco]]

The severity field for this bug is set to S4. However, the accessibility severity is higher, .
:mak, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 3

[❌ Anna Yeddi [:ayeddi] ❌ On leave until 2027-01-04]

Attachment: Bug 1866902 - Exclude accessible name tests from tree views a11y-checks on the Bookmarks and History sidebars

The sidebar includes tree views for the Bookmarks and the History which are programmatically not labeled.

We could resolve it by adding an aria-label that would reuse the on-screen label with a word folders for each of two sidebar views.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/840545607fdc
Exclude accessible name tests from tree views a11y-checks on the Bookmarks and History sidebars r=Jamie,places-reviewers,Standard8

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/840545607fdc