1866979 - The Add an image button should deselect when the user clicks inside of the PDF

Status: NEW

(Firefox :: PDF Viewer, enhancement)

Description

[Rares Doghi, Desktop QA]

Found in

• Nightly 122.0a1 (2023-11-27)

Affected versions

• Nightly 122.0a1 (2023-11-27)
• Beta 121.0b5

Affected platforms

• ALL

Steps to reproduce

1. Open a PDF in Firefox.
2. Click the Add an image button and add any image.
3. Click inside of the PDF.

Expected result

• The Add an image menu option should close when the user clicks inside of the PDF.
  Since the Add an image option is no longer triggered by clicking inside of the PDF there is no need for it to be displayed when the user clicks inside of the pdf

Actual result

• Add an image dropdown menu option remains displayed after an image is added to the pdf.

Regression range
Not Applicable

Comment 1

[Jonas Jenwald [:Snuffleupagus]]

(In reply to Rares Doghi, Desktop QA from comment #0)

• The Add an image menu option should close when the user clicks inside of the PDF.

Why though, since it'd make the following use-case more cumbersome:

1. Add an image.
2. Move and/or resize the image in the document.
3. Add another image.

Currently you can just click the "Add image"-button again, at step 3.
If we implement what this bug asks for you'd also need to first enable the StampEditor again, i.e. one more button-click before step 3, and we'd have a situation where the different Editor-toolbars behave inconsistently.

Comment 2

[Marco Castelluccio [:marco]]

This might be something to take into account when we think about redesigning the toolbar.

Comment 3

[Rares Doghi, Desktop QA]

Its true, it does make sense to have it enabled since its the only way to edit an already added image.

However If the user clicks inside the PDF file it seems natural to unselect the Add or Edit images button, If the user clicks the already added image (in order to resize it) the button would show as selected again without the dropdown option to "add images", and if the user would want to add an extra image he could just click the Add or Edit images button again which would show the dropdown option.

Any other Menu dropdown like "Pocket, Addons, Hamburger menu or even the >> Tools" will always close when we click somewhere else, the Add image dropdown option feels just like that.
The other editor toolbar items are interacting with pdf, those should remain enabled showing the users what their next action will be like starting a drawing point or the exact position to start adding text. Its not the case with the Add image dropdown button.