1866990 - Compose Tabs - Multi select menu (select tabs), disable Collection, Share and Menu when no tab is selected

Status: RESOLVED FIXED

(Fenix :: Tabs, task, P2)

Description

[twhite]

Steps to reproduce

1. Open Tabs
2. From the 3 dot menu select "Select tabs"

Expected behavior

• Collections button is tinted/faded and disabled
• Share button is tinted/faded and disabled
• 3 dot menu button is tinted/faded and disabled

Actual behavior

• Collections button is disabled but not tinted/faded
• Share button is enabled and not tinted/faded
• 3 dot menu button is enabled and not tinted/faded

Comment 1

[Alex]

Hi :twhite! Can I work on this bug?

Comment 2

[twhite]

Hey Alex, sure thing! I've added you as the assignee

Comment 3

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1866990 - Disable collection, share and menu in multiselect mode when no tab is selected (#5482)

Comment 5

[Noah Bond [:007]]

Attachment: Bug 1866990 - Disable collection, share and menu in multiselect mode when no tab is selected

Originally on Github: https://github.com/mozilla-mobile/firefox-android/pull/5482

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b8e4c563c2f
Disable collection, share and menu in multiselect mode when no tab is selected r=android-reviewers,gl

Comment 7

[Noah Bond [:007]]

Thanks, Alex, for this patch! I just landed it via Phabricator

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2b8e4c563c2f

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2b8e4c563c2f