1867006 - Disable HTTP2 websockets until we can resolve proxy issues.

Status: RESOLVED FIXED

(Core :: Networking: WebSockets, defect, P1)

Description

[Valentin Gosu [:valentin] (he/him)]

It seems using HTTP2 websockets with a HTTP2 proxy can sometimes cause WS to not work, or even crashes.
We should disable this until we can fix it and get CI to test this exact scenario to avoid regressions.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1867006 - Disable HTTP2 websockets until we can resolve proxy issues. r=#necko

Comment 2

[Kershaw Chang [:kershaw]]

Attachment: Bug 1867006 - Disable HTTP2 websockets until we can resolve proxy issues. r=#necko

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5a650ef4de4
Disable HTTP2 websockets until we can resolve proxy issues. r=necko-reviewers,valentin

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing failure on test_websocket_http2.html

Backout link

Push with failures

Failure log

Comment 5

[Kershaw Chang [:kershaw]]

https://treeherder.mozilla.org/jobs?repo=try&revision=f13017ea8b83be4a1c5962b70cf08bacba00ea1a

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74f50e5d5557
Disable HTTP2 websockets until we can resolve proxy issues. r=necko-reviewers,valentin

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/74f50e5d5557

Comment 8

[Valentin Gosu [:valentin] (he/him)]

Let's uplift this to beta.

Comment 9

[Kershaw Chang [:kershaw]]

Attachment: Bug 1867006 - Disable HTTP2 websockets until we can resolve proxy issues. r=#necko

Original Revision: https://phabricator.services.mozilla.com/D194871

Comment 10

[Phabricator Automation]

Uplift Approval Request

• Risk associated with taking this patch: No risk. This patch is basically a pref flip.
• String changes made/needed: N/A
• Needs manual QE test: no
• User impact if declined: Possible crash
• Fix verified in Nightly: yes
• Steps to reproduce for manual QE testing: N/A
• Explanation of risk level: Low
• Is Android affected?: yes
• Code covered by automated testing: yes

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9366254 [details]
Bug 1867006 - Disable HTTP2 websockets until we can resolve proxy issues. r=#necko

Approved for 121.0b6.

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/20d769c8e7c1

Comment 13

[Florent Fayolle]

Is it possible to backport this fix to Firefox ESR? (or backport the patch in bug 1848013, whatever is easier or more relevant)
My team meets lots of Firefox users who cannot use a service relying on Websocket exclusively because of what has been reported in bug 1848013 (their websocket connections pass through a squid Proxy). It really penalizes them.

Comment 14

[Kershaw Chang [:kershaw]]

I've requested to uplift the patch in bug 1848013 to ESR.

Comment 15

[Florent Fayolle]

Thank you Kershaw!