1867098 - Experiment for discoverability of PXI in the FxA toolbar button

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, task, P3)

Description

[Sammy Khamis [:skhamis]]

This is a continuation of Bug #1816560. Where it gives more context to the panel and potentially showing the user more context of signing in to FxA.

Link to experiment doc: https://docs.google.com/document/d/180D0i2T7UUGj6rNbABbgqCJ01Hx2B3JbOyWnDPaRTTQ/edit

Comment 1

[Sammy Khamis [:skhamis]]

Attachment: Bug 1867098: FxA PXI Toolbar experiment r=teshaq

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2499ef5644ea
FxA PXI Toolbar experiment r=teshaq,desktop-theme-reviewers,flod,dao

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2499ef5644ea

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/f2bd22bae178
Backed out changeset 2499ef5644ea as requested for causing Bug 1869728.

Comment 5

[Sammy Khamis [:skhamis]]

Attachment: Bug 1867098: FxA PXI Toolbar experiment (second try) r=teshaq

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24ecc439f82b
FxA PXI Toolbar experiment r=teshaq,desktop-theme-reviewers,flod,dao

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/24ecc439f82b

Comment 8

[Sammy Khamis [:skhamis]]

Attachment: Data Request Review Form

Adding Data Review as the new enums are not covered under the existing Data Review https://bugzilla.mozilla.org/show_bug.cgi?id=1542334

Comment 9

[Travis Long [:travis_]]

Comment on attachment 9368735 [details]
Data Request Review Form

Data Review

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, through the events.yaml file named in the request and the Glean Dictionary.

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, through the data preferences in the application settings.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

N/A, collection to end or be renewed in 6 months.

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, interaction data

5. Is the data collection request for default-on or default-off?

Default-on

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No

7. Is the data collection covered by the existing Firefox privacy notice?

Yes

8. Does the data collection use a third-party collection tool?

No

Result

data-review+

Comment 10

[Sammy Khamis [:skhamis]]

Attachment: Bug 1867098: FxA PXI Toolbar experiment r=teshaq

Original Revision: https://phabricator.services.mozilla.com/D194916

Comment 11

[Phabricator Automation]

Uplift Approval Request

• Needs manual QE test: yes
• Is Android affected?: no
• Code covered by automated testing: yes
• String changes made/needed: The experiment will run
• Fix verified in Nightly: yes
• Risk associated with taking this patch: Generally low risk as it's been in nightly and is set to default off
• Explanation of risk level: Since it's default off we do not expect to see issues with landing this. If an issue does arise we can always turn off the experiment
• Steps to reproduce for manual QE testing: 1. ensure
• User impact if declined: Cannot run experiment

Comment 12

[Phabricator Automation]

Uplift Approval Request

• Code covered by automated testing: yes
• Is Android affected?: no
• Needs manual QE test: yes
• String changes made/needed: The experiment will run only in english/NA. So no localization neded
• Fix verified in Nightly: yes
• Risk associated with taking this patch: Generally low risk as it's been in nightly and is set to default off
• Steps to reproduce for manual QE testing: 1. ensure identity.fxaccounts.toolbar.defaultVisible = true and identity.fxaccounts.toolbar.pxiToolbarEnabled is true 2. Validate you can see new PXI buttons when clicking the avatar menu
• Explanation of risk level: Since it's default off we do not expect to see issues with landing this. If an issue does arise we can always turn off the experiment
• User impact if declined: Cannot run experiment

Comment 13

[Phabricator Automation]

Uplift Approval Request

• Is Android affected?: no
• Needs manual QE test: no
• String changes made/needed: String changes are only needed in english/NA for now. Strings are also located in an out-of-locale tree file for easy removal.
• User impact if declined: Cannot run experiment/pushes back timeline
• Steps to reproduce for manual QE testing: In about:config 1. change fxaccounts.toolbar.defaultVisible to true and fxaccounts.toolbar.pxiToolbarEnabled to true to see the avatar icon (signed out). Signed in click the avatar to see the PXI icons
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Risk associated with taking this patch: Low
• Explanation of risk level: Majority of the functionality is behind a pref which will be controlled in experimenter. Any issues can be turned off quickly

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/3ebe4737d02f