Add FxA menu under the app (hamburger) menu

RESOLVED FIXED in Firefox 68

Status

()

enhancement
RESOLVED FIXED
3 months ago
18 days ago

People

(Reporter: vbudhram, Assigned: vbudhram)

Tracking

(Regressed 1 bug)

68 Branch
Firefox 68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(relnote-firefox 68+, firefox68 fixed)

Details

(Whiteboard: [FxA])

Attachments

(3 attachments)

As a follow up to https://bugzilla.mozilla.org/show_bug.cgi?id=1524665, we wanted to expose the same menu under the hamburger menu.

Please reference the designs at https://mozilla.invisionapp.com/share/HWQTPQL7Y2Q#/screens/350225002_Option_1 for more details.

Assignee: nobody → vbudhram
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9e242ede9b1c
Add FxA toolbar menu to app menu r=Gijs
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

Hey chutten, requesting a data review for the telemetry associated with this patch.

Attachment #9060770 - Flags: data-review?(chutten)
Comment on attachment 9060770 [details]
Link to data review doc

Preliminary notes:

In future please attach the body of the Data Collection Review request as an attachment instead of linking to a Google Doc. I will reproduce the request here so that it meets public documentation requirements of Data Collection Reviews:

What questions will you answer with this data?
How frequently users interact with the FxA app menu and what buttons they are clicking within the menu.
Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements? Some example responses:
Mozilla needs to answer these questions because it will help address product requirements. More specifically, it will allow us to answer how many people interact with the new toolbar menu but do not go on to authenticate with FxA (FxA authentication are tracked separately within the FxA metrics pipeline). It will also allow us to know how many users are interacting with other sync and fxa-related features.
What alternative methods did you consider to answer these questions? Why were they not sufficient?
No alternative methods were considered because there is no other way of gathering this information except through telemetry.
Can current instrumentation answer these questions?
No, this is a new feature and it does not yet have any telemetry associated with it.
List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the Mozilla wiki.

Telemetry event for user clicking “Account Settings” in toolbar menu (Category 2)
fxa_app_menu.account_settings

Telemetry event for user clicking “Connect Another Device” in toolbar menu (Category 2)
fxa_app_menu.cad

Telemetry event for user clicking “Send Tab to Device” in toolbar menu (Category 2)
fxa_app_menu.send_tab

Telemetry event for user clicking “Sync Now” in toolbar menu (Category 2)
fxa_app_menu.sync_now

Telemetry event for user clicking “Sync Settings” in toolbar menu (Category 2)
fxa_app_menu.sync_settings

Telemetry event for user clicking “Sync Tabs” in toolbar menu (Category 2)
fxa_app_menu.sync_tabs

Telemetry event for user clicking “Sync Tabs Sidebar” in toolbar menu (Category 2)
fxa_app_menu.sync_tabs_sidebar

Telemetry event for user opening toolbar menu (Category 2)
fxa_avfxa_app_menuatar_menu.toolbar_icon

Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.
How long will this data be collected? Choose one of the following:
I want to permanently monitor this data. 
Contact: loines@mozilla.com, vbudhram@mozillla.com
What populations will you measure?
Which release channels? All
Which countries? All
Which locales? All
No other filters
If this data collection is default on, what is the opt-out mechanism for users?
User can opt out of this telemetry by turning telemetry off generally.
Please provide a general description of how you will analyze this data.
We will cross reference these numbers with those in the FxA pipeline to figure out how many users clicked on the toolbar icon vs how many completed the authentication process. (the FxA metrics pipeline already has the necessary data needed to know how many users completed authentication via this entrypoint). We will also use them to understand if users are discovering sync and fxa-related features through this touchpoint. 
Where do you intend to share the results of your analysis?
Only with Mozilla employees/NDA mozillians
Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection? 
Not currently, but events may eventually be sent to amplitude in the medium-to-long term future.

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file [Events.yaml](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Events.yaml) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 73.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :vbudhram is responsible for renewing or removing the collection before it expires in Firefox 73.

---
Result: datareview+
Attachment #9060770 - Flags: data-review?(chutten) → data-review+
Keywords: checkin-needed
Whiteboard: [FxA] → [FxA][checkin-needed]

Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/47937619427b
Add telemetry for FxA app menu r=eoger,janerik

Keywords: checkin-needed
Whiteboard: [FxA][checkin-needed] → [FxA]
Regressions: 1549049
QA Whiteboard: [qa-68b-p2]
Regressions: 1560336
Blocks: 1560398
Type: defect → enhancement

This is in the 68.0beta desktop release notes as "Access your Firefox Account settings from the hamburger menu".

You need to log in before you can comment on or make changes to this bug.