1867261 - Pages can display "both portrait and landscape" if not all pages are being printed (Range, Even or Odd selected)

Status: NEW

(Core :: Print Preview, defect)

Description

[Catalin Sasca, Desktop QA [:csasca]]

Attachment: test file both portrait:landscape.png

Found in

• Firefox 122.0a1 (20231129050021)

Affected versions

• Firefox 122.0a1 (20231129050021)

Tested platforms

• Affected platforms: Windows 11, macOS 13.6.1, Ubuntu 22.04

Steps to reproduce

1. Launch Firefox and open the following link
2. Open Print Preview
3. From Pages, select "Even"

Expected result

• The "even" pages are shown and the pages are in portrait mode

Actual result

• The "even" pages are shown but the first page is rotated in landscape modeand kept in portrait as well (see attachment)

Additional notes

• The issue can be seen in the attachment
• The issue occurs with actual print / save to pdf

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:csasca, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Jonathan Watt [:jwatt]]

Interesting. Thanks for catching this. We won't block shipping support since mixed orientation is relatively uncommon, and previous telemetry that we've gathered also showed printing page ranges to be very uncommon.

Note: this also occurs when setting the "Pages" field to "Custom" and entering the range "2-5", and when scrolling to the second page (the landscape page) and selecting "Current". When the "Pages" field is set, those values are more commonly chosen than "Even" or "Odd".

Comment 3

[Jonathan Watt [:jwatt]]

Implementation note: this is an issue where the nsPageFrame orientation is not being matched with the PrintedSheetFrame orientation.

Comment 4

[Jonathan Watt [:jwatt]]

This is another manifestation of bug 1869211, and should be fixed by the fix for that bug.

Comment 5

[Jonathan Watt [:jwatt]]

Attachment: Bug 1867261. Fix pages to not simultaniously display portrait and landscape. r=alaskanemily

Comment 6

[Jonathan Watt [:jwatt]]

Attachment: Bug 1867261 p2. Add a chrome mochitest for page-orientation in print preview with a page range. r=alaskanemily

Comment 7

[Jonathan Watt [:jwatt]]

Attachment: Mochitest rendering before patch