1867273 - Bookmarks lose their original "Added" date when they were cut-and-pasted into a different folder

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[aoia7rz7l]

Tested on 119.0.1.

STR:

1. Open the Library.
2. Right-click on any of the column headers to add both the Added and Last Modified date column.
3. Drag-and-drop/cut-and-paste one or more bookmarks within the same folder.
4. Observe that both the Added and Last Modified date did not change.
5. Drag-and-drop one or more bookmarks into a different folder.
6. Observe that only the Last Modified date was updated.
7. Cut-and-paste one or more bookmarks into a different folder.

Expected Behavior:

Only the Last Modified date for these bookmarks were updated, whilst the Added date remain unchanged.

Actual Behavior:

The Added date was updated and identical to the Last Modified date when bookmarks were cut-and-pasted into a different folder.

Mozregression returned

Last good revision: 8f9703d8891ede813e3ce97435d50f0cb69a1a55
First bad revision: 1be4cb72888eb43d48eb98b0daf847eeaf34adc1
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=8f9703d8891ede813e3ce97435d50f0cb69a1a55&tochange=1be4cb72888eb43d48eb98b0daf847eeaf34adc1

During mozregression, I noticed in some of the 116.0a1 bad builds that bookmarks also lost their name when they were cut-and-pasted into a different folder, an issue of which seemed to be addressed in bug 1840207.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Setting Regressed by field after analyzing regression range found by mozregression in comment #0.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:daisuke, since you are the author of the regressor, bug 1829579, could you take a look?

For more information, please visit BugBot documentation.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1829579

Comment 5

[Donal Meehan [:dmeehan]]

:mak could this be triaged for severity?

Comment 6

[Marco Bonardo [:mak]]

This is just a visual bug, we're not updating the UI correctly, the bookmark data is safe.
I've verified that by cut/paste a bookmark into a folder in the Library, date added was wrong. But as soon as I opened another folder and then returned to this one, date added was correct.
We should fix it, but it's not a critical dataloss problem.

Comment 7

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1867273: Reflect the date of bookmark addition when moving bookmarks

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/efffe49c7c1c
Reflect the date of bookmark addition when moving bookmarks r=places-reviewers,mak

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/efffe49c7c1c

Comment 10

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on Firefox 121.0 on Windows 10.
Verified as fixed on Firefox 122.0b3 and Nightly 123.0a1 on Windows 10, Ubuntu 22, macOS 12.