1867523 - Performing key down/up actions fail for a pdf.js test that awaits for the "keyup" event

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: WebDriver BiDi test (patch)

The test that is failing is part of freetext_editor_spec.mjs and the particular lines can be found here:

https://github.com/mozilla/pdf.js/blob/d65dca781192470267e6af779773637afb83ecae/test/integration/freetext_editor_spec.mjs#L3031-L3040

When running the test I can see that Backspace is actually sent because the input's value is cleared, but the evaluation Promise doesn't resolve because no keyup event is emitted by the pageNumber input. Running the same test with CDP works fine.

Steps to run the test:

1. Clone https://github.com/mozilla/pdf.js
2. Run npm install.
3. Apply the changes from https://github.com/mozilla/pdf.js/pull/17172/files
4. Define a custom binary via the executablePath field in the options
5. Open freetext_editor_spec.mjs and use fdescribe("Avoid to steal keyboard events", () => { in line 2984.
6. Run the integration test with gulp integrationtest --noChrome

To check why it's only failing in BiDi I've created both a WebDriver test (see attachment) and a Marionette test, but both are passing. So I'm not sure what exactly is causing this test to fail.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Sasha, could you please have a look at? Thanks.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Because it is blocking the pdf.js tests lets make it a M9 bug.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The related upstream PR is https://github.com/mozilla/pdf.js/pull/17378.

Comment 4

[Alexandra Borovova [:Sasha]]

The fix is actually now being worked on by pdf.js team in the scope of https://github.com/mozilla/pdf.js/pull/17387.
:whimboo, should we maybe then close this bug, or you would prefer to keep it?

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Even the pdf.js team works on it we did all the investigation which took some time. As such lets close this bug once the pdf.js issue is fixed.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This is fixed now.