1867620 - Avoid updating the in-content search bar placeholders / text from multiple locations when in handoff mode

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[Mark Banner (:standard8)]

Currently the in-content search bar has multiple places where we manage the placeholders and strings when we're in search hand-off mode:

• newtab's Search.jsx
• aboutPrivateBrowsing.js
• contentSearchHandoffUI.js

This frequently means that we're updating the strings multiple times and can lead to flickering.

For example, if the browser.urlbar.suggest.searches preference is set to false, then when reloading the newtab page, you can see the placeholder flicker. This is partially because the Search.jsx implementation is incomplete.

I think the best places for these would be contentSearchHandoffUI as that is the primary and central point for handling the handoff UI.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1867620 - Avoid updating the in-content search bar placeholders / text from multiple locations when in handoff mode. r?mardak!

Comment 2

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/jobs?repo=try&revision=bc764db651f06830ee478e7f747c28735cc97338

Comment 3

[Ed Lee :Mardak]

The placeholder text functionality being removed were originally added in various bug 1508388 and bug 1616700 as they're more generally handled by contentSearchHandoffUI.js with improvements like bug 1722395.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c7ff4e061e3
Avoid updating the in-content search bar placeholders / text from multiple locations when in handoff mode. r=Mardak

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0c7ff4e061e3