1867626 - [wmfme] video displayed in incorrect place and size

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Alastor Wu [:alwu]]

Attachment: netflix-video-incorrect-size-and-place.png

When testing Netflix with MFCDM, I found that Netflix changes video resolution very frequently, and sometime the video would be displayed in incorrect place in a wrong size for a second, then back to normal.

After some debugging, I think the issue is caused by this. Whenever we detect video resolution change, we call IMFMediaEngineEx::UpdateVideoStream to assigns a new display position and recreate a new dcomp handle, which seems unnecessary.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1867626 - do not create dcomp surface handle and no need to update new size to media engine.

We should only use one dcomp handle which can fit for all different size
of videos, and the media engine seems already knowing the size of the
new video size, which is why the engine dispatches
MF_MEDIA_ENGINE_EVENT_FORMATCHANGE to us.

Therefore, we don't need to call UpdateVideoStream when the video size
change, but we still need to notify resize to media element, which
will be implemented in bug 1867634.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18a1810c7dee
do not create dcomp surface handle and no need to update new size to media engine. r=jolin

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/18a1810c7dee