Closed Bug 1867830 Opened 1 year ago Closed 11 months ago

Highlighting in PDF - Support Article Content [Desktop V125]

Categories

(support.mozilla.org :: Knowledge Base Content, task)

Product:
support.mozilla.org
Component:
Knowledge Base Content
Type:
task

Tracking

(firefox124 disabled, firefox125+ fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox124 --- disabled
firefox125 + fixed

People

(Reporter: ukhan, Assigned: lsiebert)

References

(
URL
)

Details

Is the content embargoed (yes or no)? [REQUIRED]

No

Product

Choose one below and delete others. [REQUIRED]
Firefox

Select the type of request.

Choose one or more below and delete others. [REQUIRED]
New article
Update existing article
In-product link request

Please provide a summary of the request. [REQUIRED]

PDF team is adding Highlighting functionality to the Firefox PDF Reader. The feature will allow the users to select a text or any area in the PDF document and highlight it. A few colors are supported. The detailed flow can be seen in the Figma file below.

Is this an on- or off-train release? Please indicate the product version number, if applicable and add to the Summary field using the format of [Product V123]. [REQUIRED]

On-train Fx v122

What is the anticipated release date? [REQUIRED]

Note: Content is typically published at, or within, 48 hours of the release.
On-train Fx v122 - January 23, 2023

Does the content need to be published prior to the release date? If so, when? [REQUIRED]

No

Does the content need to be localized in any languages outside of EN-US? If yes, please indicate which languages. [REQUIRED]

Note: Minimum of 10 days required for translation requests.
Yes, in the normal languages that we translate our regular support articles in.

Please include any related JIRA/Github/Bugzilla tickets, documentation, demos or practical use cases. [REQUIRED]

JIRA - https://mozilla-hub.atlassian.net/browse/FIDE-1720

Please include links to any design assets, visuals, figma files, etc. [REQUIRED]

Note: Please include final visual assets only.
Figma - https://www.figma.com/file/elSBKpUxHCZe6yTqoohUu9/PDF.js-Designs?type=design&node-id=4669-36250&mode=design&t=IRetTMXnStq7a9ZJ-0

Please add instructions for testing that will enable us to replicate the expected product behavior. [REQUIRED]

Please reach out to @calixte in #firefox-pdf-viewer on Slack

Does the content need approval prior to publishing? If so, by who? [REQUIRED]

No

Assignee: nobody → lsiebert
Summary: Highlighting in PDF - Support Article Content → Highlighting in PDF - Support Article Content [Desktop V123]

( from comment #0)

Is this an on- or off-train release? Please indicate the product version number, if applicable and add to the Summary field using the format of [Product V123]. [REQUIRED]

On-train Fx v122

What is the anticipated release date? [REQUIRED]

Note: Content is typically published at, or within, 48 hours of the release.
On-train Fx v122 - January 23, 2023

Change the summary from [Desktop V123] to [Desktop V122]?

URL: https://support.mozilla.org/en-US/kb/...
Summary: Highlighting in PDF - Support Article Content [Desktop V123] → Highlighting in PDF - Support Article Content [Desktop V122]

Updates to the content were made using {for fx122} brackets. This method prevents users of earlier versions from seeing the updated content.
Updated article: https://support.mozilla.org/en-US/kb/view-pdf-files-firefox-or-choose-another-viewer

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED

Related discussion and questions from a French localizer:
https://support.mozilla.org/en-US/kb/view-pdf-files-firefox-or-choose-another-viewer/discuss/11969 Highlight Editor off by default in 122?
(quote)
January 15, 2024 at 2:20:48 AM PST

In Firefox 122.0b9 FR, by default, there is no Highlight Editor in the pdfjs page. To turn it on, I must set to true the pref pdfjs.enableHighlightEditor in the config editor. Then The Highlight icon will be present on the pdfjs page, but not with the same functionalities as described in the article:
- I must turn it on before selecting an area to highlight
- I can't tweak the thickness
- there's no option to show or hide all highlights
My only choice is the highlight color.

In 123.0a1 FR, the Highlight Editor is on by default, but the features are the same as in 122.0b9.

Should we wait to localize this article, Highlight Editor seems to be a work in progress?

See Also: → 1867512, 1867513

Lucas, per Comment 3, this feature is not enabled for Fx122 release.
It will ship in a later release.

Flags: needinfo?(lsiebert)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

(In reply to Alice Wyman from comment #3)

Related discussion and questions from a French localizer:
https://support.mozilla.org/en-US/kb/view-pdf-files-firefox-or-choose-another-viewer/discuss/11969 Highlight Editor off by default in 122?
(quote)
January 15, 2024 at 2:20:48 AM PST

In Firefox 122.0b9 FR, by default, there is no Highlight Editor in the pdfjs page. To turn it on, I must set to true the pref pdfjs.enableHighlightEditor in the config editor. Then The Highlight icon will be present on the pdfjs page, but not with the same functionalities as described in the article:
- I must turn it on before selecting an area to highlight
- I can't tweak the thickness
- there's no option to show or hide all highlights
My only choice is the highlight color.

In 123.0a1 FR, the Highlight Editor is on by default, but the features are the same as in 122.0b9.

Should we wait to localize this article, Highlight Editor seems to be a work in progress?

Thanks for pointing this out, Alice! I'll take a look and circle back with more details soon.

(In reply to Donal Meehan [:dmeehan] from comment #4)

Lucas, per Comment 3, this feature is not enabled for Fx122 release.
It will ship in a later release.

Hey Donal! Thanks for the confirmation. Just wondering, is this set to ship in a dot 122 release, or are we looking at 123 instead? Also, could you double-check if the functionalities differ a bit from what's shown in the Figma?

Flags: needinfo?(lsiebert)

I'll let :marco answer here

Flags: needinfo?(mcastelluccio)

We are planning to ship in 124.

Flags: needinfo?(mcastelluccio)

(In reply to Marco Castelluccio [:marco] from comment #8)

We are planning to ship in 124.

Thanks for the confirmation, :marco! I've added it to the V124 release tracker.
Quick clarification: Are the functionalities changing as mentioned in comment 3, or will they remain as outlined in the Figma board?

Flags: needinfo?(mcastelluccio)

(In reply to Lucas Siebert from comment #5)

(In reply to Alice Wyman from comment #3)

Related discussion and questions from a French localizer:
https://support.mozilla.org/en-US/kb/view-pdf-files-firefox-or-choose-another-viewer/discuss/11969 Highlight Editor off by default in 122?
(quote)
January 15, 2024 at 2:20:48 AM PST

In Firefox 122.0b9 FR, by default, there is no Highlight Editor in the pdfjs page. To turn it on, I must set to true the pref pdfjs.enableHighlightEditor in the config editor. Then The Highlight icon will be present on the pdfjs page, but not with the same functionalities as described in the article:
- I must turn it on before selecting an area to highlight
- I can't tweak the thickness
- there's no option to show or hide all highlights
My only choice is the highlight color.

In 123.0a1 FR, the Highlight Editor is on by default, but the features are the same as in 122.0b9.

Should we wait to localize this article, Highlight Editor seems to be a work in progress?

Thanks for pointing this out, Alice! I'll take a look and circle back with more details soon.

Hi :alice.wyman! Just got the update that this has been moved to V124. I noticed you've already made the changes on the wiki – thanks for being so prompt! It's now in the V124 release tracker. If there’s anything else that needs clarifying, just give me a shout. Your attention to detail is always so valuable!

Flags: needinfo?(alice.wyman)

Lucas, I have a revision pending that will hide the new Highlight section. Please approve as ready for localization (this will alert localizers). See: https://support.mozilla.org/en-US/kb/view-pdf-files-firefox-or-choose-another-viewer/history

Flags: needinfo?(alice.wyman)

Lucas, I made another revision to show the new Highlight section for fx124, if you would rather do that, instead of hiding it.

(In reply to Lucas Siebert from comment #6)

(In reply to Donal Meehan [:dmeehan] from comment #4)

Lucas, per Comment 3, this feature is not enabled for Fx122 release.
It will ship in a later release.

Hey Donal! Thanks for the confirmation. Just wondering, is this set to ship in a dot 122 release, or are we looking at 123 instead? Also, could you double-check if the functionalities differ a bit from what's shown in the Figma?

I believe the Figma specification can be considered final, except minor details (like cursor icon). Ryan, is that correct?

Flags: needinfo?(mcastelluccio) → needinfo?(rcasey)
Summary: Highlighting in PDF - Support Article Content [Desktop V122] → Highlighting in PDF - Support Article Content [Desktop V124]

Hi @marc(In reply to Marco Castelluccio [:marco] from comment #13)

(In reply to Lucas Siebert from comment #6)

(In reply to Donal Meehan [:dmeehan] from comment #4)

Lucas, per Comment 3, this feature is not enabled for Fx122 release.
It will ship in a later release.

Hey Donal! Thanks for the confirmation. Just wondering, is this set to ship in a dot 122 release, or are we looking at 123 instead? Also, could you double-check if the functionalities differ a bit from what's shown in the Figma?

I believe the Figma specification can be considered final, except minor details (like cursor icon). Ryan, is that correct?

Hi @marco, you're correct that the Figma file is final except for deciding on cursor states.

Flags: needinfo?(rcasey)

Content updates are live, using {for fx124} tags, meaning that just users accessing the article on this version (including V124 beta) will see the updates. Thanks, Alice, for the help!

Status: REOPENED → RESOLVED
Closed: 1 year ago → 11 months ago
Resolution: --- → FIXED

Was this postponed to v125?

Flags: needinfo?(alice.wyman)

This was postponed to 125.0 in bug 1867513.
:lsiebert is there time to make the changes before go live on tuesday?

Flags: needinfo?(alice.wyman) → needinfo?(lsiebert)

Sure thing :) The {for fx124} markup has now been changed to {for fx125}, so just users accessing the article on this version (including beta/nightly) will see the updates. If we need any more adjustments, please reach out.

Flags: needinfo?(lsiebert)
Summary: Highlighting in PDF - Support Article Content [Desktop V124] → Highlighting in PDF - Support Article Content [Desktop V125]
You need to log in before you can comment on or make changes to this bug.