1868266 - ERROR: Cannot find a Visual C++ install for e.g. ATL headers.

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[jhnsmth1052]

Attachment: config.log

Steps to reproduce:

I followed these guides:
https://firefox-source-docs.mozilla.org/setup/windows_build.html#building-firefox-on-windows
https://firefox-source-docs.mozilla.org/mobile/android/geckoview/contributor/geckoview-quick-start.html#geckoview-contributor-guide

Actual results:

The "mach build" command failed for android builds on Windows with the error:

ERROR: Cannot find a Visual C++ install for e.g. ATL headers.

Comment 1

[Mike Hommey [:glandium]]

Workaround: add ac_add_options --target=aarch64 to your mozconfig.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:rsainani, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1868266 - Properly handle the Visual C++ situation when cross-compiling on Windows.

The first thing is that the target CPU may not be supported by Visual
C++, so using that, we don't find the path to a Visual C++ compiler.
By using the host CPU in that case, we can find it.

For ATL and MFC libraries, we may not be able to find them for similar
reasons, but we don't actually need them when cross-compiling, so just
return nothing for those when the target OS is not Windows.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df83a374edc0
Properly handle the Visual C++ situation when cross-compiling on Windows. r=firefox-build-system-reviewers,nalexander

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/df83a374edc0