1871219 - Cross-compiling for Android on Windows fails expanding softfp_cflags

Status: RESOLVED FIXED

(NSS :: Build, defect)

Description

[Mike Hommey [:glandium]]

The full error:

The system cannot find the path specified.
concurrent.futures.process._RemoteTraceback: 
"""
Traceback (most recent call last):
  File "C:\mozilla-build\python3\lib\concurrent\futures\process.py", line 243, in _process_worker
    r = call_item.fn(*call_item.args, **call_item.kwargs)
  File "c:\users\glandium\mozilla-central\python\mozbuild\mozbuild\frontend\gyp_reader.py", line 397, in load_gyp
    _, flat_list, targets, data = gyp.Load(*args)
  File "c:\users\glandium\mozilla-central\third_party\python\gyp\pylib\gyp\__init__.py", line 134, in Load
    result = gyp.input.Load(build_files, default_variables, includes[:],
  File "c:\users\glandium\mozilla-central\third_party\python\gyp\pylib\gyp\input.py", line 2788, in Load
    LoadTargetBuildFile(build_file, data, aux_data,
  File "c:\users\glandium\mozilla-central\third_party\python\gyp\pylib\gyp\input.py", line 477, in LoadTargetBuildFile
    LoadTargetBuildFile(dependency, data, aux_data, variables,
  File "c:\users\glandium\mozilla-central\third_party\python\gyp\pylib\gyp\input.py", line 477, in LoadTargetBuildFile
    LoadTargetBuildFile(dependency, data, aux_data, variables,
  File "c:\users\glandium\mozilla-central\third_party\python\gyp\pylib\gyp\input.py", line 426, in LoadTargetBuildFile
    ProcessVariablesAndConditionsInDict(
  File "c:\users\glandium\mozilla-central\third_party\python\gyp\pylib\gyp\input.py", line 1224, in ProcessVariablesAndConditionsInDict
    ProcessVariablesAndConditionsInDict(the_dict['variables'], phase,
  File "c:\users\glandium\mozilla-central\third_party\python\gyp\pylib\gyp\input.py", line 1277, in ProcessVariablesAndConditionsInDict
    ProcessConditionsInDict(the_dict, phase, variables, build_file)
  File "c:\users\glandium\mozilla-central\third_party\python\gyp\pylib\gyp\input.py", line 1155, in ProcessConditionsInDict
    ProcessVariablesAndConditionsInDict(merge_dict, phase,
  File "c:\users\glandium\mozilla-central\third_party\python\gyp\pylib\gyp\input.py", line 1232, in ProcessVariablesAndConditionsInDict
    expanded = ExpandVariables(value, phase, variables, build_file)
  File "c:\users\glandium\mozilla-central\third_party\python\gyp\pylib\gyp\input.py", line 928, in ExpandVariables
    raise GypError("Call to '%s' returned exit status %d while in %s." %
gyp.common.GypError: Call to '${CC:-cc} -o - -E -dM - ${CFLAGS} < /dev/null | grep __SOFTFP__ > /dev/null && echo -mfloat-abi=softfp || true' returned exit status 255 while in C:\Users\glandium\mozilla-central\security\nss\lib\freebl\freebl.gyp. while loading dependencies of C:\Users\glandium\mozilla-central\security\nss\lib\softoken\softoken.gyp while loading dependencies of C:\Users\glandium\mozilla-central\security\nss\nss.gyp while trying to load C:\Users\glandium\mozilla-central\security\nss\nss.gyp
"""

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1871219 - Wrap CC shell commands in gyp expansions.

gyp "just" calls the command via python's subprocess.Popen, using
use_shell=True. On Windows, that uses... cmd, which, of course doesn't
handle the shell syntax.

So wrap the CC shell commands with sh -c. This will be redundant on
Unix systems, but gives a chance to Windows systems to use a POSIX
shell, assuming they have one in $PATH.

Comment 2

[Mike Hommey [:glandium]]

https://hg.mozilla.org/projects/nss/rev/d27c05437ecd578f8adb1de9c990364f5350b4f4

Comment 3

[Mike Hommey [:glandium]]

Is there a bug for getting NSS 3.97 in central that this bug can be blocked on?

Comment 4

[Mike Hommey [:glandium]]

(got the answer on slack)