1868400 - Open the profiler tab just after the currently selected tab

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), enhancement)

Description

[Julien Wajsberg [:julienw]]

STR:

1. open several tabs.
2. select a tab that's not the last one.
3. profile using the devtools performance panel (or from the popup button, enabled previously in profiler.firefox.com)
4. capture the profile

=> Currently the profiler tab opens at the end of all tabs, for the user this isn't great because they lose the mental connection to the profiled tab.

In this bug instead we want the new tab to open right after the currently selected tab.

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: Bug 1868400 - Open the profiler tab just after the currently selected tab r=canaltinova!,ochameau!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80cad169f5e1
Open the profiler tab just after the currently selected tab r=canaltinova,ochameau,devtools-reviewers,profiler-reviewers

Comment 3

[Cristina Horotan [:chorotan]]

Backed out changeset 80cad169f5e1 (bug 1868400) for causing node failures at browser.js

Backout: https://hg.mozilla.org/integration/autoland/rev/18f480ff3ebb61e9b3fa4461c830f2dae6f48cd4

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=T_zxftNARYCT9YWE2r2XpQ.0&revision=80cad169f5e1a03ab5f366c42b6c11d0bc68bd12

Failure log: https://treeherder.mozilla.org/logviewer?job_id=439193814&repo=autoland&lineNumber=1533

Comment 4

[Julien Wajsberg [:julienw]]

Thanks, I forgot to update the type definition. Now I fixed it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee83b5ce89b7
Open the profiler tab just after the currently selected tab r=canaltinova,ochameau,devtools-reviewers,profiler-reviewers

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ee83b5ce89b7