1868423 - Ship new set methods proposal

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

Now that we have preliminary test262 tests for this, we could conceivably ship this.

Comment 1

[Sebastian Zartner [:sebo]]

What's the difference between this bug and bug 1805038?

Sebastian

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Ah - Mostly a structural change. I'm going to re-summary that bug as a meta bug, and this bug would be the bug under which the enablement would actually land.

Good point though -- I hadn't realized the name of that bug!

Comment 3

[Sebastian Zartner [:sebo]]

Thanks for the clarification! So I move the dev-doc-needed flag here.

Sebastian

Comment 4

[Dan Minor [:dminor]]

I'll plan to ship this for Firefox 126 unless we see webcompat problems from the Chromium implementation.

Comment 5

[bakkot]

Did this make it into the Firefox 126 train?

Comment 6

[Dan Minor [:dminor]]

Sorry, I missed 126, but I'll get this in 127.

Comment 7

[Dan Minor [:dminor]]

Attachment: Bug 1868423 - Ship New Set Methods; r=mgaudet!

As well shipping new set methods, this collapsed a few #ifdef NIGHTLY blocks together.

Comment 8

[Dan Minor [:dminor]]

Attachment: Bug 1868423 - Update shipping instructions; r=mgaudet!

Depends on D209144

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f56b016ee4c
Ship New Set Methods; r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/fede39fbed59
Update shipping instructions; r=mgaudet

Comment 10

[Atila Butkovits]

Backed out for causing failures at test_xrayToJS.xhtml.

Backout link: https://hg.mozilla.org/integration/autoland/rev/126b686f7dbf9433157c1fae8da4b7ace3013cd6

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=fede39fbed59e3dd89e94b9e4a0d2b9e5f66987e&selectedTaskRun=e1WRaGm_Tn6q53xTxHHXKw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=456609539&repo=autoland&lineNumber=10968

Comment 11

[Dan Minor [:dminor]]

Attachment: Bug 1868423 - Update test_xrayToJS.xhtml test expectations; r=peterv!

Depends on D209147

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/035dbe9bc609
Ship New Set Methods; r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/1260b3bb9312
Update shipping instructions; r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/535b96955a28
Update test_xrayToJS.xhtml test expectations; r=peterv

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/035dbe9bc609
https://hg.mozilla.org/mozilla-central/rev/1260b3bb9312
https://hg.mozilla.org/mozilla-central/rev/535b96955a28

Comment 14

[Hamish Willee]

FF127 MDN docs work for this can be tracked in https://github.com/mdn/content/issues/33563.
The reference docs already looked good, so this is just an MDN release note and browser compatibility update.

Comment 15

[Sebastian Zartner [:sebo]]

Release Note Request (optional, but appreciated)
[Why is this notable]: New methods for Set objects.
[Affects Firefox for Android]:
[Suggested wording]: Added support for the new Set methods for creating unions and intersections of two sets.
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set#set_composition and related subpages mentioned in https://github.com/mdn/content/issues/33563#issuecomment-2109424877.

Comment 16

[Pascal Chevrel:pascalc]

Added to our 127 beta notes https://www.mozilla.org/en-US/firefox/127.0beta/releasenotes/