1894897 - Perma test_xrayToJS.xhtml | A property on the Set prototype has changed! You need a security audit from an XPConnect peer - got <[\"add\",..>", expected "<.\"add\",.>" when Gecko 127 merges to beta on 2024-05-13

Status: VERIFIED FIXED

(Core :: XPConnect, defect)

Description

[Natalia Csoregi [:nataliaCs]]

• Central-as-beta-simulation
• How to run these simulations
• Failure log

[task 2024-05-03T11:30:23.183Z] 11:30:23     INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xhtml | Map is empty after calling clear 
[task 2024-05-03T11:30:23.185Z] 11:30:23     INFO - Buffered messages finished
[task 2024-05-03T11:30:23.187Z] 11:30:23     INFO - TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_xrayToJS.xhtml | A property on the Set prototype has changed! You need a security audit from an XPConnect peer - got "[\"add\", \"clear\", \"constructor\", \"delete\", \"entries\", \"forEach\", \"has\", \"keys\", \"size\", \"values\"]", expected "[\"add\", \"clear\", \"constructor\", \"delete\", \"difference\", \"entries\", \"forEach\", \"has\", \"intersection\", \"isDisjointFrom\", \"isSubsetOf\", \"isSupersetOf\", \"keys\", \"size\", \"symmetricDifference\", \"union\", \"values\"]"
[task 2024-05-03T11:30:23.187Z] 11:30:23     INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:509:14
[task 2024-05-03T11:30:23.187Z] 11:30:23     INFO - testXray@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xhtml:468:7
[task 2024-05-03T11:30:23.187Z] 11:30:23     INFO - testSet@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xhtml:1070:13
[task 2024-05-03T11:30:23.187Z] 11:30:23     INFO - go@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xhtml:199:5
[task 2024-05-03T11:30:23.188Z] 11:30:23     INFO - onload@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xhtml:1:1
[task 2024-05-03T11:30:23.188Z] 11:30:23     INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xhtml | A symbol-keyed property on the Set prototype has been changed! You need a security audit from an XPConnect peer 

Dan, can you please take a look at this?
Thank you!

Comment 1

[Dan Minor [:dminor]]

Attachment: Bug 1894897 - Move prototype check for new set methods outside of NIGHTLY_BUILD; r=mgaudet!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64b446d290e2
Move prototype check for new set methods outside of NIGHTLY_BUILD; r=mgaudet

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/64b446d290e2

Comment 4

[Cristian Tuns]

Hi, the patch doesn't seem to work in today's beta-simulation: https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&selectedTaskRun=G1dNJp4DQ5mQk-IM8XDeHg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=mochitest-chrome&revision=5bd7930869441ba7e1ff59d818b3eb435fc945b3 can you please take another look?
Failure log: https://treeherder.mozilla.org/logviewer?job_id=457249276&repo=try

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1868423

Comment 6

[Dan Minor [:dminor]]

Attachment: Bug 1894897 - Move definitions for new set methods outside of NIGHTLY_BUILD; r=mgaudet!

Comment 7

[Dan Minor [:dminor]]

Sorry, should have been more thorough on this. The test is now passing in a local central-as-beta build.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/069cd4539c03
Move definitions for new set methods outside of NIGHTLY_BUILD; r=mgaudet

Comment 9

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/069cd4539c03

Comment 10

[Sandor Molnar[:smolnar]]

Verified fixed in today's beta-sim