1868469 - Fenix URL bar reverts to the old URL after loading a new URL until successfully loading the new site

Status: REOPENED

(Firefox for Android :: Toolbar, defect, P2)

Description

[Bas Schouten (:bas.schouten)]

Steps to reproduce

1. Be on a slow network connection, or target a slow site
2. Put a new URL in the URL bar and confirm load

Expected behavior

New URL should show up in the URL bar.

Actual behavior

After entering the new URL the URL bar reverts to the old URL.

Device information

• Firefox version: 121
• Android device model: Any
• Android OS version: Any

Any additional information?

Comment 1

[Aaron Train [:aaronmt]]

Reproducible in an AVD (network configuration set to GSM/GPRS latency as an extreme). I used: https://jal.com and https://indianexpress.com on a debug build (01/15). We will add UI test coverage for this.

Comment 2

[Chris Peterson [:cpeterson]]

The Android team has not been keeping our P1 bug list up to date, so we're resetting all our P1 bugs to P2 to avoid signalling that we're actively working on bugs that we're not. The BMO documentation https://wiki.mozilla.org/BMO/UserGuide/BugFields#priority says P1 means "fix in the current release cycle" and P2 means "fix in the next release cycle or the following (nightly + 1 or nightly + 2)".

If you are actively working on this bug and expect to ship it in Fx 122 or 123, then please restore the priority back to P1.

Comment 3

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1868469 - Update the url immediately for existing engineSession (#5391)

Comment 4

[BMO Github Automation]

Authored by https://github.com/jonalmeida
https://github.com/mozilla-mobile/firefox-android/commit/a26e21ee3b090843ed2bed110eb5e8529eb79149
[main] Bug 1868469 - Update the url immediately for existing engineSession

Comment 5

[Lorand Janos]

Verified by accessing slow loading sites I found, by setting a proxy app to slow internet, by reducing the mobile connection to 2G and by activating VPN to different regions on the latest Nightly build (124.0a1 from 2024-02-19).

The new URL showed up on the URL bar.

Devices used:

• LG Nexus 5 (Android 6.0.1)
• Motorola Nexus 6 (Android 7)
• Huawei P20 (Android 10)
• Unihertz Tank 2 (Android 13)
• Samsung Galaxy S23 Ultra (Android 14)

Marking as fixed for 124.

Comment 6

[Cathy Lu [:calu]]

Discussed with Jon, will revert this change as it causes a regression. We identified a better place to update the url for slow loading sites.

Comment 7

[Cathy Lu [:calu]]

In the regressed bug part 2 patch, Jon and I tried optimizing url changes in onPageStart in GeckoEngineSession.kt, by adding onLocationChange(url, hasUserGesture = false). However, this resulted in non-navigable urls appearing in the url bar (Bug 1930302). That is because for opening app links, the user dialog of whether or not the user wants to stay in app or leave is non-blocking. This should be resolved in Bug 1929028.

Comment 8

[Cathy Lu [:calu]]

Reopening this bug as the patch was reverted in its regression bug 1914797.

Comment 9

[Jonathan Almeida [:jonalmeida]]

Unassigning since we're blocked on bug 1929028.