1869134 - Crash in [@ mozilla.appservices.fxaclient.FxaException$SyncScopedKeyMissingInServerResponse: at mozilla.appservices.fxaclient.FfiConverterTypeFxaError.read(fxa_client.kt)] "The sync scoped key was missing"

Status: RESOLVED FIXED

(Fenix :: Accounts and Sync, defect, P1)

Description

[eclaudiu64]

Crash report: https://crash-stats.mozilla.org/report/index/80d23b11-8188-40db-88e3-49ba30231209

Comment 1

[eclaudiu64]

Can you take a look?

Comment 2

[Chris Peterson [:cpeterson]]

This looks like a regression in 120.

Exception: mozilla.appservices.fxaclient.FxaException$SyncScopedKeyMissingInServerResponse
Message: The sync scoped key was missing

Frame   Module  Function  Source
0   mozilla.appservices.fxaclient.FfiConverterTypeFxaError  read  fxa_client.kt:6
1   mozilla.appservices.fxaclient.FfiConverterTypeFxaError  read  fxa_client.kt:1
2   mozilla.appservices.fxaclient.FfiConverter$DefaultImpls   liftFromRustBuffer  fxa_client.kt:13
3   mozilla.appservices.fxaclient.FfiConverterRustBuffer$DefaultImpls   liftFromRustBuffer  fxa_client.kt:6
4   mozilla.appservices.fxaclient.FfiConverterTypeFxaError  liftFromRustBuffer  fxa_client.kt:2
5   mozilla.appservices.fxaclient.FfiConverterTypeFxaError  liftFromRustBuffer  fxa_client.kt:1
6   mozilla.appservices.fxaclient.FfiConverterRustBuffer$DefaultImpls   lift  fxa_client.kt:7
7   mozilla.appservices.fxaclient.FfiConverterTypeFxaError  lift  fxa_client.kt:3
8   mozilla.appservices.fxaclient.FfiConverterTypeFxaError  lift  fxa_client.kt:2
9   mozilla.appservices.fxaclient.FxaException$ErrorHandler   lift  fxa_client.kt:2
10  mozilla.appservices.fxaclient.FxaException$ErrorHandler   lift  fxa_client.kt:1
11  mozilla.appservices.fxaclient.Fxa_clientKt  checkCallStatus   fxa_client.kt:75
12  mozilla.appservices.fxaclient.Fxa_clientKt  access$checkCallStatus  fxa_client.kt:1
13  mozilla.appservices.fxaclient.FirefoxAccount  getAccessToken  fxa_client.kt:76
14  mozilla.appservices.fxaclient.FxaClient$getAccessToken$1  invoke  FxaClient.kt:2
15  mozilla.appservices.fxaclient.FxaClient$getAccessToken$1  invoke  FxaClient.kt:1
16  mozilla.appservices.fxaclient.FxaClient   withMetrics   FxaClient.kt:16
17  mozilla.appservices.fxaclient.FxaClient   getAccessToken  FxaClient.kt:12
18  mozilla.appservices.fxaclient.FxaClient   getAccessToken$default  FxaClient.kt:6
19  mozilla.components.service.fxa.FirefoxAccount$getAccessToken$2$2  invokeSuspend   FirefoxAccount.kt:12
20  mozilla.components.service.fxa.FirefoxAccount$getAccessToken$2$2  invoke  FirefoxAccount.kt:11
21  mozilla.components.service.fxa.UtilsKt  handleFxaExceptions   Utils.kt:4
22  mozilla.components.service.fxa.UtilsKt  handleFxaExceptions   Utils.kt:20
23  mozilla.components.service.fxa.FirefoxAccount$getAccessToken$2  invokeSuspend   FirefoxAccount.kt:43
24  kotlin.coroutines.jvm.internal.BaseContinuationImpl   resumeWith  ContinuationImpl.kt:9
25  kotlinx.coroutines.DispatchedTask   run   DispatchedTask.kt:112
26  kotlinx.coroutines.internal.LimitedDispatcher$Worker  run   LimitedDispatcher.kt:4
27  kotlinx.coroutines.scheduling.TaskImpl  run   Tasks.kt:3
28  kotlinx.coroutines.scheduling.CoroutineScheduler$Worker   run   CoroutineScheduler.kt:96

Comment 3

[eclaudiu64]

I encountered this error and it affects that I can't reopen the app anymore, it crashes every time I open it, you have to reinstall the app again.

Comment 4

[Chris Peterson [:cpeterson]]

This crash was triggered by a new experiment running in Firefox 120. The experiment has been turned off, so the crashes should stop. I suspect reinstalling the app also turned off the experiment.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 10 AArch64 and ARM crashes on nightly

For more information, please visit BugBot documentation.

Comment 6

[Ben Dean-Kawamura [:bdk]]

@cpeterson: I think this may have been caused by an application-services change and I'm making a patch for it right now. Why do you think it was caused by an experiment?

Comment 7

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1869134 - Don't crash on SyncScopedKeyMissingInServerResponse (#4795)

Comment 8

[Chris Peterson [:cpeterson]]

(In reply to Ben Dean-Kawamura [:bdk] from comment #6)

@cpeterson: I think this may have been caused by an application-services change and I'm making a patch for it right now. Why do you think it was caused by an experiment?

Sorry, I confused this bug with another crash regression.

Comment 9

[BMO Github Automation]

Authored by https://github.com/bendk
https://github.com/mozilla-mobile/firefox-android/commit/1ccd2f1864c5c4ac744d9d522f9e53debc8c3666
[main] Bug 1869134 - Don't crash on SyncScopedKeyMissingInServerResponse

Comment 10

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1869134 - Don't crash on SyncScopedKeyMissingInServerResponse (backport #4795) (#4830)

Comment 11

[Ben Dean-Kawamura [:bdk]]

Comment on attachment 9368518 [details] [review]
[mozilla-mobile/firefox-android] Bug 1869134 - Don't crash on SyncScopedKeyMissingInServerResponse (backport #4795) (#4830)

Beta/Release Uplift Approval Request

• User impact if declined: Crash. This is one of the top crashers in beta right now.

Unfortunately, there's no real way to reproduce this bug. It only happens with some combination of errors in the app-services and/or server code.

• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change is very small.
• String changes made/needed:
• Is Android affected?: Yes

Comment 12

[Donal Meehan [:dmeehan]]

Comment on attachment 9368518 [details] [review]
[mozilla-mobile/firefox-android] Bug 1869134 - Don't crash on SyncScopedKeyMissingInServerResponse (backport #4795) (#4830)

121 is in release, switching the uplift request to release

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:bdk, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox121 to wontfix.

For more information, please visit BugBot documentation.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9368518 [details] [review]
[mozilla-mobile/firefox-android] Bug 1869134 - Don't crash on SyncScopedKeyMissingInServerResponse (backport #4795) (#4830)

Approved for 121.0rc2.

Comment 15

[BMO Github Automation]

Authored by https://github.com/bendk
https://github.com/mozilla-mobile/firefox-android/commit/00c8268340ef83201df7a2e80ac83b972e3b3e8d
[releases_v121] Bug 1869134 - Don't crash on SyncScopedKeyMissingInServerResponse