1869319 - Update Fxa Error handling

Status: NEW

(Fenix :: Accounts and Sync, enhancement)

Description

[Ben Dean-Kawamura [:bdk]]

There's been a few crashers in recent releases when application-services added a new FxA exception:

• https://bugzilla.mozilla.org/show_bug.cgi?id=1865792
• https://bugzilla.mozilla.org/show_bug.cgi?id=1866799
• https://bugzilla.mozilla.org/show_bug.cgi?id=1869134

Fxa errors are usually handled by handleFxaExceptions, which uses shouldPropagate to determine its behavior and shouldPropagate defaults to re-throwing the exceptions.

Comment 1

[Ben Dean-Kawamura [:bdk]]

My feeling is that shouldPropagate() should default to not throwing the exceptions. Maybe it should report an error to Sentry instead. I don't know much about the original intent of that code though.