1869185 - [css-properties-values-api] Support interpolating registered custom properties.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Tess Hoffman [:zrhoffman]]

Once support for custom properties in discrete animations is added in bug 1846516, we can add support for interpolating custom properties.

Comment 1

[zsun]

Attachment: Bug 1869185 - Add initial interpolating animation support for registered custom properties. r=zrhoffman,emilio

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1869185 - Various clean-ups and fixes on top of the previous patch. r=zsun,zrhoffman,#style

• Move the manual code outside the auto-generated animated_properties
  file.

• Treat unregistered custom properties and universal-syntax properties
  the same.

• A void a bunch of copy-pasta and extra unnecessary clone() calls.

• Fix animations with mismatched multipliers, custom property names,
  etc. This isn't really testable, since afaict you can't create such
  an animation (maybe if you override the registration dynamically?),
  but seems better for consistency.

Depends on D198004

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90216cb9029e
Add initial interpolating animation support for registered custom properties. r=emilio
https://hg.mozilla.org/integration/autoland/rev/e80ef237bb81
Various clean-ups and fixes on top of the previous patch. r=zrhoffman,firefox-style-system-reviewers

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/90216cb9029e
https://hg.mozilla.org/mozilla-central/rev/e80ef237bb81

Comment 5

[zsun]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

Created attachment 9376016 [details]
Bug 1869185 - Various clean-ups and fixes on top of the previous patch. r=zsun,zrhoffman,#style
Thanks very much Emilio!