186920 - Loosen checking for Windows ME user-agent

Status: VERIFIED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[bk039]

User-Agent:       Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.3a) Gecko/20021212
Build Identifier: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.3a) Gecko/20021212

In Bugzilla deployment found on mozilla.org:

The "advanced" bug report form does not appear to include Windows ME.  However,
it is still possible to set the operating system from the bug report after it
has been submitted to the database (although it spams all on the CC list.)



Reproducible: Always

Steps to Reproduce:
1. Open http://bugzilla.mozilla.org/
2. Select the "Enter a new bug report" link, which is tagged with "(Advanced)".
3. Select any product.  
4. Scroll down to "Operating System", and attempt to select "Windows ME".

Actual Results:  
Windows Me is not available in the list. 

Expected Results:  
Windows ME should be in the listing for the advanced bug report page.

Comment 1

[Dave Miller [:justdave]]

That's not the advanced bug report page, that's the guided page.  The advanced
link goes to the guided one anyway if you don't have editbugs privs.  (try both
links, I bet they go to the same place).

Are you using Windows ME when you file it?  If so, that's a bug, because the OS
you're using is always supposed to show up on the list in the guided form (and
not much else)

The guided form is Gerv's baby, reassigning...

Comment 2

[Gervase Markham [:gerv]]

[e-mail]: I need to know if you were using Windows ME when you
attempted to file the bug.

Gerv

Comment 3

[bk039]

Yes, I was submitting it with Mozilla 1.3a under Windows ME at the time (as
shown in the build identifier).  The same problem does not occurr under IE 5.5,
thus it seems to be Mozilla specific.  

Comment 4

[Gervase Markham [:gerv]]

Here's the bug, on enter_bug.cgi, line 183:
  /\(.*Win.*98.*4\.9.*\)/ && do {return "Windows ME";};

That should probably read:
  /\(.*Win.*9x.*4\.9.*\)/ && do {return "Windows ME";};

Does anyone know for certain the details of User Agents on ME?

Gerv

Comment 5

[Dave Miller [:justdave]]

According to comment 3, it works in IE currently, so probably both lines need to
be there.

Comment 6

[Gervase Markham [:gerv]]

Attachment: Patch v.1

OK; this checks for 98 or 9x.

Gerv

Comment 7

[Gervase Markham [:gerv]]

Moving to Bugzilla product.

Gerv

Comment 8

[Dave Miller [:justdave]]

Comment on attachment 110757 [details] [diff] [review]
Patch v.1

I don't have Windows ME to test this. :-)

Check it in, and let's have the reporter test it on landfill after landfill
picks this up... (cron job updates it from cvs hourly on bugzilla-tip)

Comment 9

[Gervase Markham [:gerv]]

Fixed.

Checking in enter_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/enter_bug.cgi,v  <--  enter_bug.cgi
new revision: 1.79; previous revision: 1.78
done

Gerv

Comment 10

[bk039]

Just verified that this bug is fixed - appears to work in Mozilla for Win98/ME.  

Testing bugzilla-tip and bugzilla-devel on landslide with IE6 (Version
6.0.2800.1106) under Windows 98 does not work (same issue as above).  However,
this is probably a seperate issue worthy of another report.  

Comment 11

[Sam Katz]

This must be reopened. For some reason, I lost privileges to do so.  The
testcase in the original report fails. all I want is for "Windows ME" to be in
the dropdown box. It would be nice if it detected correctly.. (right now it
detects as windows 98.)

Comment 12

[Jacob Steenhagen]

Sam, what is your user agent string?  Also, are you saying it doesn't work on 
bugzilla.mozilla.org or your own installation?

Comment 13

[Sam Katz]

http://bugzilla.mozilla.org/enter_bug.cgi?product=Browser

Does not list or detect windows me. it detects it as other.

sorry--I knew this, but wanted to test it absolutely first.

windows me.. version: 4.90.3000 (standard.)

Comment 14

[Sam Katz]

Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.4a) Gecko/20030411 Phoenix/0.5+

Forgot the browser string ;-)

Note that its never worked for me, I just got around to complaining on
mozillazine, but I don't think this is a regression.

Comment 15

[bk039]

For the record, the bug was fixed at:

http://landfill.bugzilla.org/bugzilla-tip/enter_bug.cgi?product=WorldControl

The problem was actually a bug in Bugzilla, as opposed to a Mozilla.org
configuration (and hence the bug is flagged as fixed).  You can verify the fix
by opening above link to test the latest development code.

All that's left is to bribe the Mozilla.org webmaster to update Bugzilla to
verstion 2.17.3.

Comment 16

[Bradley Baetz (:bbaetz)]

There are plans to upgrade to 2.17.4 when it comes out. Which is meant to be RSN.

Comment 17

[Gervase Markham [:gerv]]

*** Bug 214556 has been marked as a duplicate of this bug. ***