Closed Bug 1869514 Opened 2 years ago Closed 1 year ago

Intermittent comm/mail/base/test/browser/browser_threadTreeDeleting.js | selected row should be above the last visible row - 299 > 299

Categories

(Thunderbird :: Folder and Message Lists, defect, P5)

defect

Tracking

(thunderbird138 fixed)

RESOLVED FIXED
138 Branch
Tracking Status
thunderbird138 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: freaktechnik)

References

Details

(Keywords: intermittent-failure, intermittent-testcase)

Attachments

(1 file, 1 obsolete file)

See Also: → 1864276
See Also: → 1881034

This is a tricky one. The test is already waiting extra time for the
additional scroll events, but the screenshot of the fail shows the
threadTree to be in a wrong scroll position. This patch resets that
timeout after each late scroll event to better catch all of them. This
basically forces the UI to be idle for the requested timeout. Maybe
that helps.

The test also adds two more asserts which might help with better
understanding what is going wrong.

Assignee: nobody → john
Status: NEW → ASSIGNED
Attachment #9468643 - Attachment is obsolete: true
Status: ASSIGNED → NEW
Assignee: john → nobody

This issue is apparent for me when running the test with --verify. The race this solves is that we set the
selected message in the thread tree after the deletion has completed in the database. Sometimes this selection
would happen after we had manually altered the selected index in the test, and as such would reset it to an
earlier state. This resolves the race by waiting for that selection with every keypress that is expected to
update the selected message. We might want to address the selection override race by only applying the
selection if there haven't been any interactions since the deletion was triggered or by blocking interaction
while the deletion is pending.

Assignee: nobody → martin
Status: NEW → ASSIGNED
Target Milestone: --- → 138 Branch

Pushed by alessandro@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/1552a1dbcc79
Fix selection race when deleting in browser_threadTreeDeleting. r=john.bieling

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: